Skip to content

Commit c80cd52

Browse files
committed
cvm/overlay: (2/2) Fix NMethod test infra
Match makeMethodNotCompilable and NMethod whitebox API
1 parent 3b34465 commit c80cd52

5 files changed

Lines changed: 17 additions & 22 deletions

File tree

cvm.mk

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -439,6 +439,7 @@ endif
439439
$(call overlay_single,jdk8u,hotspot/test/compiler/7196199/Test7196199.java, $(JDK8_SRCROOT))
440440
$(call overlay_single,jdk8u,hotspot/test/compiler/8004741/Test8004741.java, $(JDK8_SRCROOT))
441441
$(call overlay_single,jdk8u,hotspot/test/compiler/stable/StableConfiguration.java, $(JDK8_SRCROOT))
442+
$(call overlay_single,jdk8u,hotspot/test/testlibrary/whitebox/sun/hotspot/code/NMethod.java, $(JDK8_SRCROOT))
442443

443444
-overlay-jtreg:
444445
$(call overlay_single,jdk8u,test/jtreg-ext/requires/VMProps.java, $(JDK8_SRCROOT))

cvm/conf/jtreg_hotspot8_excludes_aarch64.list

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,14 +20,8 @@ compiler/rtm/cli/TestUseRTMDeoptOptionOnUnsupportedConfig.java
2020
compiler/rtm/cli/TestUseRTMForStackLocksOptionOnUnsupportedConfig.java
2121
compiler/rtm/cli/TestUseRTMXendForLockBusyOption.java
2222
compiler/startup/NumCompilerThreadsCheck.java
23-
compiler/tiered/Level2RecompilationTest.java
24-
compiler/tiered/ConstantGettersTransitionsTest.java
2523
compiler/tiered/NonTieredLevelsTest.java
26-
compiler/tiered/TieredLevelsTest.java
2724
compiler/tiered/LevelTransitionTest.java
28-
compiler/whitebox/EnqueueMethodForCompilationTest.java
29-
compiler/whitebox/GetNMethodTest.java
30-
compiler/whitebox/MakeMethodNotCompilableTest.java
3125
gc/6941923/Test6941923.java
3226
gc/arguments/TestAggressiveHeap.java
3327
gc/arguments/TestG1ConcRefinementThreads.java

cvm/conf/jtreg_hotspot8_excludes_x64.list

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,14 +14,8 @@ compiler/rtm/cli/TestRTMTotalCountIncrRateOptionOnUnsupportedConfig.java
1414
compiler/rtm/cli/TestUseRTMDeoptOptionOnUnsupportedConfig.java
1515
compiler/rtm/cli/TestUseRTMForStackLocksOptionOnUnsupportedConfig.java
1616
compiler/startup/NumCompilerThreadsCheck.java
17-
compiler/tiered/Level2RecompilationTest.java
18-
compiler/tiered/ConstantGettersTransitionsTest.java
1917
compiler/tiered/NonTieredLevelsTest.java
20-
compiler/tiered/TieredLevelsTest.java
2118
compiler/tiered/LevelTransitionTest.java
22-
compiler/whitebox/EnqueueMethodForCompilationTest.java
23-
compiler/whitebox/GetNMethodTest.java
24-
compiler/whitebox/MakeMethodNotCompilableTest.java
2519
gc/6941923/Test6941923.java
2620
gc/arguments/TestAggressiveHeap.java
2721
gc/arguments/TestG1ConcRefinementThreads.java

cvm/overlay/jdk8u/hotspot/test/testlibrary/whitebox/sun/hotspot/code/NMethod.java

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -34,21 +34,25 @@ public static NMethod get(Executable method, boolean isOsr) {
3434
return obj == null ? null : new NMethod(obj);
3535
}
3636
private NMethod(Object[] obj) {
37-
assert obj.length == 3;
38-
comp_level = (Integer) obj[0];
39-
compile_id = (Integer) obj[1];
37+
assert obj.length == 5;
38+
comp_level = (Integer) obj[1];
4039
insts = (byte[]) obj[2];
40+
compile_id = (Integer) obj[3];
41+
entry_point = (Long) obj[4];
4142
}
4243
public final byte[] insts;
4344
public final int comp_level;
4445
public final int compile_id;
46+
public final long entry_point;
4547

4648
@Override
4749
public String toString() {
48-
return "NMethod{" +
49-
"insts=" + insts +
50-
", comp_level=" + comp_level +
51-
", compile_id=" + compile_id +
52-
'}';
50+
return "NMethod{"
51+
+ super.toString()
52+
+ ", insts=" + insts
53+
+ ", comp_level=" + comp_level
54+
+ ", compile_id=" + compile_id
55+
+ ", entry_point=" + entry_point
56+
+ '}';
5357
}
5458
}

src/hotspot/share/prims/whitebox.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2471,9 +2471,9 @@ static JNINativeMethod methods[] = {
24712471
{CC"isIntrinsicAvailable0",
24722472
CC"(Ljava/lang/reflect/Executable;Ljava/lang/reflect/Executable;I)Z",
24732473
(void*)&WB_IsIntrinsicAvailable},
2474-
{CC"makeMethodNotCompilable0",
2475-
CC"(Ljava/lang/reflect/Executable;IZ)V", (void*)&WB_MakeMethodNotCompilable},
24762474
#if HOTSPOT_TARGET_CLASSLIB == 8
2475+
{CC"makeMethodNotCompilable",
2476+
CC"(Ljava/lang/reflect/Executable;IZ)V", (void*)&WB_MakeMethodNotCompilable},
24772477
{CC"testSetDontInlineMethod",
24782478
CC"(Ljava/lang/reflect/Executable;Z)Z", (void*)&WB_TestSetDontInlineMethod},
24792479
{CC"getMethodCompilationLevel",
@@ -2483,6 +2483,8 @@ static JNINativeMethod methods[] = {
24832483
{CC"testSetForceInlineMethod",
24842484
CC"(Ljava/lang/reflect/Executable;Z)Z", (void*)&WB_TestSetForceInlineMethod},
24852485
#elif HOTSPOT_TARGET_CLASSLIB == 17
2486+
{CC"makeMethodNotCompilable0",
2487+
CC"(Ljava/lang/reflect/Executable;IZ)V", (void*)&WB_MakeMethodNotCompilable},
24862488
{CC"testSetDontInlineMethod0",
24872489
CC"(Ljava/lang/reflect/Executable;Z)Z", (void*)&WB_TestSetDontInlineMethod},
24882490
{CC"getMethodCompilationLevel0",

0 commit comments

Comments
 (0)