fix: Ensure --always doesn't increment twice (#289)

IncPatch (and family) already handle the case where we have a
prerelease + metadata set. We don't need to strip it before then.
If we strip it too early, then we can accidentally regress two
versions.

Signed-off-by: Justin Chadwell <justin@unikraft.com>

Author: jedevc

internal/svu/svu.go

@@ -91,12 +91,6 @@ func nextVersion(
 		return *current, nil
 	}
 
-	if opts.Always {
-		c, _ := current.SetMetadata("")
-		c, _ = c.SetPrerelease("")
-		current = &c
-	}
-
 	var result semver.Version
 	var err error
 	switch opts.Action {
@@ -113,6 +107,12 @@ func nextVersion(
 		return result, err
 	}
 
+	if opts.Always {
+		c, _ := current.SetMetadata("")
+		c, _ = c.SetPrerelease("")
+		current = &c
+	}
+
 	if opts.Action == PreRelease {
 		result, err = nextPreRelease(current, &result, opts.PreRelease)
 		if err != nil {

internal/svu/svu_test.go

@@ -190,7 +190,7 @@ func TestCmd(t *testing.T) {
 				Always: true,
 			})
 			require.NoError(t, err)
-			require.Equal(t, "1.2.4", v.String())
+			require.Equal(t, "1.2.3", v.String())
 		})
 		t.Run("previous had meta + always, add meta", func(t *testing.T) {
 			v, err := nextVersion(semver.MustParse("1.2.3-alpha.1+1"), "v1.2.3-alpha.1+1", Options{
@@ -201,7 +201,7 @@ func TestCmd(t *testing.T) {
 				Metadata:   "10",
 			})
 			require.NoError(t, err)
-			require.Equal(t, "1.2.4-alpha.2+10", v.String())
+			require.Equal(t, "1.2.3-alpha.2+10", v.String())
 		})
 		t.Run("previous had meta, change it", func(t *testing.T) {
 			v, err := nextVersion(semver.MustParse("1.2.3-alpha.1+1"), "v1.2.3-alpha.1+1", Options{