chore(in-person): simplify redirect route logic

the get_target_route_name method doesn't do much, so we remove it and
instead we just include the logic in get_redirect_url. this simplifies
the code a bit more.

Author: lalver1

benefits/enrollment/views.py

@@ -28,11 +28,8 @@ class IndexView(AgencySessionRequiredMixin, EligibleSessionRequiredMixin, Redire
 
     route_origin = routes.ENROLLMENT_INDEX
 
-    def get_target_route_name(self):
-        return self.agency.enrollment_index_route
-
     def get_redirect_url(self, *args, **kwargs):
-        route_name = self.get_target_route_name()
+        route_name = self.agency.enrollment_index_route
         return reverse(route_name)
 
     def get(self, request, *args, **kwargs):

benefits/in_person/views.py

@@ -105,8 +105,9 @@ class EnrollmentView(IndexView):
 
     route_origin = routes.IN_PERSON_ENROLLMENT
 
-    def get_target_route_name(self):
-        return self.agency.in_person_enrollment_index_route
+    def get_redirect_url(self, *args, **kwargs):
+        route_name = self.agency.in_person_enrollment_index_route
+        return reverse(route_name)
 
 
 def enrollment(request):

tests/pytest/enrollment/test_views.py

@@ -38,9 +38,6 @@ def view(self, app_request, model_LittlepayConfig):
         v.agency = model_LittlepayConfig.transit_agency
         return v
 
-    def test_get_target_route_name(self, view):
-        assert view.get_target_route_name() == view.agency.enrollment_index_route
-
     def test_get_redirect_url(self, view):
 
         assert view.get_redirect_url() == reverse(view.agency.enrollment_index_route)

tests/pytest/in_person/test_views.py

@@ -285,8 +285,8 @@ def view(self, app_request, mocked_session_agency_littlepay):
         v.agency = mocked_session_agency_littlepay(app_request)
         return v
 
-    def test_get_target_route_name_for_littlepay(self, view):
-        assert view.get_target_route_name() == routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX
+    def test_get_redirect_url_for_littlepay(self, view):
+        assert view.get_redirect_url() == reverse(view.agency.in_person_enrollment_index_route)
 
 
 @pytest.mark.django_db