chore(in-person): remove redundant view and imports

LittlepayEnrollmentView replaces the in-person enrollment view
function, so this cleanup removes code that is not needed anymore.

Author: lalver1

benefits/in_person/views.py

@@ -1,6 +1,5 @@
 import logging
 
-import sentry_sdk
 from django.contrib.admin import site as admin_site
 from django.shortcuts import redirect
 from django.template.response import TemplateResponse
@@ -11,9 +10,7 @@
 from benefits.core import models, session
 from benefits.eligibility import analytics as eligibility_analytics
 from benefits.enrollment import analytics as enrollment_analytics
-from benefits.enrollment.enrollment import Status
 from benefits.enrollment.views import IndexView
-from benefits.enrollment_littlepay.enrollment import get_card_types_for_js, enroll
 from benefits.enrollment_littlepay.session import Session as LittlepaySession
 from benefits.enrollment_littlepay.views import TokenView, IndexView as LittlepayIndexView
 from benefits.enrollment_switchio.session import Session as SwitchioSession
@@ -119,102 +116,6 @@ def get_context_data(self, **kwargs):
         return context
 
 
-def enrollment(request):
-    """View handler for the in-person enrollment page."""
-    # POST back after transit processor form, process card token
-    if request.method == "POST":
-        form = forms.CardTokenizeSuccessForm(request.POST)
-        if not form.is_valid():
-            raise Exception("Invalid card token form")
-
-        flow = session.flow(request)
-        card_token = form.cleaned_data.get("card_token")
-        status, exception = enroll(request, card_token)
-
-        match (status):
-            case Status.SUCCESS:
-                agency = session.agency(request)
-                expiry = session.enrollment_expiry(request)
-                verified_by = f"{request.user.first_name} {request.user.last_name}"
-                event = models.EnrollmentEvent.objects.create(
-                    transit_agency=agency,
-                    enrollment_flow=flow,
-                    enrollment_method=models.EnrollmentMethods.IN_PERSON,
-                    verified_by=verified_by,
-                    expiration_datetime=expiry,
-                )
-                event.save()
-                enrollment_analytics.returned_success(
-                    request, flow.group_id, enrollment_method=models.EnrollmentMethods.IN_PERSON
-                )
-                return redirect(routes.IN_PERSON_ENROLLMENT_SUCCESS)
-
-            case Status.SYSTEM_ERROR:
-                enrollment_analytics.returned_error(
-                    request, str(exception), enrollment_method=models.EnrollmentMethods.IN_PERSON
-                )
-                sentry_sdk.capture_exception(exception)
-                return redirect(routes.IN_PERSON_ENROLLMENT_SYSTEM_ERROR)
-
-            case Status.EXCEPTION:
-                enrollment_analytics.returned_error(
-                    request, str(exception), enrollment_method=models.EnrollmentMethods.IN_PERSON
-                )
-                sentry_sdk.capture_exception(exception)
-                return redirect(routes.IN_PERSON_SERVER_ERROR)
-
-            case Status.REENROLLMENT_ERROR:
-                enrollment_analytics.returned_error(
-                    request, "Re-enrollment error.", enrollment_method=models.EnrollmentMethods.IN_PERSON
-                )
-                return redirect(routes.IN_PERSON_ENROLLMENT_REENROLLMENT_ERROR)
-    # GET enrollment index
-    else:
-        agency = session.agency(request)
-
-        tokenize_retry_form = forms.CardTokenizeFailForm(routes.IN_PERSON_ENROLLMENT_RETRY, "form-card-tokenize-fail-retry")
-        tokenize_server_error_form = forms.CardTokenizeFailForm(
-            routes.IN_PERSON_SERVER_ERROR, "form-card-tokenize-fail-server-error"
-        )
-        tokenize_system_error_form = forms.CardTokenizeFailForm(
-            routes.IN_PERSON_ENROLLMENT_SYSTEM_ERROR, "form-card-tokenize-fail-system-error"
-        )
-        tokenize_success_form = forms.CardTokenizeSuccessForm(
-            action_url=routes.IN_PERSON_ENROLLMENT, auto_id=True, label_suffix=""
-        )
-
-        context = {
-            **admin_site.each_context(request),
-            "forms": [tokenize_retry_form, tokenize_server_error_form, tokenize_system_error_form, tokenize_success_form],
-            "cta_button": "tokenize_card",
-            "enrollment_method": models.EnrollmentMethods.IN_PERSON,
-            "token_field": "card_token",
-            "form_retry": tokenize_retry_form.id,
-            "form_server_error": tokenize_server_error_form.id,
-            "form_success": tokenize_success_form.id,
-            "form_system_error": tokenize_system_error_form.id,
-            "title": f"{agency.long_name} | In-person enrollment | {admin_site.site_title}",
-            "card_types": get_card_types_for_js(),
-        }
-
-        match agency.littlepay_config.environment:
-            case models.Environment.QA.value:
-                url = "https://verify.qa.littlepay.com/assets/js/littlepay.min.js"
-                card_tokenize_env = "https://verify.qa.littlepay.com"
-            case models.Environment.PROD.value:
-                url = "https://verify.littlepay.com/assets/js/littlepay.min.js"
-                card_tokenize_env = "https://verify.littlepay.com"
-            case _:
-                raise ValueError("Unrecognized environment value")
-
-        transit_processor_context = dict(
-            name="Littlepay", website="https://littlepay.com", card_tokenize_url=url, card_tokenize_env=card_tokenize_env
-        )
-        context.update({"transit_processor": transit_processor_context})
-
-        return TemplateResponse(request, "in_person/enrollment/index_littlepay.html", context)
-
-
 def reenrollment_error(request):
     """View handler for a re-enrollment attempt that is not yet within the re-enrollment window."""
 

tests/pytest/in_person/test_views.py

@@ -3,7 +3,6 @@
 
 
 from benefits.core import models
-from benefits.enrollment.enrollment import Status
 from benefits.in_person import forms
 import benefits.in_person.views as views
 from benefits.routes import routes
@@ -160,116 +159,6 @@ def test_get_context_data(self, view, app_request):
         assert "title" in context
 
 
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "model_LittlepayConfig")
-def test_enrollment_logged_in_get(admin_client):
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-
-    response = admin_client.get(path)
-    assert response.status_code == 200
-    assert response.template_name == "in_person/enrollment/index.html"
-    assert "forms" in response.context_data
-    assert "cta_button" in response.context_data
-    assert "token_field" in response.context_data
-    assert "form_retry" in response.context_data
-    assert "form_success" in response.context_data
-    assert "card_types" in response.context_data
-
-    # not supporting internationalization in in_person app yet
-    assert "overlay_language" not in response.context_data
-
-
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "mocked_session_eligible")
-def test_enrollment_post_invalid_form(admin_client, invalid_form_data):
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-
-    with pytest.raises(Exception, match=r"form"):
-        admin_client.post(path, invalid_form_data)
-
-
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "model_EnrollmentFlow", "model_LittlepayGroup")
-def test_enrollment_post_valid_form_success(
-    mocker,
-    admin_client,
-    card_tokenize_form_data,
-    mocked_eligibility_analytics_module,
-    mocked_enrollment_analytics_module,
-    model_TransitAgency,
-    model_EnrollmentFlow,
-    model_User,
-):
-    mocker.patch("benefits.in_person.views.enroll", return_value=(Status.SUCCESS, None))
-    spy = mocker.spy(views.models.EnrollmentEvent.objects, "create")
-
-    # force the model_User to be the logged in user
-    # e.g. the TransitAgency staff person assisting this in-person enrollment
-    admin_client.force_login(model_User)
-
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-    response = admin_client.post(path, card_tokenize_form_data)
-
-    spy.assert_called_once_with(
-        transit_agency=model_TransitAgency,
-        enrollment_flow=model_EnrollmentFlow,
-        enrollment_method=models.EnrollmentMethods.IN_PERSON,
-        verified_by=f"{model_User.first_name} {model_User.last_name}",
-        expiration_datetime=None,
-    )
-
-    assert response.status_code == 302
-    assert response.url == reverse(routes.IN_PERSON_ENROLLMENT_SUCCESS)
-    mocked_enrollment_analytics_module.returned_success.assert_called_once()
-
-
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "model_EnrollmentFlow")
-def test_enrollment_post_valid_form_system_error(
-    mocker, admin_client, card_tokenize_form_data, mocked_enrollment_analytics_module, mocked_sentry_sdk_module
-):
-    mocker.patch("benefits.in_person.views.enroll", return_value=(Status.SYSTEM_ERROR, None))
-
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-    response = admin_client.post(path, card_tokenize_form_data)
-
-    assert response.status_code == 302
-    assert response.url == reverse(routes.IN_PERSON_ENROLLMENT_SYSTEM_ERROR)
-    mocked_enrollment_analytics_module.returned_error.assert_called_once()
-    mocked_sentry_sdk_module.capture_exception.assert_called_once()
-
-
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "model_EnrollmentFlow")
-def test_enrollment_post_valid_form_exception(
-    mocker, admin_client, card_tokenize_form_data, mocked_enrollment_analytics_module, mocked_sentry_sdk_module
-):
-    mocker.patch("benefits.in_person.views.enroll", return_value=(Status.EXCEPTION, None))
-
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-    response = admin_client.post(path, card_tokenize_form_data)
-
-    assert response.status_code == 302
-    assert response.url == reverse(routes.IN_PERSON_SERVER_ERROR)
-    mocked_enrollment_analytics_module.returned_error.assert_called_once()
-    mocked_sentry_sdk_module.capture_exception.assert_called_once()
-
-
-@pytest.mark.django_db
-@pytest.mark.usefixtures("mocked_session_agency", "mocked_session_flow", "model_EnrollmentFlow")
-def test_enrollment_post_valid_form_reenrollment_error(
-    mocker, admin_client, card_tokenize_form_data, mocked_enrollment_analytics_module
-):
-    mocker.patch("benefits.in_person.views.enroll", return_value=(Status.REENROLLMENT_ERROR, None))
-
-    path = reverse(routes.IN_PERSON_ENROLLMENT_LITTLEPAY_INDEX)
-    response = admin_client.post(path, card_tokenize_form_data)
-
-    assert response.status_code == 302
-    assert response.url == reverse(routes.IN_PERSON_ENROLLMENT_REENROLLMENT_ERROR)
-    mocked_enrollment_analytics_module.returned_error.assert_called_once()
-
-
 @pytest.mark.django_db
 @pytest.mark.usefixtures("mocked_session_flow", "mocked_session_agency")
 def test_reenrollment_error(admin_client):