refactor(enrollment): request_registration takes redirect param

so this can be effectively (re)used across DIGITAL and IN_PERSON

Author: thekaveman

benefits/enrollment_switchio/enrollment.py

@@ -46,7 +46,9 @@ class Token:
     par: str = None
 
 
-def request_registration(request, switchio_config: SwitchioConfig) -> RegistrationResponse:
+def request_registration(
+    request, switchio_config: SwitchioConfig, redirect_route: str = routes.ENROLLMENT_SWITCHIO_INDEX
+) -> RegistrationResponse:
     try:
         client = TokenizationClient(
             api_url=switchio_config.tokenization_api_base_url,
@@ -57,7 +59,7 @@ def request_registration(request, switchio_config: SwitchioConfig) -> Registrati
             ca_certificate=switchio_config.ca_certificate_data,
         )
 
-        route = reverse(routes.ENROLLMENT_SWITCHIO_INDEX)
+        route = reverse(redirect_route)
         redirect_url = _generate_redirect_uri(request, route)
 
         registration = client.request_registration(

benefits/enrollment_switchio/views.py

@@ -104,6 +104,7 @@ class GatewayUrlView(AgencySessionRequiredMixin, EligibleSessionRequiredMixin, V
     """View for the tokenization gateway registration"""
 
     enrollment_method = models.EnrollmentMethods.DIGITAL
+    route_redirect = routes.ENROLLMENT_SWITCHIO_INDEX
     route_system_error = routes.ENROLLMENT_SYSTEM_ERROR
     route_server_error = routes.SERVER_ERROR
 
@@ -136,7 +137,7 @@ def get(self, request: HttpRequest, *args, **kwargs):
                 return JsonResponse(data)
 
     def _request_registration(self, request: HttpRequest, switchio_config: SwitchioConfig, session: Session) -> JsonResponse:
-        response = request_registration(request, switchio_config)
+        response = request_registration(request, switchio_config, self.route_redirect)
 
         if response.status is Status.SUCCESS:
             registration = response.registration

tests/pytest/enrollment_switchio/test_enrollment.py

@@ -1,4 +1,5 @@
 from django.conf import settings
+from django.urls import reverse
 import pytest
 from requests import HTTPError
 from benefits.enrollment.enrollment import Status
@@ -8,7 +9,9 @@
     get_registration_status,
     request_registration,
     get_latest_active_token_value,
+    _generate_redirect_uri,
 )
+from benefits.routes import routes
 
 
 @pytest.fixture
@@ -51,13 +54,42 @@ def mocked_group_expiry_with_expiry():
 
 @pytest.mark.django_db
 @pytest.mark.usefixtures("mocked_api_base_url")
-def test_request_registration_success(mocker, app_request, model_SwitchioConfig, mocked_registration):
-    mocker.patch(
-        "benefits.enrollment_switchio.enrollment.TokenizationClient.request_registration", return_value=mocked_registration
-    )
+def test_request_registration_success__default_redirect(
+    mocker, app_request, model_SwitchioConfig, mocked_registration, settings
+):
+    tokenization_client = mocker.patch("benefits.enrollment_switchio.enrollment.TokenizationClient").return_value
+    tokenization_client.request_registration.return_value = mocked_registration
+    expected_redirect = _generate_redirect_uri(app_request, reverse(routes.ENROLLMENT_SWITCHIO_INDEX))
 
     registration_response = request_registration(app_request, model_SwitchioConfig)
 
+    tokenization_client.request_registration.assert_called_once_with(
+        eshopRedirectUrl=expected_redirect,
+        mode=RegistrationMode.REGISTER,
+        eshopResponseMode=EshopResponseMode.QUERY,
+        timeout=settings.REQUESTS_TIMEOUT,
+    )
+    assert registration_response.status == Status.SUCCESS
+    assert registration_response.registration == mocked_registration
+
+
+@pytest.mark.django_db
+@pytest.mark.usefixtures("mocked_api_base_url")
+def test_request_registration_success__custom_redirect(
+    mocker, app_request, model_SwitchioConfig, mocked_registration, settings
+):
+    tokenization_client = mocker.patch("benefits.enrollment_switchio.enrollment.TokenizationClient").return_value
+    tokenization_client.request_registration.return_value = mocked_registration
+    expected_redirect = _generate_redirect_uri(app_request, reverse(routes.INDEX))
+
+    registration_response = request_registration(app_request, model_SwitchioConfig, routes.INDEX)
+
+    tokenization_client.request_registration.assert_called_once_with(
+        eshopRedirectUrl=expected_redirect,
+        mode=RegistrationMode.REGISTER,
+        eshopResponseMode=EshopResponseMode.QUERY,
+        timeout=settings.REQUESTS_TIMEOUT,
+    )
     assert registration_response.status == Status.SUCCESS
     assert registration_response.registration == mocked_registration
 

tests/pytest/enrollment_switchio/test_views.py

@@ -264,6 +264,7 @@ def view(self, app_request, mocked_session_agency):
 
     def test_view(self, view: GatewayUrlView):
         assert view.enrollment_method == models.EnrollmentMethods.DIGITAL
+        assert view.route_redirect == routes.ENROLLMENT_SWITCHIO_INDEX
         assert view.route_system_error == routes.ENROLLMENT_SYSTEM_ERROR
         assert view.route_server_error == routes.SERVER_ERROR