Skip to content

Consider updating workflow triggers that reference both 'push' and 'pull_request' #4060

Description

@jgravois

From the looks of #1180, we enabled 'pull_request' as a tests-pytest.yml trigger in order to support contributions from forked repositories and we've tolerated some duplication ever since.

Image

now that pull requests from non-contributors are disabled, since we don't have that enabled anymore, it would be a nice quality of life improvement to update our triggers and avoid running duplicate github actions when pull requests are updated.

Acceptance Criteria

  • the workflows below only run once when a pull request is opened and when subsequent commits are pushed to the branch.
  • the workflows below continue to run on push to main
  • tests-pytest.yml
  • codeql.yml
  • check-dynamic-version.yml
  • check-migrations-and-messages.yml

Additional context

nasa/cFS#169

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    testsRelated to automated testing (unit, UI, integration, etc.)

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions