fix: pass --no-sandbox via ELECTRON_EXTRA_LAUNCH_ARGS instead of argv

Go's flag.Parse() in agy-bin rejects unknown flags at startup, causing
'flags provided but not defined: -no-sandbox' whenever the TUI is launched
inside the Workshop LXD container.

Replace argv injection with ELECTRON_EXTRA_LAUNCH_ARGS so Electron's
process spawner picks up --no-sandbox before the Chromium subprocess
starts, bypassing Go's flag parser entirely.

Also suppress sandbox injection for non-interactive modes (--print, -p,
--prompt, --prompt-interactive, -i) since they do not launch the Electron
TUI at all.

Update tests/unit/agy-wrapper.sh to verify the env var is set rather
than the argv flag, and adjust expectations for non-interactive cases.

Author: rajannpatel

bin/agy

@@ -7,6 +7,7 @@ ARGS=()
 HAS_SANDBOX=false
 HAS_NO_SANDBOX=false
 HAS_UTILITY_FLAG=false
+HAS_NONINTERACTIVE=false
 COMMAND_TOKEN=""
 IS_SUBCOMMAND=false
 SKIP_NEXT=false
@@ -27,6 +28,15 @@ VALUE_FLAGS=(
   -p
 )
 
+# Non-interactive/print modes that don't launch the Electron TUI
+NONINTERACTIVE_FLAGS=(
+  --print
+  --prompt
+  --prompt-interactive
+  -p
+  -i
+)
+
 contains() {
   local needle=$1
   shift
@@ -59,11 +69,17 @@ for arg in "$@"; do
       ;;
     --*=*)
       flag_name=${arg%%=*}
+      if contains "$flag_name" "${NONINTERACTIVE_FLAGS[@]}"; then
+        HAS_NONINTERACTIVE=true
+      fi
       if contains "$flag_name" "${VALUE_FLAGS[@]}"; then
         continue
       fi
       ;;
     -*)
+      if contains "$arg" "${NONINTERACTIVE_FLAGS[@]}"; then
+        HAS_NONINTERACTIVE=true
+      fi
       if contains "$arg" "${VALUE_FLAGS[@]}"; then
         SKIP_NEXT=true
       fi
@@ -80,12 +96,17 @@ if [[ -n "$COMMAND_TOKEN" ]] && contains "$COMMAND_TOKEN" "${SUBCOMMANDS[@]}"; t
   IS_SUBCOMMAND=true
 fi
 
-# Only inject --no-sandbox for interactive/non-interactive modes, not subcommands
+# For bare TUI invocations in a container/headless environment, Electron's
+# Chromium subprocess needs --no-sandbox. Pass it via ELECTRON_EXTRA_LAUNCH_ARGS
+# so it is picked up by Electron's process spawner rather than Go's flag.Parse(),
+# which rejects unknown flags. Do not inject for subcommands, utility flags,
+# explicit sandbox override, or non-interactive print/prompt modes.
 if [[ "$HAS_SANDBOX" == "false" \
   && "$HAS_NO_SANDBOX" == "false" \
   && "$HAS_UTILITY_FLAG" == "false" \
+  && "$HAS_NONINTERACTIVE" == "false" \
   && "$IS_SUBCOMMAND" == "false" ]]; then
-  ARGS=("--no-sandbox" "${ARGS[@]}")
+  export ELECTRON_EXTRA_LAUNCH_ARGS="--no-sandbox${ELECTRON_EXTRA_LAUNCH_ARGS:+ $ELECTRON_EXTRA_LAUNCH_ARGS}"
 fi
 
 # Locate the actual binary (installed as agy-bin in the same bin directory)

tests/unit/agy-wrapper.sh

@@ -11,7 +11,10 @@ install_wrapper() {
 
   cat >"$TMPDIR/agy-bin" <<'EOF'
 #!/usr/bin/env bash
-printf '<%s>\n' "$@"
+if [[ -n "${ELECTRON_EXTRA_LAUNCH_ARGS:-}" ]]; then
+  printf '<ENV:ELECTRON_EXTRA_LAUNCH_ARGS=%s>\n' "$ELECTRON_EXTRA_LAUNCH_ARGS"
+fi
+[[ $# -gt 0 ]] && printf '<%s>\n' "$@" || true
 EOF
   chmod +x "$TMPDIR/agy-bin"
 }
@@ -34,27 +37,35 @@ assert_output() {
 
 install_wrapper
 
-assert_output '<--no-sandbox>' 
-assert_output '<--no-sandbox>
-<-p>
+# Bare TUI invocation: --no-sandbox goes via ELECTRON_EXTRA_LAUNCH_ARGS, not argv
+assert_output '<ENV:ELECTRON_EXTRA_LAUNCH_ARGS=--no-sandbox>'
+
+# Non-interactive flags (-p, --prompt, -i, --prompt-interactive) do not trigger injection
+assert_output '<-p>
 <install>' -p install
-assert_output '<--no-sandbox>
-<--prompt=install>' --prompt=install
-assert_output '<--no-sandbox>
-<--model>
+assert_output '<--prompt=install>' --prompt=install
+assert_output '<--model>
 <install>
 <-p>
 <help>' --model install -p help
+
+# Subcommands: no injection
 assert_output '<install>' install
 assert_output '<models>' models
 assert_output '<plugin>
 <install>' plugin install
+
+# Explicit --sandbox: suppresses env var injection
 assert_output '<--sandbox>
 <-p>
 <install>' --sandbox -p install
+
+# Explicit --no-sandbox: suppresses env var injection (user passed it themselves)
 assert_output '<--no-sandbox>
 <-p>
 <install>' --no-sandbox -p install
+
+# Utility flags: no injection
 assert_output '<--version>' --version
 assert_output '<--help>' --help