Skip to content

Commit 61ea055

Browse files
authored
Merge pull request #2692 from britneywwc/fix-virtualization-solutions
fix: tab overlaps and use vanilla classes
2 parents 867e766 + b15be70 commit 61ea055

5 files changed

Lines changed: 61 additions & 62 deletions

File tree

templates/solutions/infrastructure/virtualization-solutions/index.html

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,7 @@ <h2>Canonical's open source virtualization software</h2>
224224
</div>
225225
</div>
226226
</div>
227-
<div class="virtualization-tabs" data-tablist="virtualization-software">
227+
<div data-tablist="virtualization-software">
228228
{% include "solutions/infrastructure/virtualization-solutions/tabs/lxd.html" %}
229229
{% include "solutions/infrastructure/virtualization-solutions/tabs/multipass.html" %}
230230
{% include "solutions/infrastructure/virtualization-solutions/tabs/microcloud.html" %}
@@ -233,15 +233,6 @@ <h2>Canonical's open source virtualization software</h2>
233233
</div>
234234
</div>
235235
</div>
236-
<style nonce="{{ csp_nonce }}">
237-
.tabs-cta {
238-
padding-bottom: 2rem;
239-
}
240-
241-
.virtualization-tabs {
242-
height: 250px;
243-
}
244-
</style>
245236
</section>
246237

247238
<section class="p-section">

templates/solutions/infrastructure/virtualization-solutions/tabs/lxd.html

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,24 @@
22
tabindex="0"
33
role="tabpanel"
44
id="lxd-tab"
5-
aria-labelledby="lxd-tab"
5+
aria-labelledby="lxd"
66
aria-hidden="true"
77
>
8-
<div class="row">
9-
<div class="col">
10-
{{ image(url="https://assets.ubuntu.com/v1/22c7cc8b-lxd_logo.png",
11-
alt="LXD",
12-
width="320",
13-
height="520",
14-
hi_def=True,
15-
loading="auto|lazy",
16-
attrs={"class": "p-image-container__image", "style": "height: 5.5rem; width:auto;"}) | safe
17-
}}
8+
<div class="grid-row">
9+
<div class="grid-col">
10+
<div class="p-image-container--16-9">
11+
{{ image(url="https://assets.ubuntu.com/v1/22c7cc8b-lxd_logo.png",
12+
alt="LXD",
13+
width="320",
14+
height="520",
15+
hi_def=True,
16+
loading="auto",
17+
attrs={"class": "p-image-container__image"}) | safe
18+
}}
19+
</div>
1820
<p>LXD is Canonical's comprehensive open source virtualization platform. It operates through a user-friendly web interface, helping you to manage KVM-based VMs and LXC-based system containers with ease.</p>
19-
<div class="tabs-cta">
20-
<a href="https://canonical.com/lxd" target="_blank" rel="noopener noreferrer">Learn more about LXD&nbsp;&rsaquo;</a>
21+
<div class="p-cta-block">
22+
<a href="/lxd" target="_blank" rel="noopener noreferrer">Learn more about LXD&nbsp;&rsaquo;</a>
2123
</div>
2224
</div>
2325
</div>

templates/solutions/infrastructure/virtualization-solutions/tabs/microcloud.html

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,24 @@
22
tabindex="2"
33
role="tabpanel"
44
id="microcloud-tab"
5-
aria-labelledby="microcloud-tab"
5+
aria-labelledby="microcloud"
66
aria-hidden="true"
77
>
8-
<div class="row">
9-
<div class="col">
10-
{{ image(url="https://assets.ubuntu.com/v1/6660b4dc-microcloud_logo.png",
11-
alt="MicroCloud",
12-
width="655",
13-
height="520",
14-
hi_def=True,
15-
loading="auto|lazy",
16-
attrs={"class": "p-image-container__image", "style": "height: 5.5rem; width:auto;"}) | safe
17-
}}
8+
<div class="grid-row">
9+
<div class="grid-col">
10+
<div class="p-image-container--16-9">
11+
{{ image(url="https://assets.ubuntu.com/v1/6660b4dc-microcloud_logo.png",
12+
alt="MicroCloud",
13+
width="655",
14+
height="520",
15+
hi_def=True,
16+
loading="lazy",
17+
attrs={"class": "p-image-container__image"}) | safe
18+
}}
19+
</div>
1820
<p>MicroCloud is Canonical's low entry barrier, open source cloud platform. You can build a MicroCloud in minutes, and manage its operations easily &ndash; no more navigating cloud complexity.</p>
19-
<div class="tabs-cta">
20-
<a href="https://canonical.com/microcloud" target="_blank" rel="noopener noreferrer">Learn more about MicroCloud&nbsp;&rsaquo;</a>
21+
<div class="p-cta-block">
22+
<a href="/microcloud" target="_blank" rel="noopener noreferrer">Learn more about MicroCloud&nbsp;&rsaquo;</a>
2123
</div>
2224
</div>
2325
</div>

templates/solutions/infrastructure/virtualization-solutions/tabs/multipass.html

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,24 @@
22
tabindex="1"
33
role="tabpanel"
44
id="multipass-tab"
5-
aria-labelledby="multipass-tab"
5+
aria-labelledby="multipass"
66
aria-hidden="true"
77
>
8-
<div class="row">
9-
<div class="col">
10-
{{ image(url="https://assets.ubuntu.com/v1/f939b404-multipass_logo.png",
11-
alt="Multipass",
12-
width="570",
13-
height="520",
14-
hi_def=True,
15-
loading="auto|lazy",
16-
attrs={"class": "p-image-container__image", "style": "height: 5.5rem; width:auto;"}) | safe
17-
}}
8+
<div class="grid-row">
9+
<div class="grid-col">
10+
<div class="p-image-container--16-9">
11+
{{ image(url="https://assets.ubuntu.com/v1/f939b404-multipass_logo.png",
12+
alt="Multipass",
13+
width="570",
14+
height="520",
15+
hi_def=True,
16+
loading="lazy",
17+
attrs={"class": "p-image-container__image"}) | safe
18+
}}
19+
</div>
1820
<p>Multipass is a tool to generate cloud-style Ubuntu VMs quickly on Linux, macOS and Windows. It provides a simple but powerful CLI that enables you to quickly access an Ubuntu command line or create your own local mini-cloud.</p>
19-
<div class="tabs-cta">
20-
<a href="https://canonical.com/multipass" target="_blank" rel="noopener noreferrer">Learn more about Multipass&nbsp;&rsaquo;</a>
21+
<div class="p-cta-block">
22+
<a href="/multipass" target="_blank" rel="noopener noreferrer">Learn more about Multipass&nbsp;&rsaquo;</a>
2123
</div>
2224
</div>
2325
</div>

templates/solutions/infrastructure/virtualization-solutions/tabs/openstack.html

Lines changed: 15 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -2,22 +2,24 @@
22
tabindex="3"
33
role="tabpanel"
44
id="openstack-tab"
5-
aria-labelledby="openstack-tab"
5+
aria-labelledby="openstack"
66
aria-hidden="true"
77
>
8-
<div class="row">
9-
<div class="col">
10-
{{ image(url="https://assets.ubuntu.com/v1/6ff3d48b-openstack_logo.png",
11-
alt="OpenStack",
12-
width="640",
13-
height="520",
14-
hi_def=True,
15-
loading="auto|lazy",
16-
attrs={"class": "p-image-container__image", "style": "height: 5.5rem; width:auto;"}) | safe
17-
}}
8+
<div class="grid-row">
9+
<div class="grid-col">
10+
<div class="p-image-container--16-9">
11+
{{ image(url="https://assets.ubuntu.com/v1/6ff3d48b-openstack_logo.png",
12+
alt="OpenStack",
13+
width="640",
14+
height="520",
15+
hi_def=True,
16+
loading="lazy",
17+
attrs={"class": "p-image-container__image"}) | safe
18+
}}
19+
</div>
1820
<p>Canonical OpenStack is our highly customizable cloud platform. With Canonical OpenStack based on Sunbeam, getting to grips with Canonical OpenStack will be significantly easier &ndash; helping you to operate and scale your OpenStack control plane with kubernetes.</p>
19-
<div class="tabs-cta">
20-
<a href="https://canonical.com/openstack" target="_blank" rel="noopener noreferrer">Learn more about OpenStack&nbsp;&rsaquo;</a>
21+
<div class="p-cta-block">
22+
<a href="/openstack" target="_blank" rel="noopener noreferrer">Learn more about OpenStack&nbsp;&rsaquo;</a>
2123
</div>
2224
</div>
2325
</div>

0 commit comments

Comments
 (0)