Merge pull request #2831 from britneywwc/discourse-cache

refactor: reuse single discourse cache across API instances

Author: britneywwc

webapp/app.py

@@ -93,6 +93,7 @@
     search_all_docs,
 )
 from webapp import ubuntu_pro_description as _upsd
+from webapp.utils.constants import CACHE_TTL
 
 logger = logging.getLogger(__name__)
 
@@ -146,6 +147,7 @@
 app.jinja_loader = loader
 search_session = get_requests_session()
 discourse_session = get_requests_session()
+ubuntu_discourse_cache = ResponseCache(ttl=CACHE_TTL)
 
 app.register_blueprint(application_bp, url_prefix="/careers/application")
 
@@ -298,9 +300,6 @@ def search_docs():
     )
 
 
-CACHE_TTL = 60 * 60  # 1 hour cache
-
-
 @app.route("/juju/latest.json")
 @cross_origin()
 @cached(cache=TTLCache(maxsize=128, ttl=CACHE_TTL))
@@ -1135,7 +1134,7 @@ def allow_src(tag, name, value):
         api=DiscourseAPI(
             base_url="https://discourse.dqlite.io/",
             session=discourse_session,
-            cache=ResponseCache(ttl=600),
+            cache=None,
         ),
         index_topic_id=34,
         url_prefix="/dqlite/docs",
@@ -1169,7 +1168,7 @@ def allow_src(tag, name, value):
             base_url="https://discourse.maas.io/",
             session=discourse_session,
             get_topics_query_id=2,
-            cache=ResponseCache(ttl=600),
+            cache=ubuntu_discourse_cache,
         ),
         index_topic_id=6662,
         url_prefix=maas_url_prefix,
@@ -1254,7 +1253,7 @@ def maas_docs_api():
             api_key=MAAS_DISCOURSE_API_KEY,
             api_username=MAAS_DISCOURSE_API_USERNAME,
             get_topics_query_id=2,
-            cache=ResponseCache(ttl=600),
+            cache=ubuntu_discourse_cache,
         ),
         index_topic_id=1289,
         url_prefix="/maas/tutorials",
@@ -1518,7 +1517,7 @@ def cred_exam_content(**_):
     get_topics_query_id=14,
     api_key=DISCOURSE_API_KEY,
     api_username=DISCOURSE_API_USERNAME,
-    cache=ResponseCache(ttl=600),
+    cache=ubuntu_discourse_cache,
 )
 engage_pages = EngagePages(
     api=engage_pages_discourse_api,
@@ -1548,7 +1547,7 @@ def cred_exam_content(**_):
     session=search_session,
     api_key=DISCOURSE_API_KEY,
     api_username=DISCOURSE_API_USERNAME,
-    cache=ResponseCache(ttl=600),
+    cache=ubuntu_discourse_cache,
 )
 
 
@@ -1584,7 +1583,7 @@ def cred_exam_content(**_):
         api=DiscourseAPI(
             base_url="https://discuss.kubernetes.io/",
             session=get_requests_session(),
-            cache=ResponseCache(ttl=600),
+            cache=None,
         ),
         index_topic_id=11243,
         url_prefix=microk8s_url_prefix,

webapp/utils/constants.py

@@ -5,3 +5,6 @@
 # and this is undesired. We are tracking the req ID here so that
 # it can be hidden on the Candidate Dash.
 SECOND_LOOK_REQ_ID = 3013911
+
+# Default time-to-live for ResponseCache instances, in seconds (1 hour)
+CACHE_TTL = 60 * 60