Skip to content

Commit b7169ca

Browse files
committed
fix(lightbox): event run action not passing the theme attribute
1 parent c67ea04 commit b7169ca

3 files changed

Lines changed: 9 additions & 6 deletions

File tree

packages/web-components/src/components/cta/video-cta-composite.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ class C4DVideoCTAComposite extends ModalRenderMixin(
145145
}
146146
if (theme) {
147147
const lightboxVideoPlayer = (
148-
this.modalRenderRoot as Element
148+
this.modalRenderRoot?.parentElement as Element
149149
).querySelector(selectorVideoPlayer) as Element;
150150
lightboxVideoPlayer.setAttribute('theme', theme);
151151
}

packages/web-components/src/components/lightbox-media-viewer/lightbox-video-player-composite.ts

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -94,11 +94,12 @@ class C4DLightboxVideoPlayerComposite extends ModalRenderMixin(
9494

9595
// Return CTA element to original container
9696
if (this.ctaElement) {
97-
const container = document.querySelector(
98-
`c4d-video-player-container-v7[video-id="${videoId}"]`
99-
) as any;
100-
if (container && typeof container._returnCTA === 'function') {
101-
container._returnCTA();
97+
const container = (this as Element).parentElement
98+
?.parentElement as Element;
99+
if (container) {
100+
container.querySelectorAll('[slot="cta"]').forEach((cta) => {
101+
cta.remove();
102+
});
102103
}
103104
this.ctaElement = null;
104105
}

packages/web-components/src/components/video-player-v7/video-player-container.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ import StableSelectorMixin from '../../globals/mixins/stable-selector';
3030
import C4DVideoPlayerComposite from './video-player-composite';
3131
import { carbonElement as customElement } from '@carbon/web-components/es/globals/decorators/carbon-element.js';
3232
import { LocaleAPI } from '@carbon/ibmdotcom-services/es/services/Locale/index';
33+
import { deburr } from 'lodash-es';
3334

3435
const { stablePrefix: c4dPrefix } = settings;
3536

@@ -165,6 +166,7 @@ export const C4DVideoPlayerContainerMixin = <
165166
*/
166167
_returnCTA(): void {
167168
if (this.ctaElement) {
169+
debugger;
168170
this.appendChild(this.ctaElement);
169171
}
170172
}

0 commit comments

Comments
 (0)