Skip to content

Fix/8839 toc anchor mobile issue - #12305

Merged
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
bruno-amorim:fix/8839-toc-anchor-mobile-issue
Aug 22, 2025
Merged

Fix/8839 toc anchor mobile issue#12305
kodiakhq[bot] merged 3 commits into
carbon-design-system:mainfrom
bruno-amorim:fix/8839-toc-anchor-mobile-issue

Conversation

@bruno-amorim

Copy link
Copy Markdown
Contributor

Related Ticket(s)

Closes https://jsw.ibm.com/browse/ADCMS-8839

Description

In mobile, the ToC was not working properly. Specifically the Next Steps band.

The Next Steps band has a different HTML structure and the ToC was not accounting for it, resulting in the "next steps" button when clicked, to scroll to the top of the page instead of the actual Next Steps band

As for now, this is reproducible in any live page:
https://www.ibm.com/products/cloud-pak-for-data/resources

Changelog

Slightly changed the way we calculate the scroll position, to account for any HTML structure.

toc-issue.mov

@bruno-amorim
bruno-amorim requested a review from a team as a code owner August 21, 2025 21:42
@bruno-amorim
bruno-amorim requested review from Valentin-Sorin-Nicolae and marcelojcs and removed request for a team August 21, 2025 21:42
@netlify

netlify Bot commented Aug 21, 2025

Copy link
Copy Markdown

Deploy Preview for incomparable-wisp-8d6771 ready!

Name Link
🔨 Latest commit 2b8fa26
🔍 Latest deploy log https://app.netlify.com/projects/incomparable-wisp-8d6771/deploys/68a792b959daeb0007e3d55d
😎 Deploy Preview https://deploy-preview-12305--incomparable-wisp-8d6771.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 21, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 2b8fa26
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components-react-wrap/deploys/68a792b9d79c6c0008d57336
😎 Deploy Preview https://deploy-preview-12305--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify

netlify Bot commented Aug 21, 2025

Copy link
Copy Markdown

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 2b8fa26
🔍 Latest deploy log https://app.netlify.com/projects/ibm-dotcom-web-components/deploys/68a792b93a46400008412aa7
😎 Deploy Preview https://deploy-preview-12305--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@marcelojcs marcelojcs added the Ready to merge Label for the pull requests that are ready to merge label Aug 22, 2025
@kodiakhq
kodiakhq Bot merged commit 4fe0a9f into carbon-design-system:main Aug 22, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Ready to merge Label for the pull requests that are ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants