feat: add onBackgroundRefreshFailed hook to AbstractUseStaleRequest

annaadamchuk · claude · annaadamchuk · commit 96eef38d145d · 2026-04-17T14:51:56.000-04:00
Replaces the silent catch block in the background refresh closure with a
no-op hook method. Consumers can override onBackgroundRefreshFailed() to
add logging or metrics without the library forcing a specific behaviour.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/app/AbstractUseStaleRequest.php b/app/AbstractUseStaleRequest.php
@@ -33,8 +33,8 @@ protected function responseFromCache(): ?Response
                         ->setReadCache(false)
                         ->setWriteCache(true)
                         ->sync();
-                } catch (\Throwable) {
-                    // Nobody cares, this is literally what use-stale is good at
+                } catch (\Throwable $e) {
+                    $reRequest->onBackgroundRefreshFailed($e);
                 }
             });
         }
@@ -78,6 +78,8 @@ public function purgeCache(): self
         return parent::purgeCache();
     }
 
+    protected function onBackgroundRefreshFailed(\Throwable $e): void {}
+
     // Children of this class are *required* to thoughtfully implement their own PHP 8.1+ style serialization,
     // to work with `dispatch` in `responseFromCache`
     // https://php.watch/versions/8.1/serializable-deprecated

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,8 @@ protected function responseFromCache(): ?Response`
`33`	`33`	`->setReadCache(false)`
`34`	`34`	`->setWriteCache(true)`
`35`	`35`	`->sync();`
`36`		`- } catch (\Throwable) {`
`37`		`- // Nobody cares, this is literally what use-stale is good at`
	`36`	`+ } catch (\Throwable $e) {`
	`37`	`+ $reRequest->onBackgroundRefreshFailed($e);`
`38`	`38`	`}`
`39`	`39`	`});`
`40`	`40`	`}`
`@@ -78,6 +78,8 @@ public function purgeCache(): self`
`78`	`78`	`return parent::purgeCache();`
`79`	`79`	`}`
`80`	`80`
	`81`	`+ protected function onBackgroundRefreshFailed(\Throwable $e): void {}`
	`82`	`+`
`81`	`83`	`// Children of this class are required to thoughtfully implement their own PHP 8.1+ style serialization,`
`82`	`84`	// to work with `dispatch` in `responseFromCache`
`83`	`85`	`// https://php.watch/versions/8.1/serializable-deprecated`