feat: clippy check in build

Author: thesimplekid

.github/workflows/ci.yml

@@ -90,7 +90,7 @@ jobs:
     name: "Quick Check (workspace clippy)"
     runs-on: self-hosted
     timeout-minutes: 30
-    needs: pre-commit-checks
+    needs: warm-nix-cache
     steps:
       - name: checkout
         uses: actions/checkout@v5
@@ -101,7 +101,7 @@ jobs:
           useDaemon: false
         continue-on-error: true
       - name: Run workspace clippy
-        run: nix develop -i -L .#stable --command cargo clippy --workspace --all-targets -- -D warnings
+        run: nix build -L .#checks.x86_64-linux.workspace-clippy-all-targets
 
   # Discover CI check groups from flake - single source of truth
   discover_ci_groups:
@@ -120,7 +120,7 @@ jobs:
         id: groups
         run: |
           examples=$(nix eval .#checks.x86_64-linux --apply 'attrs: builtins.filter (n: builtins.substring 0 8 n == "example-") (builtins.attrNames attrs)' --json)
-          checks=$(nix eval .#checks.x86_64-linux --apply 'attrs: builtins.filter (n: n != "pre-commit-check" && n != "doc-tests" && n != "strict-docs" && n != "ffi-tests" && builtins.substring 0 8 n != "example-" && builtins.substring 0 5 n != "msrv-" && builtins.substring 0 5 n != "wasm-") (builtins.attrNames attrs)' --json)
+          checks=$(nix eval .#checks.x86_64-linux --apply 'attrs: builtins.filter (n: n != "pre-commit-check" && n != "workspace-clippy-all-targets" && n != "doc-tests" && n != "strict-docs" && n != "ffi-tests" && builtins.substring 0 8 n != "example-" && builtins.substring 0 5 n != "msrv-" && builtins.substring 0 5 n != "wasm-") (builtins.attrNames attrs)' --json)
           msrv_checks=$(nix eval .#checks.x86_64-linux --apply 'attrs: builtins.filter (n: builtins.substring 0 5 n == "msrv-") (builtins.attrNames attrs)' --json)
           wasm_checks=$(nix eval .#checks.x86_64-linux --apply 'attrs: builtins.filter (n: builtins.substring 0 5 n == "wasm-") (builtins.attrNames attrs)' --json)
           {

.gitignore

@@ -13,6 +13,7 @@ build
 config.toml
 .pre-commit-config.yaml
 result
+result-*
 static-bin/
 .aider*
 **/postgres_data/

flake.nix

@@ -218,6 +218,7 @@
               ./Cargo.toml
               ./Cargo.lock
               ./Cargo.lock.msrv
+              ./clippy.toml
               ./.typos.toml
               ./rustfmt.toml
               ./README.md
@@ -238,6 +239,7 @@
             lib.fileset.unions [
               ./Cargo.toml
               ./Cargo.lock.msrv
+              ./clippy.toml
               ./.typos.toml
               ./rustfmt.toml
               ./README.md
@@ -493,6 +495,19 @@
           }
         );
 
+        # Workspace-wide clippy check for all targets. This preserves the quick
+        # check coverage while reusing the warmed Crane dependency derivation.
+        workspaceClippyAllTargets = craneLib.mkCargoDerivation (
+          commonCraneArgs
+          // {
+            pname = "cdk-workspace-clippy-all-targets";
+            cargoArtifacts = workspaceDeps;
+            buildPhaseCargoCommand = "cargo clippy --workspace --all-targets -- -D warnings";
+            doCheck = false;
+            installPhaseCommand = "mkdir -p $out";
+          }
+        );
+
         # Strict docs check - build docs with warnings as errors
         # Uses mkCargoDerivation for custom RUSTDOCFLAGS
         strictDocs = craneLib.mkCargoDerivation (
@@ -844,6 +859,8 @@
             git
             pkg-config
             curl
+            cachix
+            jq
             just
             protobuf
             nixpkgs-fmt
@@ -1303,6 +1320,9 @@
               exampleChecks
           ))
           // {
+            # Workspace-wide all-targets clippy check
+            workspace-clippy-all-targets = workspaceClippyAllTargets;
+
             # Doc tests
             doc-tests = docTests;
 

justfile

@@ -58,6 +58,41 @@ build-static-all: (build-static "cdk-mintd-static") (build-static "cdk-mintd-ldk
   echo "Checksums:"
   cat SHA256SUMS
 
+# Build the CI cache warmup targets locally.
+ci-cache-build:
+  #!/usr/bin/env bash
+  set -euo pipefail
+  cd "{{justfile_directory()}}"
+  nix build -L --no-link \
+    'path:.#deps' \
+    'path:.#deps-msrv' \
+    'path:.#checks.x86_64-linux.workspace-clippy-all-targets' \
+    'path:.#dart-bindings' \
+    'path:.#kotlin-bindings' \
+    'path:.#go-bindings'
+
+# Push the locally built CI cache warmup targets to Cachix.
+ci-cache-push:
+  #!/usr/bin/env bash
+  set -euo pipefail
+  cd "{{justfile_directory()}}"
+  nix build --json --no-link \
+    'path:.#deps' \
+    'path:.#deps-msrv' \
+    'path:.#checks.x86_64-linux.workspace-clippy-all-targets' \
+    'path:.#dart-bindings' \
+    'path:.#kotlin-bindings' \
+    'path:.#go-bindings' \
+    | jq -r '.[].outputs | to_entries[].value' \
+    | cachix push cashudevkit
+
+# Build and push CI cache warmup targets as they complete.
+ci-cache-watch:
+  #!/usr/bin/env bash
+  set -euo pipefail
+  cd "{{justfile_directory()}}"
+  cachix watch-exec cashudevkit -- just ci-cache-build
+
 # run `cargo check` on everything
 check *ARGS="--workspace --all-targets":
   #!/usr/bin/env bash