Commit 3b88bcb
committed
別名分頁補上出處/頁碼/備註欄
PersonBrowserService::tabAltNames() 原本就把 c_source/c_pages/c_notes 撈出來
送到前端,AltNamesTab 卻只渲染 序號/別名(拼音)/別名(中)/類型 四欄,等於是
送到前端就被丟掉的死負載。這三個欄位都在 AltnameMutationHandler 的 allowedFields
裡、可經提案修改,列表看不到會讓使用者誤以為沒存進去。
- tabAltNames() leftJoin TEXT_CODES 補出處書名(source_title_chn/source_title),
與 AltnameEditor 的 c_source label 同源;c_source 的哨兵 0 在 TEXT_CODES 沒有
對應列,leftJoin 自然落空、不需另外過濾
- AltNamesTab 加三欄;出處優先顯示書名(中/英)、查不到退回 #id,備註限寬 360px
並保留換行(SubresourceTable 外層已有橫向捲動)。表頭沿用編輯器同一組 i18n key
(biogmains.source_field/pages_entries/notes_field),列表欄名與編輯器欄位標籤一致
已執行 ./vendor/bin/phpunit(2994 tests 全綠)與 npm run build1 parent 9939c7d commit 3b88bcb
3 files changed
Lines changed: 55 additions & 1 deletion
File tree
- app/Services
- resources/js/inertia/components/PersonBrowser/tabs
- tests/Feature
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
649 | 649 | | |
650 | 650 | | |
651 | 651 | | |
| 652 | + | |
| 653 | + | |
| 654 | + | |
| 655 | + | |
652 | 656 | | |
653 | 657 | | |
| 658 | + | |
654 | 659 | | |
655 | 660 | | |
656 | 661 | | |
| |||
670 | 675 | | |
671 | 676 | | |
672 | 677 | | |
| 678 | + | |
| 679 | + | |
673 | 680 | | |
674 | 681 | | |
675 | 682 | | |
| |||
Lines changed: 24 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
14 | 14 | | |
15 | 15 | | |
16 | 16 | | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
17 | 27 | | |
18 | 28 | | |
19 | 29 | | |
| |||
27 | 37 | | |
28 | 38 | | |
29 | 39 | | |
| 40 | + | |
| 41 | + | |
30 | 42 | | |
31 | 43 | | |
32 | 44 | | |
| |||
131 | 143 | | |
132 | 144 | | |
133 | 145 | | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
134 | 151 | | |
135 | 152 | | |
136 | 153 | | |
| |||
165 | 182 | | |
166 | 183 | | |
167 | 184 | | |
| 185 | + | |
| 186 | + | |
| 187 | + | |
| 188 | + | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
168 | 192 | | |
169 | 193 | | |
170 | 194 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
654 | 654 | | |
655 | 655 | | |
656 | 656 | | |
657 | | - | |
| 657 | + | |
| 658 | + | |
658 | 659 | | |
659 | 660 | | |
660 | 661 | | |
| |||
1151 | 1152 | | |
1152 | 1153 | | |
1153 | 1154 | | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
| 1163 | + | |
| 1164 | + | |
| 1165 | + | |
| 1166 | + | |
| 1167 | + | |
| 1168 | + | |
| 1169 | + | |
| 1170 | + | |
| 1171 | + | |
| 1172 | + | |
| 1173 | + | |
| 1174 | + | |
| 1175 | + | |
| 1176 | + | |
1154 | 1177 | | |
1155 | 1178 | | |
1156 | 1179 | | |
| |||
0 commit comments