PR #16125 #3778
sahusanketcodeql
on: dynamic
Matrix: analyze
Annotations
6 errors and 29 warnings
|
AppLifecycleHttpHandlerTest.testDeployDuplicateRequestWithInvalidPolicy:
AppLifecycleHttpHandlerTest#L395
expected:<400> but was:<200>
|
|
AppLifecycleHttpHandlerTest.testDeployDuplicateRequestAlwaysDeployedOnDifferentConfig:
AppLifecycleHttpHandlerTest#L273
Argument(s) are different! Wanted:
applicationLifecycleService.deployApp(
<any io.cdap.cdap.proto.id.ApplicationId>,
<any io.cdap.cdap.proto.artifact.AppRequest>,
<any>,
<any>,
<any boolean>
);
-> at io.cdap.cdap.internal.app.services.http.handlers.AppLifecycleHttpHandlerTest.testDeployDuplicateRequestAlwaysDeployedOnDifferentConfig(AppLifecycleHttpHandlerTest.java:273)
Actual invocations have different arguments:
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@2d64160c
);
-> at io.cdap.cdap.gateway.handlers.AppLifecycleHttpHandler.deployAppFromArtifact(AppLifecycleHttpHandler.java:772)
applicationLifecycleService.deployApp(
application:default.DiffDeployApp.-SNAPSHOT,
io.cdap.cdap.proto.artifact.AppRequest@5f254608,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@2eeb0f9b,
false,
ALWAYS_DEPLOY
);
-> at io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$1.onFinish(AbstractAppLifecycleHttpHandler.java:189)
applicationLifecycleService.deployApp(
namespace:default,
"DiffDeployApp",
"-SNAPSHOT",
USER:diffDeployArtifact-1.0.0-SNAPSHOT,
"{"tableName":"xyz","serviceResponse":"123"}",
null,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@2eeb0f9b,
null,
null,
false,
false,
{}
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1153)
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@1b1c538d
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1209)
|
|
AppLifecycleHttpHandlerTest.testDeployVersionedAndNonVersionedAppLCMFlagEnabled:
AppLifecycleHttpHandlerTest#L711
expected:<[573fc862-54f3-11f1-815a-328150bead72, 57532953-54f3-11f1-bfe0-328150bead72, 5767c2c4-54f3-11f1-ae9b-328150bead72, 577c3525-54f3-11f1-b901-328150bead72]> but was:<[573fc862-54f3-11f1-815a-328150bead72, 57532953-54f3-11f1-bfe0-328150bead72, 5767c2c4-54f3-11f1-ae9b-328150bead72, -SNAPSHOT, 577c3525-54f3-11f1-b901-328150bead72]>
|
|
AppLifecycleHttpHandlerTest.testDeployDuplicateRequestBypassed:
AppLifecycleHttpHandlerTest#L235
Argument(s) are different! Wanted:
applicationLifecycleService.deployApp(
<any io.cdap.cdap.proto.id.ApplicationId>,
<any io.cdap.cdap.proto.artifact.AppRequest>,
<any>,
<any>,
<any boolean>
);
-> at io.cdap.cdap.internal.app.services.http.handlers.AppLifecycleHttpHandlerTest.testDeployDuplicateRequestBypassed(AppLifecycleHttpHandlerTest.java:235)
Actual invocations have different arguments:
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@2d64160c
);
-> at io.cdap.cdap.gateway.handlers.AppLifecycleHttpHandler.deployAppFromArtifact(AppLifecycleHttpHandler.java:772)
applicationLifecycleService.deployApp(
application:default.DuplicateDeployApp.-SNAPSHOT,
io.cdap.cdap.proto.artifact.AppRequest@37c36608,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@5d497a91,
false,
ALWAYS_DEPLOY
);
-> at io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$1.onFinish(AbstractAppLifecycleHttpHandler.java:189)
applicationLifecycleService.deployApp(
namespace:default,
"DuplicateDeployApp",
"-SNAPSHOT",
USER:duplicateDeployArtifact-1.0.0-SNAPSHOT,
"{"tableName":"xyz","serviceResponse":"123"}",
null,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@5d497a91,
null,
null,
false,
false,
{}
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1153)
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@1b1c538d
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1209)
|
|
AppLifecycleHttpHandlerTest.testDeployDuplicateRequestWithVersionRange:
AppLifecycleHttpHandlerTest#L314
Argument(s) are different! Wanted:
applicationLifecycleService.deployApp(
<any io.cdap.cdap.proto.id.ApplicationId>,
<any io.cdap.cdap.proto.artifact.AppRequest>,
<any>,
<any>,
<any boolean>
);
-> at io.cdap.cdap.internal.app.services.http.handlers.AppLifecycleHttpHandlerTest.testDeployDuplicateRequestWithVersionRange(AppLifecycleHttpHandlerTest.java:314)
Actual invocations have different arguments:
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@2d64160c
);
-> at io.cdap.cdap.gateway.handlers.AppLifecycleHttpHandler.deployAppFromArtifact(AppLifecycleHttpHandler.java:772)
applicationLifecycleService.deployApp(
application:default.RangeDeployApp.-SNAPSHOT,
io.cdap.cdap.proto.artifact.AppRequest@58f31629,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@124d26ba,
false,
ALWAYS_DEPLOY
);
-> at io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$1.onFinish(AbstractAppLifecycleHttpHandler.java:189)
applicationLifecycleService.deployApp(
namespace:default,
"RangeDeployApp",
"-SNAPSHOT",
USER:rangeDeployArtifact-1.0.0-SNAPSHOT,
"{"tableName":"abc","serviceResponse":"789"}",
null,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@124d26ba,
null,
null,
false,
false,
{}
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1153)
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@1b1c538d
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1209)
|
|
AppLifecycleHttpHandlerTest.testDeployDuplicateRequestWithConfigFormattingDifference:
AppLifecycleHttpHandlerTest#L357
Argument(s) are different! Wanted:
applicationLifecycleService.deployApp(
<any io.cdap.cdap.proto.id.ApplicationId>,
<any io.cdap.cdap.proto.artifact.AppRequest>,
<any>,
<any>,
<any boolean>
);
-> at io.cdap.cdap.internal.app.services.http.handlers.AppLifecycleHttpHandlerTest.testDeployDuplicateRequestWithConfigFormattingDifference(AppLifecycleHttpHandlerTest.java:357)
Actual invocations have different arguments:
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@2d64160c
);
-> at io.cdap.cdap.gateway.handlers.AppLifecycleHttpHandler.deployAppFromArtifact(AppLifecycleHttpHandler.java:772)
applicationLifecycleService.deployApp(
application:default.JSONEqualDeployApp.-SNAPSHOT,
io.cdap.cdap.proto.artifact.AppRequest@687389a6,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@8641b7d,
false,
ALWAYS_DEPLOY
);
-> at io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$1.onFinish(AbstractAppLifecycleHttpHandler.java:189)
applicationLifecycleService.deployApp(
namespace:default,
"JSONEqualDeployApp",
"-SNAPSHOT",
USER:jsonEqualDeployArtifact-1.0.0-SNAPSHOT,
"{
"a": "xyz",
"b": "123"
}",
null,
null,
io.cdap.cdap.gateway.handlers.AbstractAppLifecycleHttpHandler$$Lambda$371/1099366326@8641b7d,
null,
null,
false,
false,
{}
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1153)
applicationLifecycleService.decodeUserId(
io.cdap.cdap.security.auth.context.MasterAuthenticationContext@1b1c538d
);
-> at io.cdap.cdap.internal.app.services.ApplicationLifecycleService.deployApp(ApplicationLifecycleService.java:1209)
|
|
|
|
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.javadoc.AtclauseOrderCheck:
cdap-app-fabric/src/main/java/io/cdap/cdap/gateway/handlers/AppLifecycleHttpHandler.java#L504
Javadoc comment at column 65 has parse error. Details: no viable alternative at input '</>' while parsing HTML_ELEMENT
|
|
com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L51
Wrong lexicographical order for 'io.cdap.cdap.gateway.handlers.AppDeployStrategy' import. Should be before 'io.cdap.cdap.gateway.handlers.AppLifecycleHttpHandler'.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L121
Abbreviation in name 'setLCMFlag' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L231
Distance between variable 'firstRecord' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L310
Distance between variable 'firstRecord' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L345
Distance between variable 'config2' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L353
Distance between variable 'firstRecord' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L556
Distance between variable 'request' declaration and its first usage is 4, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L639
Abbreviation in name 'testDeployVersionedAndNonVersionedAppLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L750
Abbreviation in name 'testListAndGetLCMFlagEnabledInstanceUpgradeScenario' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L846
Abbreviation in name 'testListAndGetForPaginatedAPI' must contain no more than '1' consecutive capital letters.
|
|
RightCurlySame:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L917
'}' at column 7 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L988
Abbreviation in name 'testListAndGetForPaginatedAPIWithEmptyLastPage' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1029
Abbreviation in name 'testListAndGetForPaginatedAPIWithFiltering' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1075
Abbreviation in name 'testListAndGetForPaginatedAPIWithNameFilterType' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1118
Abbreviation in name 'testListAndGetForPaginatedAPIWithLatestOnlyLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1188
Abbreviation in name 'testListAndGetLCMFlagEnabledForVersionHistory' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1334
Abbreviation in name 'testListAndGetLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1459
Distance between variable 'appReference' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1607
Abbreviation in name 'testDeleteLCMFlagEnabled' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.coding.VariableDeclarationUsageDistanceCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1622
Distance between variable 'applicationId' declaration and its first usage is 5, but allowed 3. Consider making that variable final if you still need to store its value in advance (before method calls that might have side effects on the original value).
|
|
com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1738
Abbreviation in name 'testDeleteVersionedAppLCMEnabled' must contain no more than '1' consecutive capital letters.
|
|
com.puppycrawl.tools.checkstyle.checks.naming.MemberNameCheck:
cdap-app-fabric/src/test/java/io/cdap/cdap/internal/app/services/http/handlers/AppLifecycleHttpHandlerTest.java#L1827
Member name 'x' must match pattern '^[a-z][a-zA-Z0-9]+$'.
|
|
com.puppycrawl.tools.checkstyle.checks.imports.UnusedImportsCheck:
cdap-proto/src/main/java/io/cdap/cdap/proto/artifact/AppRequest.java#L19
Unused import - com.google.gson.Gson.
|
|
|
|
com.puppycrawl.tools.checkstyle.checks.whitespace.WhitespaceAroundCheck:
cdap-proto/src/main/java/io/cdap/cdap/proto/artifact/AppRequest.java#L144
WhitespaceAround: '{' is not preceded with whitespace.
|