rbd: make Destroy nil-safe and remove redundant nil checks

Signed-off-by: Niraj Yadav <niryadav@redhat.com>

Author: black-dragon74

internal/rbd/manager.go

@@ -75,9 +75,7 @@ func (mgr *rbdManager) GetVolumeByID(ctx context.Context, id string) (types.Volu
 
 	volume, err := GenVolFromVolID(ctx, id, creds, mgr.secrets)
 	if err != nil {
-		if volume != nil {
-			volume.Destroy(ctx)
-		}
+		volume.Destroy(ctx)
 
 		switch {
 		case errors.Is(err, rbderrors.ErrImageNotFound):
@@ -100,9 +98,7 @@ func (mgr *rbdManager) GetSnapshotByID(ctx context.Context, id string) (types.Sn
 
 	snapshot, err := genSnapFromSnapID(ctx, id, creds, mgr.secrets)
 	if err != nil {
-		if snapshot != nil {
-			snapshot.Destroy(ctx)
-		}
+		snapshot.Destroy(ctx)
 
 		switch {
 		case errors.Is(err, rbderrors.ErrImageNotFound):

internal/rbd/rbd_util.go

@@ -420,6 +420,9 @@ func (ri *rbdImage) Connect(cr *util.Credentials) error {
 // Destroy cleans up the rbdVolume and closes the connection to the Ceph
 // cluster in case one was setup.
 func (ri *rbdImage) Destroy(ctx context.Context) {
+	if ri == nil {
+		return
+	}
 	if ri.ioctx != nil {
 		ri.ioctx.Destroy()
 		ri.ioctx = nil