Slim image - #6310
Conversation
|
Thanks @ismaelpuerto! The changes look good, however there are quite a few changed lines that only modify indention. Could you modify the commit, and force push a cleaner version that only contains the required changes? |
| && dnf -y reinstall https://download.ceph.com/rpm-${CEPH_VERSION}/el9/noarch/ceph-release-1-1.el9.noarch.rpm \ | ||
| && ( dnf config-manager --disable tcmu-runner,tcmu-runner-source,tcmu-runner-noarch,ceph-iscsi,ganesha || true ) \ | ||
| && true |
There was a problem hiding this comment.
Can we remove this as it was a workaround when we had ceph as a base image
There was a problem hiding this comment.
this is still needed, as the ceph-release RPM provides the correct Ceph repository
| && dnf clean all \ | ||
| && rm -rf /var/cache/yum \ | ||
| && true | ||
| librados-devel librbd-devel libcephfs-devel \ |
There was a problem hiding this comment.
what version of the these packages will be installed. I have seen sometimes the packages might not been updated in centos images we should install specific version of the packages
There was a problem hiding this comment.
They are latest version from the ceph-release repository. This looks good to me.
We could "dnf update" the CentOS base image, but those containers are updated regularly already (the ceph base containers are not).
|
Thank you for the cleanup, @ismaelpuerto ! I've rebased this PR and squashed the commits into one, hope you don't mind. |
|
/test ci/centos/mini-e2e/k8s-1.36/rbd |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
It seems the |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
Also included packages that provide the |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
3 similar comments
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
/test ci/centos/mini-e2e/k8s-1.36/cephfs |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
I think that we have all commands in the new image |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
@Mergifyio rebase |
Signed-off-by: Ismael Puerto <ipuertofreire@gmail.com>
The node-plugin already runs with high priviledges, otherwise it would not be able to use cryptsetup while attaching/mounting volumes. Signed-off-by: Niels de Vos <ndevos@ibm.com>
Signed-off-by: Ismael Puerto <ismaelpuerto@users.noreply.github.com>
|
Deprecation notice: This pull request comes from a fork and was rebased using |
✅ Branch has been successfully rebased |
|
/test ci/centos/upgrade-tests-cephfs |
|
/test ci/centos/upgrade-tests-rbd |
|
/test ci/centos/k8s-e2e-external-storage/1.35 |
|
/test ci/centos/mini-e2e-helm/k8s-1.35 |
|
/test ci/centos/mini-e2e/k8s-1.35 |
|
/test ci/centos/k8s-e2e-external-storage/1.36 |
|
/test ci/centos/k8s-e2e-external-storage/1.34 |
|
/test ci/centos/mini-e2e-helm/k8s-1.36 |
|
/test ci/centos/mini-e2e-helm/k8s-1.34 |
|
/test ci/centos/mini-e2e/k8s-1.36 |
|
/test ci/centos/mini-e2e/k8s-1.34 |
ceph-csi-bot
added
ci/in-progress/e2e
mergify
Bot
removed
the
ci/in-progress/e2e
|
/retest ci/centos/mini-e2e-helm/k8s-1.36 |
|
|
Deprecation notice: This pull request comes from a fork and was queued with |
Merge Queue Status
This pull request spent 23 seconds in the queue, including 4 seconds running CI. Required conditions to merge
|
6 participants
Describe what this PR does
Use a minimal base image (quay.io/centos/centos:stream9-minimal) for the final runtime stage of the cephcsi multi-stage Dockerfile, instead of the full Ceph daemon image (quay.io/ceph/ceph).
Is there anything that requires special attention
Do you have any questions?
Is the change backward compatible?
Are there concerns around backward compatibility?
Provide any external context for the change, if any.
For example:
Related issues
Mention any github issues relevant to this PR. Adding below line
will help to auto close the issue once the PR is merged.
Fixes: #6289
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.
Checklist:
guidelines in the developer
guide.
Request
notes
updated with breaking and/or notable changes for the next major release.
Show available bot commands
These commands are normally not required, but in case of issues, leave any of
the following bot commands in an otherwise empty comment in this PR:
/retest ci/centos/<job-name>: retest the<job-name>after unrelatedfailure (please report the failure too!)