Skip to content

rbd: Fix connection leak when a non-nil volume is returned (backport #6432) - #6440

Merged
mergify[bot] merged 2 commits into
release-v3.17from
mergify/bp/release-v3.17/pr-6432
Jul 31, 2026
Merged

rbd: Fix connection leak when a non-nil volume is returned (backport #6432)#6440
mergify[bot] merged 2 commits into
release-v3.17from
mergify/bp/release-v3.17/pr-6432

Conversation

@mergify

@mergify mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Describe what this PR does

This patch calls Destroy on the non-nil Volume/Snap object so that conn pool GC can clean it up.

Not doing this always kept ref count > 0, preventing cleanup and leading to lock contention, which in turn kicked in librbd lock breaking leading to blacklisting of actual clients.

This is an automatic backport of pull request #6432 done by [Mergify](https://mergify.com).

@black-dragon74 @mergify
rbd: Fix connection leak when a non-nil volume is returned
ac7c98e 
This patch calls `Destroy` on the non-nil Volume/Snap object
so that conn pool GC can clean it up.

Not doing this always kept ref count > 0, preventing cleanup and
leading to lock contention, which in turn kicked in librbd lock
breaking leading to blacklisting of actual clients.

Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 7ef770a)
@black-dragon74 @mergify
rbd: open image as read-only for get calls
139a6d5 
Signed-off-by: Niraj Yadav <niryadav@redhat.com>
(cherry picked from commit 6148377)
@mergify mergify Bot added ok-to-test Label to trigger E2E tests component/rbd Issues related to RBD labels Jul 30, 2026
@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.33

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.34

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/k8s-e2e-external-storage/1.35

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e-helm/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.33

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.34

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/mini-e2e/k8s-1.35

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-cephfs

@ceph-csi-bot

ceph-csi-bot commented Jul 30, 2026

Copy link
Copy Markdown
Collaborator

/test ci/centos/upgrade-tests-rbd

@ceph-csi-bot ceph-csi-bot added ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. and removed ok-to-test Label to trigger E2E tests labels Jul 30, 2026
@mergify mergify Bot removed the ci/in-progress/e2e This label acts like a guard and prevents Mergify from adding the `ok-to-test` label again. label Jul 30, 2026
@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

/retest ci/centos/mini-e2e/k8s-1.35

@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

/retest ci/centos/mini-e2e/k8s-1.34

@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

/retest ci/centos/k8s-e2e-external-storage/1.34

@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

Restarted the CI jobs, they failed to checkout the repository from GitHub.

@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

/retest ci/centos/mini-e2e/k8s-1.35

@nixpanic

nixpanic commented Jul 31, 2026

Copy link
Copy Markdown
Member

/retest ci/centos/mini-e2e/k8s-1.35

nfs Test NFS CSI [It] create a PVC-PVC clone and bind it to an app

logs

@iPraveenParihar

iPraveenParihar commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

@Mergifyio refresh

@mergify

mergify Bot commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge Queue Status

  • ✅ Entered queue — 2026-07-31 12:12 UTC · Rule: default · triggered by merge protections
  • ✅ Checks skipped · PR is already up-to-date
  • ✅ Merged — 2026-07-31 12:13 UTC · at 139a6d5010d9762293a284bd037d78aca131c84e · rebase

This pull request spent 24 seconds in the queue, including 4 seconds running CI.

Required conditions to merge

@mergify
mergify Bot merged commit d1c31f3 into release-v3.17 Jul 31, 2026
47 of 49 checks passed
@mergify

mergify Bot commented Jul 31, 2026

Copy link
Copy Markdown
Contributor Author

refresh

✅ Pull request refreshed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nixpanic nixpanic nixpanic approved these changes
@Madhu-1 Madhu-1 Madhu-1 approved these changes

Assignees

No one assigned

Labels

component/rbd Issues related to RBD

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ceph-csi-bot @nixpanic @iPraveenParihar @Madhu-1 @black-dragon74