Make jQuery a peer dependency and require it.#109
Open
jacksonrayhamilton wants to merge 2 commits intochaijs:masterfrom
Open
Make jQuery a peer dependency and require it.#109jacksonrayhamilton wants to merge 2 commits intochaijs:masterfrom
jacksonrayhamilton wants to merge 2 commits intochaijs:masterfrom
Conversation
|
hi all! Nearly a year passed, can somebody please either approve or close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40. In CommonJS environments, jQuery would still need to be a global variable, which made using this library more difficult. Also, adding it as a "*" peer dependency causes NPM to warn that it needs to be installed, without restricting the user to a particular jQuery version.
I acknowledge that some people still might want to specify their own jQuery object, but I am choosing to treat that as a separate feature request. This change can be considered a "minor correction" independent of other loading enhancements, since it aligns with the way jQuery is currently loaded in AMD environments. In reaching that parallel, jQuery will be loaded in each of the supported environments' most common manners, respectively.