Commit e522bdd
authored
fix(ci): add persist-credentials: false and zizmor pedantic config (#69)
## Summary
This patch series addresses GitHub Actions security findings in
`chainguard-dev/clog`
as part of the PSEC-923 hardening campaign.
## Patches
### 0001 — `fix(ci): add persist-credentials: false to checkout steps`
Adds `persist-credentials: false` to the `actions/checkout` step in:
- `.github/workflows/go.yml` — build/test job; no downstream git write
operations
The `zizmor.yaml` and `actionlint.yaml` workflows already had
`persist-credentials: false`
on their checkout steps. This patch completes coverage for the remaining
workflow.
Resolves: 1 `artipacked` finding (zizmor)
### 0002 — `fix(ci): add pedantic persona and suppress noisy zizmor
rules`
- Creates `.github/zizmor.yml` disabling three pedantic-only rules that
have no direct
security value (`anonymous-definition`, `concurrency-limits`) and
configuring
`dependabot-cooldown` to use a 3-day threshold.
- Updates `.github/workflows/zizmor.yaml` to run zizmor with `persona:
pedantic` so
that all template expansions in `run:` blocks are checked, not just
attacker-controlled ones.
- Extends the `paths:` trigger in `zizmor.yaml` to include
`.github/zizmor.yml` and
`.github/dependabot.yml`, so that changes to those files trigger the
zizmor check.
Resolves: 3 `concurrency-limits` findings, 1 `anonymous-definition`
finding,
2 `dependabot-cooldown` findings (all suppressed via config)
## Testing
- Validate that the zizmor workflow runs on PRs touching
`.github/zizmor.yml` and
`.github/dependabot.yml`.
- Confirm zizmor passes in pedantic mode with the new
`.github/zizmor.yml` suppression
config in place.
Refs: PSEC-9231 parent a29ba66 commit e522bdd
3 files changed
Lines changed: 16 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| 27 | + | |
| 28 | + | |
27 | 29 | | |
28 | 30 | | |
29 | 31 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
12 | 14 | | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
16 | 18 | | |
| 19 | + | |
| 20 | + | |
17 | 21 | | |
18 | 22 | | |
19 | 23 | | |
| |||
42 | 46 | | |
43 | 47 | | |
44 | 48 | | |
| 49 | + | |
| 50 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
0 commit comments