Skip to content

Commit 6e76f80

Browse files
authored
Replace ChOp skipif with a fail-fast precomp (#28954)
Replace the ChOp testing skipif with a precomp that exits with error if cloning or patching fails, rather than just skipping the test. I think this is appropriate because we shouldn't have very frequent failures now that we have cached reference repos to clone with, so we can lean towards not silencing an issue. All differences between new precomp and old skipif: - Uses reference repo at standard path for cloning if available. - Exits with error on failed commands (`set -e`), rather than skipping test. - Output is direct to stdout and stderr rather than redirecting to a log file. - Increased verbosity with `set -x`. [reviewed by @benharsh , thanks!] Testing: - [x] ChOp tests in `./util/cron/test-gpu-ex-cuda-12.ofi.bash` config pass
2 parents 34473b5 + d9b84d7 commit 6e76f80

2 files changed

Lines changed: 17 additions & 28 deletions

File tree

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
#!/usr/bin/env bash
2+
3+
set -ex
4+
5+
CWD=$(cd $(dirname ${BASH_SOURCE[0]}) ; pwd)
6+
CHOP_BRANCH=main
7+
CHOP_URL=${CHOP_URL:-https://github.com/tcarneirop/ChOp.git}
8+
CHOP_BRANCH=${CHOP_BRANCH:-main}
9+
10+
# Clone ChOp
11+
rm -rf ChOp
12+
git clone ${CHOP_URL} --reference-if-able "${REPO_CACHE_PATH:-/missing}/chapel.git" --branch=${CHOP_BRANCH} --depth=1
13+
14+
# Apply patches, if any
15+
for p in $(find patches -name "*patch"); do
16+
git -C ChOp apply ../$p;
17+
done

test/gpu/native/studies/chop/queens_GPU_CPU_single_node.skipif

Lines changed: 0 additions & 28 deletions
This file was deleted.

0 commit comments

Comments
 (0)