Commit 6e76f80
authored
Replace ChOp skipif with a fail-fast precomp (#28954)
Replace the ChOp testing skipif with a precomp that exits with error if
cloning or patching fails, rather than just skipping the test.
I think this is appropriate because we shouldn't have very frequent
failures now that we have cached reference repos to clone with, so we
can lean towards not silencing an issue.
All differences between new precomp and old skipif:
- Uses reference repo at standard path for cloning if available.
- Exits with error on failed commands (`set -e`), rather than skipping
test.
- Output is direct to stdout and stderr rather than redirecting to a log
file.
- Increased verbosity with `set -x`.
[reviewed by @benharsh , thanks!]
Testing:
- [x] ChOp tests in `./util/cron/test-gpu-ex-cuda-12.ofi.bash` config
pass2 files changed
Lines changed: 17 additions & 28 deletions
File tree
- test/gpu/native/studies/chop
Lines changed: 17 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
Lines changed: 0 additions & 28 deletions
This file was deleted.
0 commit comments