Skip to content
This repository was archived by the owner on Nov 11, 2023. It is now read-only.
This repository was archived by the owner on Nov 11, 2023. It is now read-only.

Cover parsing fails since Nokogiri 1.6.4 #17

Description

@fgi

Nokogiri 1.6.4 / 2014-11-04 release announcement mentions this fix:

  • Fix a bug with CSS attribute selector without any prefix where "foo [bar]" was treated as "foo[bar]". (#1174)

Since this fix, cover parsing fails in /models/cover.rb.
Spaces should be removed in CSS attribute selectors in epub_cover_item method (lines 78 and 82 to 85).
Ex:
manifest.css("item [id = \"#{cover_id}\"]")
should become
manifest.css("item[id = \"#{cover_id}\"]")

I did not see any other impact of this Nokogiri fix in epubinfo.
Thanks.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions