Skip to content

Commit 698b76f

Browse files
committed
fix(layout): adjust sticky positioning and overflow behavior in About and Settings pages
1 parent 8ec5a64 commit 698b76f

3 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/App.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,7 @@ function App() {
214214
<ErrorBoundary>
215215
<FENBatchProvider>
216216
<ModalProvider openAuthModal={openAuthModal}>
217-
<div className="isolate-root shell-safe-area min-h-dvh lg:h-screen lg:overflow-hidden flex flex-col bg-linear-to-br from-bg-gradient-start to-bg-gradient-end text-fluid-base transition-colors duration-700 ease-[cubic-bezier(0.22,1,0.36,1)]">
217+
<div className="isolate-root shell-safe-area min-h-dvh md:h-screen md:overflow-hidden lg:h-screen lg:overflow-hidden flex flex-col bg-linear-to-br from-bg-gradient-start to-bg-gradient-end text-fluid-base transition-colors duration-700 ease-[cubic-bezier(0.22,1,0.36,1)]">
218218
<a
219219
href="#main-content"
220220
className="sr-only focus-visible:not-sr-only focus-visible:absolute focus-visible:top-4 focus-visible:left-4 focus-visible:z-100 focus-visible:px-6 focus-visible:py-3 focus-visible:bg-accent focus-visible:text-bg focus-visible:rounded-xl focus-visible:shadow-lg focus-visible:font-semibold"

src/pages/AboutPage/AboutPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ const AboutPage = memo(function AboutPage() {
117117
navbar. */}
118118
<div className="page-container flex flex-col gap-6 py-6 sm:py-10 md:h-full md:min-h-0 md:flex-row md:gap-8 lg:gap-10">
119119
<div className="shrink-0 mb-6 md:mb-0 md:w-52 lg:w-56">
120-
<div className="md:sticky md:top-[calc(var(--navbar-height)+1.5rem)]">
120+
<div className="md:sticky md:top-[calc(var(--navbar-height)+2.5rem)]">
121121
<PageTabs
122122
groups={groups}
123123
activeId={activeTab}
@@ -143,7 +143,7 @@ const AboutPage = memo(function AboutPage() {
143143
data-page-scroll
144144
role="region"
145145
aria-label="About content"
146-
className="min-w-0 flex-1 md:min-h-0 lg:overflow-y-auto"
146+
className="min-w-0 flex-1 md:min-h-0 md:overflow-y-auto lg:overflow-y-auto pb-8 sm:pb-12"
147147
>
148148
{activeTab === 'about' && <AboutMainSection />}
149149
{activeTab === 'changelog' && <ChangelogSection />}

src/pages/SettingsPage/SettingsPage.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ const SettingsPage = memo(function SettingsPage() {
117117
`sticky`, offset past the fixed navbar. */}
118118
<div className="page-container flex flex-col gap-6 py-6 sm:py-8 md:h-full md:min-h-0 md:flex-row md:gap-8 lg:gap-10">
119119
<div className="shrink-0 mb-6 md:mb-0 md:w-52 lg:w-56">
120-
<div className="md:sticky md:top-[calc(var(--navbar-height)+1.5rem)]">
120+
<div className="md:sticky md:top-[calc(var(--navbar-height)+2rem)]">
121121
<PageTabs
122122
groups={groups}
123123
activeId={activeTab}
@@ -143,7 +143,7 @@ const SettingsPage = memo(function SettingsPage() {
143143
data-page-scroll
144144
role="region"
145145
aria-label="Settings"
146-
className="min-w-0 flex-1 md:min-h-0 lg:overflow-y-auto"
146+
className="min-w-0 flex-1 md:min-h-0 md:overflow-y-auto lg:overflow-y-auto pb-8 sm:pb-12"
147147
>
148148
{activeTab === 'profile' && <AccountSection />}
149149
{activeTab === 'appearance' && <AppearanceSection />}

0 commit comments

Comments
 (0)