Cleanup[bmqu::OperationChain]: remove cpp03 autogenerated code (bloomberg#1531)

Signed-off-by: Evgeny Malygin <emalygin@bloomberg.net>

Author: 678098

src/groups/bmq/bmqu/bmqu_operationchain.h

@@ -101,14 +101,14 @@
 //      typedef bsl::function<void()>
 //              SendCallback;
 //
-//      typedef bsl::function<void(int clientId, int payload)>
+//      typedef bsl::function<void()>
 //              ReceiveCallback;
 //
 //      // CLASS FUNCTIONS
 //      static void onDataSent();
 //          // Callback invoked on completion of a 'send' operation.
 //
-//      static void onDataReceived(int clientId, int payload);
+//      static void onDataReceived();
 //          // Callback invoked on completion of a 'receive' operation.
 //
 //      static void send(int                 clientId,
@@ -119,9 +119,8 @@
 //          // 'completionCallback' when the payload is sent.
 //
 //      static void receive(const ReceiveCallback& completionCallback);
-//          // Receive a payload send to us by another client and invoke the
-//          // specified 'completionCallback' with the payload and the sender
-//          // client ID.
+//          // Receive a payload from another client and invoke the specified
+//          // 'completionCallback' when done.
 //  };
 //..
 // Lets say we want to "receive" data from 10 clients, and then "send" data
@@ -188,15 +187,6 @@
 #include <bsl_type_traits.h>
 #endif
 
-#if BSLS_COMPILERFEATURES_SIMULATE_CPP11_FEATURES
-// Include version that can be compiled with C++03
-// Generated on Wed Jun 18 14:44:06 2025
-// Command line: sim_cpp11_features.pl bmqu_operationchain.h
-# define COMPILING_BMQU_OPERATIONCHAIN_H
-# include <bmqu_operationchain_cpp03.h>
-#undef COMPILING_BMQU_OPERATIONCHAIN_H
-#else
-
 namespace BloombergLP {
 
 namespace bmqu {
@@ -299,14 +289,11 @@ class OperationChain_CompletionCallbackWrapper {
 
   public:
     // ACCESSORS
-#if !BSLS_COMPILERFEATURES_SIMULATE_CPP11_FEATURES  // $var-args=9
 
-    /// Invoke the associated completion callback with the specified `args`
-    /// arguments and notify the associated operation chain. Propagate any
-    /// exception thrown by the completion callback to the caller.
-    template <class... ARGS>
-    void operator()(ARGS&&... args) const;
-#endif
+    /// Invoke the associated completion callback and notify the associated
+    /// operation chain. Propagate any exception thrown by the completion
+    /// callback to the caller.
+    void operator()() const;
 
     // TRAITS
     BSLMF_NESTED_TRAIT_DECLARATION(OperationChain_CompletionCallbackWrapper,
@@ -795,27 +782,20 @@ inline OperationChain_CompletionCallbackWrapper<CO_CALLBACK>::
 }
 
 // ACCESSORS
-#if !BSLS_COMPILERFEATURES_SIMULATE_CPP11_FEATURES  // $var-args=9
 template <class CO_CALLBACK>
-template <class... ARGS>
-inline void OperationChain_CompletionCallbackWrapper<CO_CALLBACK>::operator()(
-    ARGS&&... args) const
+inline void
+OperationChain_CompletionCallbackWrapper<CO_CALLBACK>::operator()() const
 {
     try {
-        // invoke completion callback
-        bslmf::Util::moveIfSupported((*d_coCallback_p))(
-            bslmf::Util::forward<ARGS>(args)...);
+        bslmf::Util::moveIfSupported((*d_coCallback_p))();
     }
     catch (...) {
-        // notify the chain and rethrow the exception
         d_chain_p->onOperationCompleted(d_jobHandle);
         throw;  // THROW
     }
 
-    // notify the chain
     d_chain_p->onOperationCompleted(d_jobHandle);
 }
-#endif
 
 // ------------------------
 // class OperationChain_Job
@@ -1010,6 +990,4 @@ inline void bmqu::swap(OperationChainLink& lhs,
 
 }  // close enterprise namespace
 
-#endif  // End C++11 code
-
 #endif

src/groups/bmq/bmqu/bmqu_operationchain.t.cpp

@@ -59,19 +59,6 @@ void asyncNullOperation(bdlmt::ThreadPool*           threadPool,
     threadPool->enqueueJob(callback);
 }
 
-/// Invoke the specified completion `callback` on the specified `threadPool`
-/// with the specified `operationId` parameter.
-void asyncIdentifiableOperation(bdlmt::ThreadPool* threadPool,
-                                unsigned           operationId,
-                                const bsl::function<void(unsigned)>& callback)
-{
-    // PRECONDITIONS
-    BSLS_ASSERT(threadPool);
-    BSLS_ASSERT(callback);
-
-    threadPool->enqueueJob(bdlf::BindUtil::bind(callback, operationId));
-}
-
 /// Return a `bsls::TimeInterval` object encoding a point in time the
 /// specified number of `seconds` from now, according to the monotonic
 /// clock.
@@ -241,25 +228,24 @@ struct UsageExample {
     // TYPES
     typedef bsl::function<void()> SendCallback;
 
-    typedef bsl::function<void(int clientId, int payload)> ReceiveCallback;
+    typedef bsl::function<void()> ReceiveCallback;
 
     // CLASS FUNCTIONS
 
     /// Callback invoked on completion of a `send` operation.
     static void onDataSent();
 
     /// Callback invoked on completion of a `receive` operation.
-    static void onDataReceived(int clientId, int payload);
+    static void onDataReceived();
 
     /// Send the specified `payload` to the client identified by the
     /// specified `clientId` and invoke the specified
     /// `completionCallback` when the payload is sent.
     static void
     send(int clientId, int payload, const SendCallback& completionCallback);
 
-    /// Receive a payload send to us by another client and invoke the
-    /// specified `completionCallback` with the payload and the sender
-    /// client ID.
+    /// Receive a payload from another client and invoke the specified
+    /// `completionCallback` when done.
     static void receive(const ReceiveCallback& completionCallback);
 };
 
@@ -273,7 +259,7 @@ inline void UsageExample::onDataSent()
     // NOTHING
 }
 
-inline void UsageExample::onDataReceived(int, int)
+inline void UsageExample::onDataReceived()
 {
     // NOTHING
 }
@@ -286,7 +272,7 @@ UsageExample::send(int, int, const SendCallback& completionCallback)
 
 inline void UsageExample::receive(const ReceiveCallback& completionCallback)
 {
-    completionCallback(0, 0);
+    completionCallback();
 }
 
 // ============================================================================
@@ -412,13 +398,10 @@ static void test3_chain_startStop(bdlmt::ThreadPool* threadPool)
         for (unsigned operationId = 0; operationId < k_NUM_OPERATIONS;
              ++operationId) {
             chain.appendInplace(
-                bdlf::BindUtil::bind(&asyncIdentifiableOperation,
+                bdlf::BindUtil::bind(&asyncNullOperation,
                                      threadPool,
-                                     operationId,
                                      bdlf::PlaceHolders::_1),
-                bdlf::BindUtil::bind(PushBack(),
-                                     &completionIds,
-                                     bdlf::PlaceHolders::_1));
+                bdlf::BindUtil::bind(PushBack(), &completionIds, operationId));
         }
 
         // make sure operation haven't started executing
@@ -458,15 +441,13 @@ static void test3_chain_startStop(bdlmt::ThreadPool* threadPool)
         // add several operations
         for (unsigned operationId = 0; operationId < k_NUM_OPERATIONS;
              ++operationId) {
-            chain.appendInplace(
-                bdlf::BindUtil::bind(&asyncIdentifiableOperation,
-                                     threadPool,
-                                     operationId,
-                                     bdlf::PlaceHolders::_1),
-                bdlf::BindUtil::bind(PushBackSynchronize(),
-                                     &semaphore,
-                                     &completionIds,
-                                     bdlf::PlaceHolders::_1));
+            chain.appendInplace(bdlf::BindUtil::bind(&asyncNullOperation,
+                                                     threadPool,
+                                                     bdlf::PlaceHolders::_1),
+                                bdlf::BindUtil::bind(PushBackSynchronize(),
+                                                     &semaphore,
+                                                     &completionIds,
+                                                     operationId));
         }
 
         // no executing operations
@@ -524,13 +505,12 @@ static void test4_chain_join(bdlmt::ThreadPool* threadPool)
     // add several operations
     for (unsigned operationId = 0; operationId < k_NUM_OPERATIONS;
          ++operationId) {
-        chain.appendInplace(bdlf::BindUtil::bind(&asyncIdentifiableOperation,
+        chain.appendInplace(bdlf::BindUtil::bind(&asyncNullOperation,
                                                  threadPool,
-                                                 operationId,
                                                  bdlf::PlaceHolders::_1),
                             bdlf::BindUtil::bind(PushBackRndSleep(),
                                                  &completionIds,
-                                                 bdlf::PlaceHolders::_1));
+                                                 operationId));
     }
 
     // start executing
@@ -1102,13 +1082,12 @@ static void test10_chain_serialization(bdlmt::ThreadPool* threadPool)
     for (unsigned i = 0; i < k_NUM_LINKS; ++i) {
         for (unsigned j = 0; j < k_NUM_OPERATIONS; ++j) {
             unsigned operationId = i * k_NUM_OPERATIONS + j;
-            link.insert(bdlf::BindUtil::bind(&asyncIdentifiableOperation,
+            link.insert(bdlf::BindUtil::bind(&asyncNullOperation,
                                              threadPool,
-                                             operationId,
                                              bdlf::PlaceHolders::_1),
                         bdlf::BindUtil::bind(PushBackRndSleep(),
                                              &completionIds,
-                                             bdlf::PlaceHolders::_1));
+                                             operationId));
         }
 
         chain.append(&link);