Commit c33f7ac
committed
ci: satisfy zizmor — pin actions and scope permissions
Pins all four action references to commit SHAs, keeping the version as a
trailing comment so the intent stays readable and Dependabot can still update
them. This was the reported failure: unpinned-uses is a mandatory check under a
blanket pin-to-hash policy.
Fixing only that would have left CI red, because the gate also fails on any
Medium finding and three more were present, all pre-existing:
- artipacked: actions/checkout persists the GITHUB_TOKEN into .git/config,
which is reachable from build output and uploaded artifacts. The build job
never pushes and the deploy job supplies its own token, so
persist-credentials: false costs nothing.
- excessive-permissions (x2): the workflow declared no permissions, so both
jobs ran with broad defaults. Deny at the top level and opt in per job --
contents: read for build, and deploy keeps the contents: write it already had.
Verified with zizmor 1.29.0 locally: 'No findings to report', exit 0, where the
same run previously reported four errors plus three warnings. The build pipeline
is unaffected -- tests pass and the staged artifact is still byte-identical.
Note actions/checkout is pinned at v2, which is old enough to be worth bumping
on its own merits; left alone here to keep this change to the security fix.1 parent e9d5b28 commit c33f7ac
1 file changed
Lines changed: 14 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
8 | 11 | | |
9 | 12 | | |
| 13 | + | |
| 14 | + | |
10 | 15 | | |
11 | 16 | | |
12 | | - | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
13 | 23 | | |
14 | 24 | | |
15 | 25 | | |
16 | | - | |
| 26 | + | |
17 | 27 | | |
18 | 28 | | |
19 | 29 | | |
| |||
27 | 37 | | |
28 | 38 | | |
29 | 39 | | |
30 | | - | |
| 40 | + | |
31 | 41 | | |
32 | 42 | | |
33 | 43 | | |
| |||
39 | 49 | | |
40 | 50 | | |
41 | 51 | | |
42 | | - | |
| 52 | + | |
43 | 53 | | |
44 | 54 | | |
45 | 55 | | |
| |||
0 commit comments