Skip to content

Running the release tool with --dry-run should not post PRs #245

Description

@joestringer

The flag says:

      --dry-run                   If enabled, it will not perform irreversible operations into GitHub such as: syncing GH projects, pushing tags. All changes that are done locally as well as creating and pushing PRs are also considered reversible and therefore not affected by this flag's value.

Even if posting a PR is reversible, it is surprising for the tool to push a PR when --dry-run is enabled. For instance, I was running this script to locally inspect what the tool would generate, and then it opened a PR on cilium/cilium.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions