Trim comments that narrated the bug fix instead of the code

Code comments should explain non-obvious behavior of the code itself;
the bug/fix narrative belongs in the commit message and PR
description, not inline, where it goes stale as the code evolves.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Author: cinar

momentum/fisher.go

@@ -59,21 +59,11 @@ func NewFisher[T helper.Float]() *Fisher[T] {
 
 // ComputeWithContext function takes a channel of numbers and computes the Fisher Transform.
 func (f *Fisher[T]) ComputeWithContext(ctx context.Context, closings <-chan T) <-chan T {
-	// Split closings into three branches for Min, Max, and the aligned
-	// closings below. This used to collect the whole input into a slice
-	// upfront instead (to hand each branch its own independent channel),
-	// but that made ComputeWithContext block synchronously until closings
-	// closed before returning anything -- unlike every other indicator in
-	// this package -- which deadlocks a caller that duplicates closings
-	// itself and only starts draining the other branch after this call
-	// returns.
 	inputs := helper.DuplicateWithContext(ctx, closings, 3)
 	input1, input2, input3 := inputs[0], inputs[1], inputs[2]
 
-	// Compute min and max. minValues feeds both the range (max - min) and
-	// close-min-min below, so it needs its own duplicated copy for the
-	// second use -- a channel only has one consumer's worth of values to
-	// give out.
+	// minValues is used twice below (range and close-minus-min), so it
+	// needs its own duplicated copy for the second use.
 	minSplice := helper.DuplicateWithContext(ctx, f.Min.ComputeWithContext(ctx, input1), 2)
 	maxValues := f.Max.ComputeWithContext(ctx, input2)
 
@@ -111,12 +101,9 @@ func (f *Fisher[T]) ComputeWithContext(ctx context.Context, closings <-chan T) <
 
 // IdlePeriod is the initial period that Fisher Transform won't yield any results.
 func (f *Fisher[T]) IdlePeriod() int {
-	// minValues, maxValues, and alignedClosings are all computed
-	// independently over the same window of the original input (Min and
-	// Max each skip their own Period-1 internally; alignedClosings skips
-	// Period-1 to land on the same window's last close), not chained one
-	// after another, so their delays don't compound: the combined idle
-	// period is just Period-1, the same as Min/Max's own.
+	// Min, Max, and the aligned closings are each independently delayed
+	// by Period-1 from the same input, not chained one after another, so
+	// the delay doesn't compound.
 	return f.Period - 1
 }
 

momentum/fisher_test.go

@@ -38,9 +38,8 @@ func TestFisherSimple(t *testing.T) {
 	t.Logf("Fisher values: %v", resultSlice[:5])
 }
 
-// referenceFisher independently computes the Fisher Transform with a plain
-// sliding-window min/max over a slice, to verify Fisher's values rather
-// than just its output length or well-formedness.
+// referenceFisher computes the Fisher Transform with a plain sliding-window
+// min/max over a slice, independently of Fisher's channel implementation.
 func referenceFisher(closings []float64, period int) []float64 {
 	var out []float64
 
@@ -71,15 +70,6 @@ func referenceFisher(closings []float64, period int) []float64 {
 	return out
 }
 
-// TestFisherValues guards against a regression where minValues was read by
-// two consumers (the range and the close-minus-min terms) without being
-// duplicated first, and IdlePeriod() double-counted a delay that doesn't
-// compound (min, max, and the aligned closings are each independently
-// delayed by the same Period-1, not chained one after another the way
-// T3's EMAs are). Both silently produced wrong output rather than a build
-// or panic, so this compares against an independently computed reference
-// instead of just length or well-formedness, the way TestFisherSimple
-// already did.
 func TestFisherValues(t *testing.T) {
 	closings := make([]float64, 400)
 	for i := range closings {