Skip to content

New Homebrew warnings about depends_on :macos #14

Description

@wincent

Some recent Homebrew version (not exactly sure which, but this started in the last few days or so, and I'm on v5.1.15 right now) started producing this warning when running brew upgrade:

Warning: Calling `depends_on :macos` with `depends_on macos:` is deprecated! Use `depends_on :macos` with `depends_on macos:` inside an `on_macos` block instead.
Please report this issue to the cirruslabs/homebrew-cli tap (not Homebrew/* repositories), or even better, submit a PR to fix it:
  /opt/homebrew/Library/Taps/cirruslabs/homebrew-cli/tart.rb:22

I see the formula files are generated:

# This file was generated by GoReleaser. DO NOT EDIT.

so we can't simply edit them. My clanker tells me the fixes need to go in the upstream repos with a diff like:

diff --git a/.goreleaser.yml b/.goreleaser.yml
index 18f4232..43b9044 100644
--- a/.goreleaser.yml
+++ b/.goreleaser.yml
@@ -72,7 +72,9 @@ brews:
       libexec.install Dir["*"]
       bin.write_exec_script "#{libexec}/tart.app/Contents/MacOS/tart"
     custom_block: |
-      depends_on :macos => :ventura
+      on_macos do
+        depends_on :macos => :ventura
+      end
       def post_install
         generate_completions_from_executable(libexec/"tart.app/Contents/MacOS/tart", "--generate-completion-script")
       end

So, I sent these two:

but am opening this issue here as well to track both.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Fields

    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions