Skip to content

Commit 8553e81

Browse files
fix: include traceback in unexpected error messages for easier debugging (#34)
* fix: include traceback in unexpected error messages for easier debugging * Update cli.py to move import traceback to top of the file * Update cli.py with Lint fix --------- Co-authored-by: haosenwang1018 <haosenwang1018@users.noreply.github.com> Co-authored-by: Vineeth Sai Narajala <vnarajal@cisco.com>
1 parent db46726 commit 8553e81

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

skill_scanner/cli/cli.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
import logging
2424
import os
2525
import sys
26+
import traceback
2627
from collections.abc import Callable
2728
from pathlib import Path
2829

@@ -384,6 +385,7 @@ def scan_command(args: argparse.Namespace) -> int:
384385
return 1
385386
except Exception as e:
386387
print(f"Unexpected error: {e}", file=sys.stderr)
388+
traceback.print_exc(file=sys.stderr)
387389
return 1
388390

389391

@@ -489,6 +491,7 @@ def scan_all_command(args: argparse.Namespace) -> int:
489491

490492
except Exception as e:
491493
print(f"Unexpected error: {e}", file=sys.stderr)
494+
traceback.print_exc(file=sys.stderr)
492495
return 1
493496

494497

skill_scanner/core/scanner.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -711,7 +711,7 @@ def scan_directory(
711711
report.skills_skipped.append({"skill": str(skill_dir), "reason": str(e)})
712712
continue
713713
except Exception as e:
714-
logger.error("Unexpected error scanning %s: %s", skill_dir, e)
714+
logger.error("Unexpected error scanning %s: %s", skill_dir, e, exc_info=True)
715715
report.skills_skipped.append({"skill": str(skill_dir), "reason": str(e)})
716716
continue
717717

0 commit comments

Comments
 (0)