Skip to content

Commit 10fda17

Browse files
committed
Fix AttributeError to be compatible with CKAN2.12
1 parent c375c59 commit 10fda17

3 files changed

Lines changed: 17 additions & 18 deletions

File tree

ckanext/dcat/logic.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -147,7 +147,7 @@ def _page_url(page):
147147
base_url = '%s%s' % (
148148
base_url, toolkit.request.path)
149149

150-
params = [p for p in toolkit.request.params.items()
150+
params = [p for p in toolkit.request.args.items()
151151
if p[0] != 'page' and p[0] in ('modified_since', 'profiles', 'q', 'fq')]
152152
if params:
153153
qs = '&'.join(

ckanext/dcat/tests/logic/test_logic.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ def test_pagination_same_results_than_page_size(self):
203203
@mock.patch('ckan.plugins.toolkit.request')
204204
def test_pagination_keeps_only_supported_params(self, mock_request):
205205

206-
mock_request.params = {'a': 1, 'b': 2, 'modified_since': '2018-03-22', 'profiles': 'schemaorg'}
206+
mock_request.args = {'a': 1, 'b': 2, 'modified_since': '2018-03-22', 'profiles': 'schemaorg'}
207207
mock_request.host_url = 'http://ckan.test.ckan.net'
208208
mock_request.path = '/feed/catalog.xml'
209209

@@ -231,7 +231,7 @@ def test_pagination_keeps_only_supported_params(self, mock_request):
231231
@mock.patch('ckan.plugins.toolkit.request')
232232
def test_pagination_with_dcat_base_uri(self, mock_request):
233233

234-
mock_request.params = {}
234+
mock_request.args = {}
235235
mock_request.host_url = 'http://ckan.test.ckan.net'
236236
mock_request.path = '/feed/catalog.xml'
237237

ckanext/dcat/utils.py

Lines changed: 14 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -380,18 +380,17 @@ def check_access_header():
380380

381381

382382
def dcat_json_page():
383-
data_dict = {
384-
'page': toolkit.request.params.get('page'),
385-
'modified_since': toolkit.request.params.get('modified_since'),
386-
}
383+
data_dict = {
384+
'page': toolkit.request.args.get('page'),
385+
'modified_since': toolkit.request.args.get('modified_since'),
386+
}
387387

388-
try:
389-
datasets = toolkit.get_action('dcat_datasets_list')({},
390-
data_dict)
391-
except toolkit.ValidationError as e:
392-
return toolkit.abort(409, str(e))
388+
try:
389+
datasets = toolkit.get_action('dcat_datasets_list')({}, data_dict)
390+
except toolkit.ValidationError as e:
391+
return toolkit.abort(409, str(e))
393392

394-
return datasets
393+
return datasets
395394

396395

397396
def read_dataset_page(_id, _format):
@@ -428,15 +427,15 @@ def read_catalog_page(_format):
428427
if not _format:
429428
return index_endpoint()
430429

431-
_profiles = toolkit.request.params.get('profiles')
430+
_profiles = toolkit.request.args.get('profiles')
432431
if _profiles:
433432
_profiles = _profiles.split(',')
434433

435434
data_dict = {
436-
'page': toolkit.request.params.get('page'),
437-
'modified_since': toolkit.request.params.get('modified_since'),
438-
'q': toolkit.request.params.get('q'),
439-
'fq': toolkit.request.params.get('fq'),
435+
'page': toolkit.request.args.get('page'),
436+
'modified_since': toolkit.request.args.get('modified_since'),
437+
'q': toolkit.request.args.get('q'),
438+
'fq': toolkit.request.args.get('fq'),
440439
'format': _format,
441440
'profiles': _profiles,
442441
}

0 commit comments

Comments
 (0)