General clean-up and removal of dead code

ernst-dev · ernst-dev · commit 50756f171b9e · 2026-03-26T13:36:22.000+01:00
diff --git a/src/prompt-input/__tests__/dom-utils.test.ts b/src/prompt-input/__tests__/dom-utils.test.ts
@@ -10,7 +10,6 @@ import {
   createTrailingBreak,
   findAllParagraphs,
   findElement,
-  findElements,
   getLogicalDirection,
   getTokenType,
   hasOnlyTrailingBR,
@@ -97,42 +96,6 @@ describe('createTrailingBreak', () => {
   });
 });
 
-describe('findElements', () => {
-  test('finds elements by tokenType', () => {
-    const container = document.createElement('div');
-    const ref1 = document.createElement('span');
-    ref1.setAttribute('data-type', 'reference');
-    const ref2 = document.createElement('span');
-    ref2.setAttribute('data-type', 'reference');
-    const other = document.createElement('span');
-    other.setAttribute('data-type', 'text');
-    container.appendChild(ref1);
-    container.appendChild(ref2);
-    container.appendChild(other);
-
-    const results = findElements(container, { tokenType: 'reference' });
-    expect(results).toHaveLength(2);
-  });
-
-  test('finds elements by array of tokenTypes', () => {
-    const container = document.createElement('div');
-    const refEl = document.createElement('span');
-    refEl.setAttribute('data-type', 'reference');
-    const pinned = document.createElement('span');
-    pinned.setAttribute('data-type', 'pinned');
-    container.appendChild(refEl);
-    container.appendChild(pinned);
-
-    const results = findElements(container, { tokenType: ['reference', 'pinned'] });
-    expect(results).toHaveLength(2);
-  });
-
-  test('returns empty array when no options provided', () => {
-    const container = document.createElement('div');
-    expect(findElements(container, {})).toEqual([]);
-  });
-});
-
 describe('findElement', () => {
   test('finds first matching element', () => {
     const container = document.createElement('div');
@@ -318,32 +281,6 @@ describe('setEmptyState', () => {
   });
 });
 
-describe('findElements with tokenId', () => {
-  test('finds element by data-id for non-trigger types', () => {
-    const container = document.createElement('div');
-    const el = document.createElement('span');
-    el.setAttribute('data-type', 'reference');
-    el.setAttribute('data-id', 'ref-123');
-    container.appendChild(el);
-
-    const results = findElements(container, { tokenType: 'reference', tokenId: 'ref-123' });
-    expect(results).toHaveLength(1);
-    expect(results[0]).toBe(el);
-  });
-
-  test('finds trigger element by data-id attribute', () => {
-    const container = document.createElement('div');
-    const el = document.createElement('span');
-    el.setAttribute('data-type', ElementType.Trigger);
-    el.setAttribute('data-id', 'trigger-123');
-    container.appendChild(el);
-
-    const results = findElements(container, { tokenType: ElementType.Trigger, tokenId: 'trigger-123' });
-    expect(results).toHaveLength(1);
-    expect(results[0]).toBe(el);
-  });
-});
-
 describe('getLogicalDirection', () => {
   let el: HTMLDivElement;
 
diff --git a/src/prompt-input/__tests__/token-utils.test.ts b/src/prompt-input/__tests__/token-utils.test.ts
@@ -13,7 +13,6 @@ import {
   getCaretPositionAfterTokenRemoval,
   mergeConsecutiveTextTokens,
   validateTrigger,
-  validateTriggerWithPinnedTokens,
 } from '../core/token-utils';
 import { PromptInputProps } from '../interfaces';
 
@@ -123,37 +122,6 @@ describe('areAllTokensPinned', () => {
   });
 });
 
-describe('validateTriggerWithPinnedTokens', () => {
-  const useAtStartMenu: PromptInputProps.MenuDefinition = {
-    id: 'files',
-    trigger: '#',
-    options: [],
-    useAtStart: true,
-  };
-  const normalMenu: PromptInputProps.MenuDefinition = {
-    id: 'mentions',
-    trigger: '@',
-    options: [],
-  };
-
-  test('returns true for useAtStart menu when all preceding tokens are pinned', () => {
-    expect(validateTriggerWithPinnedTokens(useAtStartMenu, [pinnedRef('p1', '#a', 'a', 'f')])).toBe(true);
-  });
-
-  test('returns true for useAtStart menu when no preceding tokens', () => {
-    expect(validateTriggerWithPinnedTokens(useAtStartMenu, [])).toBe(true);
-  });
-
-  test('returns false for useAtStart menu when preceding tokens include non-pinned', () => {
-    expect(validateTriggerWithPinnedTokens(useAtStartMenu, [text('hello')])).toBe(false);
-  });
-
-  test('returns true for normal menu regardless of preceding tokens', () => {
-    expect(validateTriggerWithPinnedTokens(normalMenu, [text('hello')])).toBe(true);
-    expect(validateTriggerWithPinnedTokens(normalMenu, [])).toBe(true);
-  });
-});
-
 describe('validateTrigger', () => {
   const useAtStartMenu: PromptInputProps.MenuDefinition = {
     id: 'files',
diff --git a/src/prompt-input/core/dom-utils.ts b/src/prompt-input/core/dom-utils.ts
@@ -91,12 +91,6 @@ function buildTokenSelector(options: TokenQueryOptions): string {
   return selector;
 }
 
-/** Finds all elements matching the given token type and/or token ID within a container. */
-export function findElements(container: HTMLElement, options: TokenQueryOptions): HTMLElement[] {
-  const selector = buildTokenSelector(options);
-  return selector ? Array.from(container.querySelectorAll<HTMLElement>(selector)) : [];
-}
-
 /** Finds the first element matching the given token type and/or token ID within a container. */
 export function findElement(container: HTMLElement, options: TokenQueryOptions): HTMLElement | null {
   const selector = buildTokenSelector(options);
@@ -137,11 +131,6 @@ export function isEmptyState(element: HTMLElement): boolean {
   return paragraphs.length === 0 || (paragraphs.length === 1 && hasOnlyTrailingBR(paragraphs[0]));
 }
 
-/** Checks if a token type represents a caret spot element. */
-export function isCaretSpotType(tokenType: ElementType | string | null): boolean {
-  return tokenType === ElementType.CaretSpotBefore || tokenType === ElementType.CaretSpotAfter;
-}
-
 /** Resets the element to a single empty paragraph with a trailing BR. */
 export function setEmptyState(element: HTMLElement): void {
   const paragraphs = findAllParagraphs(element);
@@ -156,6 +145,11 @@ export function setEmptyState(element: HTMLElement): void {
   element.appendChild(p);
 }
 
+/** Checks if a token type represents a caret spot element. */
+export function isCaretSpotType(tokenType: ElementType | string | null): boolean {
+  return tokenType === ElementType.CaretSpotBefore || tokenType === ElementType.CaretSpotAfter;
+}
+
 export type ArrowDirection = 'backward' | 'forward';
 
 /** Resolves an arrow key to a logical reading direction, accounting for RTL. */
diff --git a/src/prompt-input/core/event-handlers.ts b/src/prompt-input/core/event-handlers.ts
@@ -19,6 +19,7 @@ import {
   isCaretSpotType,
   isElementEffectivelyEmpty,
   isReferenceElementType,
+  setEmptyState,
   stripZeroWidthCharacters,
 } from './dom-utils';
 import { MenuItemsHandlers, MenuItemsState } from './menu-state';
@@ -237,11 +238,14 @@ export function handleReferenceTokenDeletion(
 
     // Clean up empty paragraphs left behind after deleting across paragraph boundaries
     const paragraphs = findAllParagraphs(editableElement);
-    if (paragraphs.length > 1) {
-      const firstNonEmpty = paragraphs.find(p => !isElementEffectivelyEmpty(p));
-      const keepParagraph = firstNonEmpty || paragraphs[0];
+    const allEmpty = paragraphs.every(p => isElementEffectivelyEmpty(p));
+
+    if (allEmpty) {
+      setEmptyState(editableElement);
+    } else if (paragraphs.length > 1) {
+      const firstNonEmpty = paragraphs.find(p => !isElementEffectivelyEmpty(p))!;
       for (const p of paragraphs) {
-        if (p !== keepParagraph) {
+        if (p !== firstNonEmpty) {
           p.remove();
         }
       }
diff --git a/src/prompt-input/core/token-operations.ts b/src/prompt-input/core/token-operations.ts
@@ -27,12 +27,6 @@ import {
 
 export type UpdateSource = 'user-input' | 'external' | 'menu-selection' | 'internal';
 
-export interface TokenUpdate {
-  tokens: PromptInputProps.InputToken[];
-  source: UpdateSource;
-  caretPosition?: number;
-}
-
 export interface ShortcutsConfig {
   menus?: readonly PromptInputProps.MenuDefinition[];
   tokensToText?: (tokens: readonly PromptInputProps.InputToken[]) => string;
diff --git a/src/prompt-input/core/token-renderer.tsx b/src/prompt-input/core/token-renderer.tsx
@@ -54,14 +54,6 @@ export interface PortalContainer {
   label: string;
 }
 
-/** Props passed to the renderToken callback for rendering reference tokens. */
-export interface RenderTokenProps {
-  id: string;
-  label: string;
-  disabled: boolean;
-  readOnly: boolean;
-}
-
 interface ParagraphGroup {
   tokens: PromptInputProps.InputToken[];
 }
diff --git a/src/prompt-input/core/token-utils.ts b/src/prompt-input/core/token-utils.ts
@@ -56,16 +56,6 @@ export function areAllTokensPinned(tokens: readonly PromptInputProps.InputToken[
   return tokens.every(isPinnedReferenceToken);
 }
 
-export function validateTriggerWithPinnedTokens(
-  menu: PromptInputProps.MenuDefinition,
-  precedingTokens: readonly PromptInputProps.InputToken[]
-): boolean {
-  if (menu.useAtStart) {
-    return areAllTokensPinned(precedingTokens);
-  }
-  return true;
-}
-
 /** Checks if a trigger is valid given the menu config, position, and preceding tokens. */
 export function validateTrigger(
   menu: PromptInputProps.MenuDefinition,

Original file line number	Diff line number	Diff line change
`@@ -54,14 +54,6 @@ export interface PortalContainer {`
`54`	`54`	`label: string;`
`55`	`55`	`}`
`56`	`56`
`57`		`-/** Props passed to the renderToken callback for rendering reference tokens. */`
`58`		`-export interface RenderTokenProps {`
`59`		`- id: string;`
`60`		`- label: string;`
`61`		`- disabled: boolean;`
`62`		`- readOnly: boolean;`
`63`		`-}`
`64`		`-`
`65`	`57`	`interface ParagraphGroup {`
`66`	`58`	`tokens: PromptInputProps.InputToken[];`
`67`	`59`	`}`