Fyst 2318 contact information disappears upon entry (#225)

* and a session ender

---------

Co-authored-by: Drew Proebstel <dproebstel@codeforamerica.org>

Author: DrewProebstel

app/controllers/base_controller.rb

@@ -28,6 +28,14 @@ def create_and_login_state_file_archived_intake(phone_number: nil, email_address
     sign_in intake
   end
 
+  def logout_clear_session
+    sign_out(:state_file_archived_intake) if respond_to?(:sign_out)
+
+    session[:ssn_verified] = false
+    session[:mailing_verified] = false
+    session[:code_verified] = false
+  end
+
   def is_intake_unavailable
     if current_state_file_archived_intake.nil?
       redirect_to knock_out_path

app/controllers/email_address_controller.rb

@@ -1,5 +1,6 @@
 class EmailAddressController < BaseController
   def edit
+    logout_clear_session
     @form = EmailAddressForm.new
   end
 

app/controllers/phone_number_controller.rb

@@ -1,5 +1,6 @@
 class PhoneNumberController < BaseController
   def edit
+    logout_clear_session
     @form = PhoneNumberForm.new
   end
 

spec/controllers/email_address_controller_spec.rb

@@ -9,6 +9,41 @@
   end
 
   describe "GET #edit" do
+    it "signs out any existing state_file_archived_intake and resets verification flags" do
+      intake = create(:state_file_archived_intake)
+      sign_in intake
+
+      session[:ssn_verified] = true
+      session[:mailing_verified] = true
+      session[:code_verified] = true
+
+      get :edit
+
+      expect(controller.current_state_file_archived_intake).to be_nil
+
+      expect(session[:ssn_verified]).to eq(false)
+      expect(session[:mailing_verified]).to eq(false)
+      expect(session[:code_verified]).to eq(false)
+
+      expect(assigns(:form)).to be_a(EmailAddressForm)
+      expect(response).to render_template(:edit)
+    end
+
+    it "initializes a new EmailAddressForm and sets verification flags to false when no one is signed in" do
+      session[:ssn_verified] = true
+      session[:mailing_verified] = nil
+      session[:code_verified] = true
+
+      get :edit
+
+      expect(assigns(:form)).to be_a(EmailAddressForm)
+      expect(response).to render_template(:edit)
+
+      expect(session[:ssn_verified]).to eq(false)
+      expect(session[:mailing_verified]).to eq(false)
+      expect(session[:code_verified]).to eq(false)
+    end
+
     it "renders the edit template with a new EmailAddressForm" do
       get :edit
 

spec/controllers/phone_number_controller_spec.rb

@@ -1,13 +1,47 @@
 require "rails_helper"
 
 RSpec.describe PhoneNumberController, type: :controller do
+  include Devise::Test::ControllerHelpers
+
+  before do
+    request.env["devise.mapping"] = Devise.mappings[:state_file_archived_intake]
+  end
+
   describe "GET #edit" do
-    it "renders the edit template with a new PhoneNumberForm" do
+    it "signs out any existing state_file_archived_intake and resets verification flags" do
+      intake = create(:state_file_archived_intake)
+      sign_in intake
+
+      session[:ssn_verified] = true
+      session[:mailing_verified] = true
+      session[:code_verified] = true
+
       get :edit
 
+      expect(controller.current_state_file_archived_intake).to be_nil
+
+      expect(session[:ssn_verified]).to eq(false)
+      expect(session[:mailing_verified]).to eq(false)
+      expect(session[:code_verified]).to eq(false)
+
       expect(assigns(:form)).to be_a(PhoneNumberForm)
       expect(response).to render_template(:edit)
     end
+
+    it "initializes a new PhoneNumberForm and sets verification flags to false when no one is signed in" do
+      session[:ssn_verified] = true
+      session[:mailing_verified] = nil
+      session[:code_verified] = true
+
+      get :edit
+
+      expect(assigns(:form)).to be_a(PhoneNumberForm)
+      expect(response).to render_template(:edit)
+
+      expect(session[:ssn_verified]).to eq(false)
+      expect(session[:mailing_verified]).to eq(false)
+      expect(session[:code_verified]).to eq(false)
+    end
   end
 
   describe "POST #update" do