Commit be02daa
authored
Add swipe and button navigation for previous/next zip code on mobile map (#504)
Design context: #404
## Problem
The dot pagination on the map page is hidden below 768px (`hidden
md:block`), so on mobile there is no way to move between zip codes
except tapping a polygon directly. This was split out of #404 to keep
that PR small.
## What this adds
- **Swipe** on the zip details card - left for next, right for previous.
Bound to the card rather than the map, so it never competes with
MapLibre's pan and pinch-zoom.
- **Previous/next buttons** below 768px with an "N of 13" position
counter, placed at the top of the card so they're visible without
scrolling.
- Wrap-around at both ends, so no control is ever a dead end. Shared
with the desktop dots via a `mod` helper moved into `lib/utils.ts`.
- An `aria-live` region announcing the selected zip code.
## Design decision worth flagging
@GTBarrows - the mockup in #404 annotates the `《 》` chevrons "Swipe
indicator, not to be including in final production," which reads as
swipe-only. I've shipped visible buttons anyway, because #482 is framed
as an accessibility improvement and swipe-only has no keyboard path, no
screen reader affordance, and no discoverability.
The buttons are 44px to meet WCAG 2.5.5. The dots they replace are 12px,
which is the same reason the carousel was cut from mobile in the first
place.
Happy to change this if you'd rather keep the card clean - wanted the
reasoning explicit rather than quietly diverging from the design.
## Accessibility note
This adds the app's first `aria-live` region. It sits on the card rather
than inside `ZipDetailsContent`, which early-returns for error and empty
states, so zip changes are announced regardless of source: map click,
desktop dots, mobile buttons, or swipe. That fixes a pre-existing
desktop gap as a side effect.
`DotPagination`'s chevron buttons also had no accessible name; they now
take optional label props.
## Out of scope
- **Map recentering.** On mobile the card covers the lower half of the
viewport, so navigating can highlight a polygon hidden behind it. Left
out pending @CurtSavoie's call on whether it belongs here or in a
follow-up.
- **Other locales.** New keys added to `en-US.json` only. `es-ES`,
`zh-CN`, and `zh-TW` need a team decision on whether new keys get real
translations, English placeholders, or `null` like `template.json`.
## Testing
`npm run test`, `npm run build`, `npm run lint`, and `npm run lint:css`
all clean.
The swipe decision is extracted as a pure `resolveSwipe()` with 8 unit
tests, so it's covered by the existing Vitest setup. The repo has no
component testing infrastructure (no Testing Library or jsdom) and
adding it seemed out of scope for an issue explicitly about keeping the
PR small.
Manually verified at mobile widths in Chrome device emulation:
- Swipe left and right advance and reverse correctly
- Wrap-around works in both directions
- Vertical card scrolling does not trigger navigation
- Diagonal drags are rejected
- Map pan and pinch-zoom unaffected
- Buttons keyboard-reachable; Enter and Space both activate
- Dots return and mobile nav disappears above 768px
- All new i18n keys resolve, no raw key strings rendered1 parent d22642e commit be02daa
8 files changed
Lines changed: 314 additions & 12 deletions
File tree
- client/src
- components
- pages/maps
- ui
- data/locales
- lib
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
60 | 64 | | |
61 | | - | |
| 65 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
11 | | - | |
| 12 | + | |
12 | 13 | | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
21 | 23 | | |
22 | 24 | | |
23 | 25 | | |
| 26 | + | |
| 27 | + | |
24 | 28 | | |
25 | 29 | | |
26 | 30 | | |
| |||
283 | 287 | | |
284 | 288 | | |
285 | 289 | | |
| 290 | + | |
286 | 291 | | |
287 | 292 | | |
288 | 293 | | |
| |||
299 | 304 | | |
300 | 305 | | |
301 | 306 | | |
| 307 | + | |
| 308 | + | |
| 309 | + | |
| 310 | + | |
| 311 | + | |
| 312 | + | |
| 313 | + | |
| 314 | + | |
| 315 | + | |
| 316 | + | |
| 317 | + | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
| 321 | + | |
| 322 | + | |
| 323 | + | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
302 | 331 | | |
303 | 332 | | |
304 | 333 | | |
| |||
368 | 397 | | |
369 | 398 | | |
370 | 399 | | |
| 400 | + | |
371 | 401 | | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
| 413 | + | |
| 414 | + | |
| 415 | + | |
| 416 | + | |
| 417 | + | |
372 | 418 | | |
373 | 419 | | |
374 | 420 | | |
375 | | - | |
| 421 | + | |
376 | 422 | | |
377 | 423 | | |
378 | 424 | | |
379 | 425 | | |
380 | 426 | | |
| 427 | + | |
| 428 | + | |
381 | 429 | | |
382 | 430 | | |
383 | 431 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
0 commit comments