Skip to content

Commit 9eb3ce6

Browse files
authored
zero-initialize fds and buffs before ipc_sendrecv_with_fds (#659)
zero-initialize fds and buffs before ipc_sendrecv
1 parent 175e9d2 commit 9eb3ce6

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

msgq/visionipc/visionipc_client.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ bool VisionIpcClient::connect(bool blocking) {
5252
assert(r == sizeof(type));
5353

5454
// Get FDs
55-
int fds[VISIONIPC_MAX_FDS];
56-
VisionBuf bufs[VISIONIPC_MAX_FDS];
55+
int fds[VISIONIPC_MAX_FDS] = {};
56+
VisionBuf bufs[VISIONIPC_MAX_FDS] = {};
5757
r = ipc_sendrecv_with_fds(false, socket_fd, &bufs, sizeof(bufs), fds, VISIONIPC_MAX_FDS, &num_buffers);
5858
if (r < 0) {
5959
// only expected error is server shutting down

msgq/visionipc/visionipc_server.cc

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -134,9 +134,9 @@ void VisionIpcServer::listener(){
134134
continue;
135135
}
136136

137-
int fds[VISIONIPC_MAX_FDS];
137+
int fds[VISIONIPC_MAX_FDS] = {};
138138
int num_fds = buffers[type].size();
139-
VisionBuf bufs[VISIONIPC_MAX_FDS];
139+
VisionBuf bufs[VISIONIPC_MAX_FDS] = {};
140140

141141
for (int i = 0; i < num_fds; i++){
142142
fds[i] = buffers[type][i]->fd;

0 commit comments

Comments
 (0)