Skip to content

Commit 8a07c20

Browse files
OffgridwithJDclaude
andcommitted
ci: pgindent the file-format magic comments in open_pg_tde.h
The multi-line trailing comment on OPEN_PG_TDE_WAL_KEY_FILE_MAGIC sat at a deep indentation where it ran past the line-length limit, so the pgindent check wanted to rewrap it. Move the rationale into the block comment above the defines and shorten the trailing comments, which is clearer and keeps them well under the column limit. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 86ff777 commit 8a07c20

1 file changed

Lines changed: 7 additions & 12 deletions

File tree

src/include/open_pg_tde.h

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,14 @@
1111
#define TDE_TRANCHE_NAME "open_pg_tde_tranche"
1212

1313
/*
14-
* Only numeric version (the most left byte) should be changed when updating
15-
* file format. Otherwise, it will break the migration process.
14+
* File format magics. Only the numeric version (the most significant byte)
15+
* should change when the format changes; otherwise migration breaks. The
16+
* current formats (WAL key file v3, SMGR key map file v6) authenticate
17+
* key_base_iv in the AEAD additional authenticated data; it was unauthenticated
18+
* in the previous formats (WAL v2, map v5).
1619
*/
17-
#define OPEN_PG_TDE_WAL_KEY_FILE_MAGIC 0x034B4557 /* version ID value = WEK
18-
* 03; v3 authenticates
19-
* key_base_iv in the AEAD
20-
* AAD (was excluded in v2) */
21-
#define OPEN_PG_TDE_SMGR_FILE_MAGIC 0x06454454 /* version ID value =
22-
* TDE 06; v6
23-
* authenticates
24-
* key_base_iv in the
25-
* AEAD AAD (was
26-
* excluded in v5) */
20+
#define OPEN_PG_TDE_WAL_KEY_FILE_MAGIC 0x034B4557 /* "WEK", version 3 */
21+
#define OPEN_PG_TDE_SMGR_FILE_MAGIC 0x06454454 /* "TDE", version 6 */
2722

2823
#define FILEMAGIC_VERSION(FM) ((FM & 0xF000000) >> 24)
2924
#define FILEMAGIC_TYPE(FM) ((FM & 0x0FFFFFF))

0 commit comments

Comments
 (0)