Delay traffic spawn until after session start (#92)

Author: thisguyStan

AssettoServer.Shared/Network/Packets/Shared/CSPAdminPenalty.cs

@@ -10,7 +10,7 @@ public class CSPAdminPenalty : IIncomingNetworkPacket, IOutgoingNetworkPacket
     public CSPAdminPenaltyMode Mode;
     public ushort CarIndex;
     public int PenaltyArgument;
-    public string Message;
+    public string Message = "";
     public ulong Signature;
 
     public void FromReader(PacketReader reader)

AssettoServer/Server/Ai/AiBehavior.cs

@@ -65,6 +65,8 @@ public AiBehavior(SessionManager sessionManager,
 
         _entryCarManager.ClientDisconnected += OnClientDisconnected;
         _configuration.Extra.AiParams.PropertyChanged += (_, _) => AdjustOverbooking();
+
+        _sessionManager.SessionChanged += OnSessionChanged;
     }
 
     private static void OnCollision(ACTcpClient sender, CollisionEventArgs args)
@@ -202,6 +204,9 @@ private void Update()
 
         _aiStateCountMetric.Set(_initializedAiStates.Count);
 
+        if (_sessionManager.CurrentSession.StartTimeMilliseconds > _sessionManager.ServerTimeMilliseconds)
+            return;
+
         for (int i = 0; i < _initializedAiStates.Count; i++)
         {
             _aiMinDistanceToPlayer.Add(new KeyValuePair<AiState, float>(_initializedAiStates[i], float.MaxValue));
@@ -350,6 +355,14 @@ private void OnClientDisconnected(ACTcpClient sender, EventArgs args)
         }
     }
 
+    private void OnSessionChanged(SessionManager sender, SessionChangedEventArgs args)
+    {
+        for (var i = 0; i < _initializedAiStates.Count; i++)
+        {
+            _initializedAiStates[i].Despawn();
+        }
+    }
+
     private int GetRandomWeighted(int max)
     {
         // Probabilities for max = 4

AssettoServer/Server/Configuration/Kunos/CarSetups.cs

@@ -15,8 +15,8 @@ public class CarSetups
     [UsedImplicitly(ImplicitUseKindFlags.Assign, ImplicitUseTargetFlags.WithMembers)]
     public class CarSetup
     {
-        [IniField("CAR", "MODEL")] public string CarModel { get; init; }
-        [IniField("__EXT_PATCH", "VERSION")] public string CspVersion { get; init; }
+        [IniField("CAR", "MODEL")] public string? CarModel { get; init; }
+        [IniField("__EXT_PATCH", "VERSION")] public string? CspVersion { get; init; }
         public Dictionary<string, float> Settings { get; init; } = new();
     }
 

AssettoServer/Server/SessionManager.cs

@@ -144,7 +144,7 @@ public bool OnLapCompleted(ACTcpClient client, LapCompletedIncoming lap)
             return false;
         }
 
-        Log.Information("Lap completed by {ClientName}, {NumCuts} cuts, laptime {LapTime}", client.Name, lap.Cuts, lap.LapTime);
+        Log.Information("Lap completed by {ClientName}, {NumCuts} cuts, laptime {LapTime}", client.Name, lap.Cuts, TimeSpan.FromMilliseconds(lap.LapTime).ToString(@"mm\:ss\.ffff"));
 
         if (CurrentSession.Configuration.Type == SessionType.Race || lap.Cuts == 0)
         {