Conversation
Implement conda plugin hooks for conda-lock.
✅ Deploy Preview for conda-lock ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Add entry point for conda-lock plugin in pyproject.toml
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Ah maybe this was never meant to be a subcommand since @maresb @mariusvniekerk what is the history on |
|
Hey @beckermr! Also, I'm not sure what's up with the CI, but I noticed similar failures last night, so I think it's unrelated to your PR. I'll try to investigate soon. |
|
OK. If we merge this PR, then we have to permanently add conda as a dependency of conda-lock. Is that OK? |
No, that would break the current pip-installability of conda-lock. Does the entry-point actually require |
|
It currently needs this import |
|
I'll need to add tests here. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Any hints on the |
|
Let's use |
I am a complete n00b at typing so this might be crazy.
|
LOL that broke mypy 🤦 |
|
LGTM, I just need to fix the broken CI. Thanks @beckermr! |
|
xref: regro/cf-scripts#5889 for the python-build failure |
|
This needs integration tests to ensure the |
|
We need to remove all of the logging.basicConfig calls in order for the plugin to work properly with conda. see conda/conda#15872 |
Oof, that sounds like a pain. Probably something for a separate PR. Maybe I can get an agent to sort it out. |
|
Not too bad. I just did this for smithy. I will push it here. |
Added a basic logger configuration function to set up logging.
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
Looks great @beckermr! Are you still working on this? |
|
Yes! Let me add a todo list at the top. |
|
OK @maresb! This one is ready for review! |
|
This approach is causing duplicate log messages in smithy. I am going to try a fix there and then update this PR if that works. |
|
ok @maresb - This is ready for review again. The PR is a lot simpler now. |
maresb
left a comment
maresb
left a comment
There was a problem hiding this comment.
Sorry it took me a while to review this.
Beautiful simplification with the logging!
My main concern is how this increases the total number of integration test jobs from 18 to 44. I have the impression that some type of API limits cause runner allocation to stall, especially for the macos runners. Thus I'm worried that this increase could lead to major bottlenecks for how long it takes the conda-lock CI to complete.
Would it be sufficient to add a separate job that installs Conda and runs something trivial like conda lock --help to revert the matrix expansion?
| exclude: | ||
| - os: windows-latest | ||
| python-version: "3.14" | ||
| use_conda_cli: "true" |
There was a problem hiding this comment.
Why this exclude? Does setup-miniconda not work yet with python 3.14? Could we add a comment explaining why?
| cat conda-lock.yml | ||
| mkdir lockfiles | ||
| mv conda-$CONDA_PLATFORM.lock conda-$CONDA_PLATFORM.lock.yml conda-lock.yml lockfiles | ||
| - name: Set up Python |
There was a problem hiding this comment.
| - name: Set up Python | |
| - name: Set up Conda |
2 participants
Description
The latest conda versions switched to plugin hooks for custom subcommands (e.g.,
conda lock) and as of conda 26.3, the old interface was deprecated. This PR adds the proper plugin hooks.To Do:
closes #904