Skip to content

Commit 0e827a3

Browse files
slack include sensitive (#83)
1 parent 13b3932 commit 0e827a3

3 files changed

Lines changed: 7 additions & 4 deletions

File tree

docs/resources/integration.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,7 @@ resource "configcat_integration" "slack_integration" {
4545
name = "Slack integration"
4646
parameters = {
4747
"incoming_webhook.url" = "https://mycompany.slack.com/services/B0000000000" # The incoming webhook URL where the integration should post messages. Read more at https://api.slack.com/messaging/webhooks.
48+
"includeSensitiveData" = "true" # Set to "true" to include sensitive (hashed) comparison values. By default, the integration will mask these values in the posted messages. We recommend hiding sensitive comparison values for shared or public Slack channels. Read more at https://configcat.com/docs/targeting/targeting-rule/user-condition/#confidential-text-comparators.
4849
}
4950
}
5051

examples/resources/configcat_integration/resource.tf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@ resource "configcat_integration" "slack_integration" {
3030
name = "Slack integration"
3131
parameters = {
3232
"incoming_webhook.url" = "https://mycompany.slack.com/services/B0000000000" # The incoming webhook URL where the integration should post messages. Read more at https://api.slack.com/messaging/webhooks.
33+
"includeSensitiveData" = "true" # Set to "true" to include sensitive (hashed) comparison values. By default, the integration will mask these values in the posted messages. We recommend hiding sensitive comparison values for shared or public Slack channels. Read more at https://configcat.com/docs/targeting/targeting-rule/user-condition/#confidential-text-comparators.
3334
}
3435
}
3536

internal/configcat/integration_resource_test.go

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -524,6 +524,7 @@ func TestAccIntegrationSlackResource(t *testing.T) {
524524
resource.TestCheckResourceAttr(testResourceName, IntegrationParameters+".incoming_webhook.url", "https://test.slack.com/hook"),
525525
resource.TestCheckResourceAttr(testResourceName, IntegrationConfigs+".#", "0"),
526526
resource.TestCheckResourceAttr(testResourceName, IntegrationEnvironments+".#", "0"),
527+
resource.TestCheckNoResourceAttr(testResourceName, IntegrationParameters+".includeSensitiveData"),
527528
),
528529
},
529530
{
@@ -548,13 +549,15 @@ func TestAccIntegrationSlackResource(t *testing.T) {
548549
"name": config.StringVariable(integrationType + "_integ2"),
549550
"parameters": config.MapVariable(map[string]config.Variable{
550551
"incoming_webhook.url": config.StringVariable("https://test.slack.com/hook2"),
552+
"includeSensitiveData": config.StringVariable("true"),
551553
}),
552554
},
553555
Check: resource.ComposeAggregateTestCheckFunc(
554556
resource.TestCheckResourceAttrSet(testResourceName, ID),
555557
resource.TestCheckResourceAttr(testResourceName, Name, integrationType+"_integ2"),
556558
resource.TestCheckResourceAttr(testResourceName, IntegrationType, integrationType),
557559
resource.TestCheckResourceAttr(testResourceName, IntegrationParameters+".incoming_webhook.url", "https://test.slack.com/hook2"),
560+
resource.TestCheckResourceAttr(testResourceName, IntegrationParameters+".includeSensitiveData", "true"),
558561
resource.TestCheckResourceAttr(testResourceName, IntegrationConfigs+".#", "0"),
559562
resource.TestCheckResourceAttr(testResourceName, IntegrationEnvironments+".#", "0"),
560563
),
@@ -566,10 +569,8 @@ func TestAccIntegrationSlackResource(t *testing.T) {
566569
"integration_type": config.StringVariable(integrationType),
567570
"name": config.StringVariable(integrationType + "_integ"),
568571
"parameters": config.MapVariable(map[string]config.Variable{
569-
"serviceAccountUserName": config.StringVariable("serviceAccountUserName2"),
570-
"serviceAccountSecret": config.StringVariable("serviceAccountSecret2"),
571-
"projectId": config.StringVariable("projectId2"),
572-
"server": config.StringVariable("EUResidencyServer"),
572+
"incoming_webhook.url": config.StringVariable("https://test.slack.com/hook2"),
573+
"includeSensitiveData": config.StringVariable("true"),
573574
}),
574575
},
575576
ResourceName: testResourceName,

0 commit comments

Comments
 (0)