chore(release): v0.0.12

Author: rxbn

Makefile

@@ -3,7 +3,7 @@
 # To re-generate a bundle for another specific version without changing the standard setup, you can:
 # - use the VERSION as arg of the bundle target (e.g make bundle VERSION=0.0.3)
 # - use environment variables to overwrite this value (e.g export VERSION=0.0.3)
-VERSION ?= 0.0.11
+VERSION ?= 0.0.12
 
 # CHANNELS define the bundle channels used in the bundle.
 # Add a new line here if you would like to change its default config. (E.g CHANNELS = "candidate,fast,stable")

README.md

@@ -18,8 +18,8 @@ Assisted Installer `Agent` objects can appear.
   needed.
 - Optionally approves matching Assisted Installer `Agent` objects.
 - Deletes only owned VMs and stale unbound Agents when scale-down is allowed.
-- Supports dry-run mode, status conditions, planned actions, and Kubernetes
-  Events for operational visibility.
+- Reports status conditions, planned actions, and Kubernetes Events for
+  operational visibility.
 
 ## Current Scope
 
@@ -49,7 +49,7 @@ flowchart TD
     reconcile --> fresh["Read latest VsphereAgentPool\nthrough uncached API reader"]
     fresh --> discover["Resolve inputs\nAgentMachines, Machines, InfraEnv, matching Agents, owned/adopted VMs"]
     discover --> refresh["Refresh ownedVMs status\nProvisioning, Available, Bound, Released"]
-    refresh --> plan["Build plan\nAgentMachine count, waiting demand, buffer, available Agents, provisioning VMs"]
+    refresh --> plan["Build plan\nAgentMachine count, waiting demand, available Agents, provisioning VMs"]
 
     plan -->|deficit| iso["Ensure content-addressed ISO cache\nDownload, hash, upload if changed"]
     iso --> create["Create vSphere VM\nfolder, datastore cluster, network, CPU, memory, disk, ISO"]
@@ -73,7 +73,7 @@ flowchart TD
 
     plan -->|surplus available owned Agent| surplus{"Any AgentMachine\nstill without an Agent?"}
     surplus -->|yes| wait
-    surplus -->|no| deletefree["Delete extra unbound VM and Agent\nrespect bufferAgents"]
+    surplus -->|no| deletefree["Delete extra unbound VM and Agent"]
     deletefree --> agents
 
     plan -->|no changes| noop["Noop\nstatus and conditions only"]
@@ -91,15 +91,16 @@ At the beginning of each reconcile, the controller reads the
 based on the latest recorded `ownedVMs` status instead of stale informer state.
 
 Scale-up is demand driven. The controller counts `AgentMachine` objects for the
-NodePool that report `Ready=False` with `Reason=NoSuitableAgents`, adds
-`spec.scaling.bufferAgents`, subtracts available matching Agents and
-already-provisioning owned VMs, then creates at most
-`spec.scaling.maxProvisioning` VMs per reconcile. Each VM boots the active
-InfraEnv ISO. The controller records the vSphere BIOS UUID, instance UUID, and
-primary MAC address immediately after VM creation. When the Agent appears, it is
-matched to the owned VM by BIOS UUID or MAC before any hostname fallback. The
-controller then applies the configured labels, role, approval, and VM-name
-hostname so the Agent CAPI provider can bind it to a Machine.
+NodePool that report `Ready=False` with `Reason=NoSuitableAgents`, subtracts
+available matching Agents and already-provisioning owned VMs, and records the
+remaining demand in status. The AgentMachine controller creates a
+`VsphereAgent` for each waiting AgentMachine; each `VsphereAgent` then creates a
+vSphere VM that boots the active InfraEnv ISO. The controller records the
+vSphere BIOS UUID, instance UUID, and primary MAC address immediately after VM
+creation. When the Agent appears, it is matched to the owned VM by BIOS UUID or
+MAC before any hostname fallback. The controller then applies the configured
+labels, role, approval, and VM-name hostname so the Agent CAPI provider can bind
+it to a Machine.
 
 Existing clusters are adopted through Agents. If a matching Agent already
 exists, the controller records it in `status.ownedVMs` using the Agent hostname,
@@ -123,15 +124,15 @@ stale Agent can still be removed.
 Install the latest release manifests:
 
 ```sh
-kubectl apply -f https://github.com/containeroo/agent-forge-operator/releases/download/v0.0.11/crds.yaml
-kubectl apply -k github.com/containeroo/agent-forge-operator//config/default?ref=v0.0.11
+kubectl apply -f https://github.com/containeroo/agent-forge-operator/releases/download/v0.0.12/crds.yaml
+kubectl apply -k github.com/containeroo/agent-forge-operator//config/default?ref=v0.0.12
 ```
 
 The published manager images are:
 
 ```text
-ghcr.io/containeroo/agent-forge-operator:v0.0.11
-containeroo/agent-forge-operator:v0.0.11
+ghcr.io/containeroo/agent-forge-operator:v0.0.12
+containeroo/agent-forge-operator:v0.0.12
 ```
 
 For a local image build:
@@ -144,8 +145,8 @@ make deploy IMG=<registry>/agent-forge-operator:<tag>
 ## Getting Started
 
 Start with [docs/getting-started.md](docs/getting-started.md). It covers the
-required cluster objects, vSphere Secret, a dry-run `VsphereAgentPool`, status
-inspection, and switching from dry-run to active reconciliation.
+required cluster objects, vSphere Secret, `VsphereAgentPool`, status
+inspection, and active VM reconciliation.
 
 For the complete CRD field contract and status model, see
 [docs/vsphereagentpool-crd.md](docs/vsphereagentpool-crd.md).
@@ -159,7 +160,6 @@ metadata:
   name: demo-worker
   namespace: demo
 spec:
-  dryRun: true
   hostedClusterRef:
     name: demo
   nodePoolRef:
@@ -188,10 +188,6 @@ spec:
       agentclusterinstalls.extensions.hive.openshift.io/location: lab-a
       customer: example
       hypershift.openshift.io/nodepool-role: worker
-  scaling:
-    bufferAgents: 0
-    maxProvisioning: 3
-    deletePolicy: OwnedOnly
   iso:
     checkInterval: 10m
     retainVersions: 2
@@ -240,8 +236,8 @@ The controller uses `govc` for vSphere operations. The container image includes
 Releases are built by GoReleaser from pushed tags:
 
 ```sh
-git tag v0.0.11
-git push origin v0.0.11
+git tag v0.0.12
+git push origin v0.0.12
 ```
 
 The release workflow publishes multi-architecture images to GHCR and DockerHub

api/v1alpha1/vsphereagentpool_types.go

@@ -154,34 +154,6 @@ type AgentBindingSpec struct {
 	Approve *bool `json:"approve,omitempty"`
 }
 
-// ScalingPolicySpec contains bridge-side guardrails. It does not replace the
-// hosted cluster autoscaler; AgentMachine demand remains the source of truth
-// for desired node count.
-type ScalingPolicySpec struct {
-	// BufferAgents is the number of extra matching, unbound Agents to keep
-	// available beyond current AgentMachine demand. Use 0 for strict cost
-	// control.
-	// +kubebuilder:validation:Minimum=0
-	// +kubebuilder:default=0
-	// +optional
-	BufferAgents int32 `json:"bufferAgents,omitempty"`
-
-	// MaxProvisioning limits how many VMs this operator creates in one
-	// reconciliation. It throttles large autoscaler jumps to protect vSphere,
-	// DHCP, storage, and Assisted Installer.
-	// +kubebuilder:validation:Minimum=1
-	// +kubebuilder:default=3
-	// +optional
-	MaxProvisioning int32 `json:"maxProvisioning,omitempty"`
-
-	// DeletePolicy controls scale-down cleanup. OwnedOnly means only VMs
-	// recorded in this object's status are destroyed. Retain never destroys VMs.
-	// +kubebuilder:validation:Enum=OwnedOnly;Retain
-	// +kubebuilder:default=OwnedOnly
-	// +optional
-	DeletePolicy string `json:"deletePolicy,omitempty"`
-}
-
 // ISOCacheSpec controls how the InfraEnv discovery ISO is cached in vSphere.
 type ISOCacheSpec struct {
 	// CheckInterval controls how often the operator downloads and hashes the
@@ -221,13 +193,6 @@ type VsphereAgentPoolSpec struct {
 	// +kubebuilder:validation:MinLength=1
 	ControlPlaneNamespace string `json:"controlPlaneNamespace"`
 
-	// DryRun makes the operator compute and report actions without creating,
-	// patching, or deleting VMs/Agents. This is the recommended first mode for a
-	// new hosted cluster.
-	// +kubebuilder:default=true
-	// +optional
-	DryRun bool `json:"dryRun"`
-
 	// VSphere configures placement and VM platform settings.
 	VSphere VspherePlacementSpec `json:"vsphere"`
 
@@ -237,10 +202,6 @@ type VsphereAgentPoolSpec struct {
 	// Agent configures Agent labels, hostname assignment, and approval.
 	Agent AgentBindingSpec `json:"agent"`
 
-	// Scaling configures bridge-side buffering, throttling, and deletion safety.
-	// +optional
-	Scaling ScalingPolicySpec `json:"scaling,omitempty"`
-
 	// ISO configures content-addressed caching of the InfraEnv discovery ISO.
 	// +optional
 	ISO ISOCacheSpec `json:"iso,omitempty"`
@@ -294,9 +255,6 @@ type PlannedActionStatus struct {
 
 	// Reason explains why the action is needed.
 	Reason string `json:"reason"`
-
-	// DryRun is true when the action was only reported.
-	DryRun bool `json:"dryRun"`
 }
 
 // ISOCacheHistoryEntry records one uploaded content-addressed ISO object.
@@ -359,8 +317,7 @@ type VsphereAgentPoolStatus struct {
 	// +optional
 	ObservedGeneration int64 `json:"observedGeneration,omitempty"`
 
-	// DesiredReplicas is the observed AgentMachine count plus any configured
-	// buffer.
+	// DesiredReplicas is the observed AgentMachine count.
 	// +optional
 	DesiredReplicas int32 `json:"desiredReplicas,omitempty"`
 
@@ -410,7 +367,7 @@ type VsphereAgentPoolStatus struct {
 	// +optional
 	ISO ISOCacheStatus `json:"iso,omitempty"`
 
-	// Conditions summarizes readiness, dry-run state, discovery, and errors.
+	// Conditions summarizes readiness, discovery, and errors.
 	// +patchMergeKey=type
 	// +patchStrategy=merge
 	// +listType=map
@@ -425,7 +382,6 @@ type VsphereAgentPoolStatus struct {
 // +kubebuilder:printcolumn:name="Waiting",type=integer,JSONPath=`.status.waitingAgentMachines`
 // +kubebuilder:printcolumn:name="Desired",type=integer,JSONPath=`.status.desiredReplicas`
 // +kubebuilder:printcolumn:name="Agents",type=integer,JSONPath=`.status.matchingAgents`
-// +kubebuilder:printcolumn:name="DryRun",type=boolean,JSONPath=`.spec.dryRun`
 // +kubebuilder:printcolumn:name="Age",type=date,JSONPath=`.metadata.creationTimestamp`
 
 // VsphereAgentPool is a namespace-scoped bridge between a Hypershift Agent

api/v1alpha1/vsphereagentpool_types_test.go

@@ -26,9 +26,6 @@ spec:
     - jsonPath: .status.matchingAgents
       name: Agents
       type: integer
-    - jsonPath: .spec.dryRun
-      name: DryRun
-      type: boolean
     - jsonPath: .metadata.creationTimestamp
       name: Age
       type: date
@@ -97,13 +94,6 @@ spec:
                   example demo-demo.
                 minLength: 1
                 type: string
-              dryRun:
-                default: true
-                description: |-
-                  DryRun makes the operator compute and report actions without creating,
-                  patching, or deleting VMs/Agents. This is the recommended first mode for a
-                  new hosted cluster.
-                type: boolean
               hostedClusterRef:
                 description: HostedClusterRef references the Hypershift HostedCluster
                   this pool serves.
@@ -162,38 +152,6 @@ spec:
                 required:
                 - name
                 type: object
-              scaling:
-                description: Scaling configures bridge-side buffering, throttling,
-                  and deletion safety.
-                properties:
-                  bufferAgents:
-                    default: 0
-                    description: |-
-                      BufferAgents is the number of extra matching, unbound Agents to keep
-                      available beyond current AgentMachine demand. Use 0 for strict cost
-                      control.
-                    format: int32
-                    minimum: 0
-                    type: integer
-                  deletePolicy:
-                    default: OwnedOnly
-                    description: |-
-                      DeletePolicy controls scale-down cleanup. OwnedOnly means only VMs
-                      recorded in this object's status are destroyed. Retain never destroys VMs.
-                    enum:
-                    - OwnedOnly
-                    - Retain
-                    type: string
-                  maxProvisioning:
-                    default: 3
-                    description: |-
-                      MaxProvisioning limits how many VMs this operator creates in one
-                      reconciliation. It throttles large autoscaler jumps to protect vSphere,
-                      DHCP, storage, and Assisted Installer.
-                    format: int32
-                    minimum: 1
-                    type: integer
-                type: object
               template:
                 description: Template configures the worker VM hardware profile.
                 properties:
@@ -350,8 +308,7 @@ spec:
                 format: int32
                 type: integer
               conditions:
-                description: Conditions summarizes readiness, dry-run state, discovery,
-                  and errors.
+                description: Conditions summarizes readiness, discovery, and errors.
                 items:
                   description: Condition contains details for one aspect of the current
                     state of this API Resource.
@@ -411,9 +368,7 @@ spec:
                 - type
                 x-kubernetes-list-type: map
               desiredReplicas:
-                description: |-
-                  DesiredReplicas is the observed AgentMachine count plus any configured
-                  buffer.
+                description: DesiredReplicas is the observed AgentMachine count.
                 format: int32
                 type: integer
               iso:
@@ -613,9 +568,6 @@ spec:
                     PlannedActionStatus records the latest create/delete/patch actions the
                     operator planned or executed.
                   properties:
-                    dryRun:
-                      description: DryRun is true when the action was only reported.
-                      type: boolean
                     name:
                       description: Name is the target VM or Agent name when known.
                       type: string
@@ -628,7 +580,6 @@ spec:
                         PatchAgent, or Noop.
                       type: string
                   required:
-                  - dryRun
                   - reason
                   - type
                   type: object

api/v1alpha1/zz_generated.deepcopy.go

@@ -36,7 +36,7 @@ resources:
 images:
   - name: controller
     newName: ghcr.io/containeroo/agent-forge-operator
-    newTag: v0.0.11
+    newTag: v0.0.12
 
 # Uncomment the patches line if you enable Metrics
 patches: