task: remove notification wrapper in authcomponents

Author: YottaYocta

frontend/src/components/AuthManager/AuthManager.tsx

@@ -106,7 +106,9 @@ const AuthManager = () => {
   // This is now primarily a fallback for environments where server-side
   // sessions are same-site (e.g., local development). In production, we
   // prefer the stateless JWT passed via the URL query parameter.
-  const handleSSOCallback = async (event?: React.FormEvent<HTMLFormElement>) => {
+  const handleSSOCallback = async (
+    event?: React.FormEvent<HTMLFormElement>
+  ) => {
     try {
       const response = await fetch(
         `${import.meta.env.VITE_SERVER_URL}/api/sso/profile`,
@@ -354,29 +356,27 @@ const AuthManager = () => {
           document.body
         )}
       <AuthContext.Provider value={{ logout, id, user, refreshUser }}>
-        <SubscribeWrapper userId={id}>
-          <Routes>
-            <Route path="/admin/*" element={<AdminRoutes />} />
-            <Route path="/rider/*" element={<RiderRoutes />} />
-            <Route path="/driver/*" element={<DriverRoutes />} />
-            <Route
-              path="/"
-              element={
-                <Navigate
-                  to={
-                    localStorage.getItem('userType') === 'Admin'
-                      ? '/admin/home'
-                      : localStorage.getItem('userType') === 'Driver'
-                      ? '/driver/rides'
-                      : '/rider/schedule'
-                  }
-                  replace
-                />
-              }
-            />
-            <Route path="*" element={<Navigate to="/" replace />} />
-          </Routes>
-        </SubscribeWrapper>
+        <Routes>
+          <Route path="/admin/*" element={<AdminRoutes />} />
+          <Route path="/rider/*" element={<RiderRoutes />} />
+          <Route path="/driver/*" element={<DriverRoutes />} />
+          <Route
+            path="/"
+            element={
+              <Navigate
+                to={
+                  localStorage.getItem('userType') === 'Admin'
+                    ? '/admin/home'
+                    : localStorage.getItem('userType') === 'Driver'
+                    ? '/driver/rides'
+                    : '/rider/schedule'
+                }
+                replace
+              />
+            }
+          />
+          <Route path="*" element={<Navigate to="/" replace />} />
+        </Routes>
       </AuthContext.Provider>
     </>
   );

server/src/router/rider.ts

@@ -6,7 +6,12 @@ import * as db from './common';
 import { Rider } from '../models/rider';
 import { RiderType } from '@carriage-web/shared/types/rider';
 import { Location } from '../models/location';
-import { createKeys, validateUser, checkNetIDExists, checkNetIDExistsForOtherEmployee } from '../util';
+import {
+  createKeys,
+  validateUser,
+  checkNetIDExists,
+  checkNetIDExistsForOtherEmployee,
+} from '../util';
 import { Ride } from '../models/ride';
 import { RideType, Type, Status } from '@carriage-web/shared/types/ride';
 import { UserType } from '../models/subscription';
@@ -19,6 +24,7 @@ router.get('/usage', validateUser('Admin'), (req, res) => {
     noShows: number;
     totalRides: number;
   };
+
   type Usage = {
     [id: string]: UsageData;
   };
@@ -199,7 +205,7 @@ router.post('/', validateUser('Admin'), async (req, res) => {
     const emailExists = await checkNetIDExists(body.email, 'rider');
     if (emailExists) {
       return res.status(409).send({
-        err: 'A user with this NetID already exists'
+        err: 'A user with this NetID already exists',
       });
     }
 
@@ -225,10 +231,13 @@ router.put('/:id', validateUser('Rider'), async (req, res) => {
 
     // Check if email is being changed and if it conflicts with another user
     if (body.email) {
-      const emailExists = await checkNetIDExistsForOtherEmployee(body.email, id);
+      const emailExists = await checkNetIDExistsForOtherEmployee(
+        body.email,
+        id
+      );
       if (emailExists) {
         return res.status(409).send({
-          err: 'A user with this NetID already exists'
+          err: 'A user with this NetID already exists',
         });
       }
     }