You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, all of 3C's calls to Rewriter::ReplaceText go through a wrapper function named rewriteSourceRange, which (currently) adds two features: (1) better handling of certain edge cases involving macros and (2) failure reporting as diagnostics. However, 3C has several features that call the Rewriter::InsertText* methods directly, since we don't yet have analogous wrappers for them:
Base variable addition for range bounds (being added in Lower Bounds Inference #718; currently defines its own insertText wrapper that works in a hacky way, which may change)
We should define and use proper Rewriter::InsertText* wrappers. Even if we don't care about the macro edge cases, it's important to ensure that failures are reported appropriately. Currently, some of the call sites assert on failure while others silently ignore it. (Failure may be impossible at some of those call sites anyway due to checks previously performed by 3C, but that may not be obvious by reading the code, and we might unintentionally break things in the future.)
A simple example of what can currently go wrong with checked region addition:
3c -addcr reports no errors or warnings but generates syntactically invalid output when it inserts the opening brace but silently fails to insert the closing brace or vice versa:
Currently, all of 3C's calls to
Rewriter::ReplaceTextgo through a wrapper function namedrewriteSourceRange, which (currently) adds two features: (1) better handling of certain edge cases involving macros and (2) failure reporting as diagnostics. However, 3C has several features that call theRewriter::InsertText*methods directly, since we don't yet have analogous wrappers for them:-addcr)insertTextwrapper that works in a hacky way, which may change)We should define and use proper
Rewriter::InsertText*wrappers. Even if we don't care about the macro edge cases, it's important to ensure that failures are reported appropriately. Currently, some of the call sites assert on failure while others silently ignore it. (Failure may be impossible at some of those call sites anyway due to checks previously performed by 3C, but that may not be obvious by reading the code, and we might unintentionally break things in the future.)A simple example of what can currently go wrong with checked region addition:
3c -addcrreports no errors or warnings but generates syntactically invalid output when it inserts the opening brace but silently fails to insert the closing brace or vice versa: