bugfix: filter duplicate detection to open issues only

Author: cowwoc

.cat/issues/v2/v2.1/fix-add-agent-duplicate-detection-open-only/index.json

@@ -1,5 +1,7 @@
 {
-  "status": "open",
+  "status": "closed",
+  "resolution": "implemented",
+  "target_branch": "v2.1",
   "dependencies": [],
   "blocks": []
 }

.cat/issues/v2/v2.1/remove-unnecessary-suppress-try-annotations/index.json

@@ -0,0 +1,3 @@
+{
+  "status" : "open"
+}

.cat/issues/v2/v2.1/remove-unnecessary-suppress-try-annotations/plan.md

@@ -0,0 +1,20 @@
+# Plan
+
+## Goal
+
+Remove unnecessary @SuppressWarnings("try") annotations from test methods that don't explicitly call scope.close() inside try-with-resources blocks. The suppression is only needed when close() is called explicitly inside a try-with-resources block (to suppress the "already auto-closed" compiler warning). Methods that simply use the scope normally in try-with-resources don't generate this warning and don't need the annotation.
+
+## Type
+
+refactor
+
+## Pre-conditions
+
+- [ ] All dependent issues are closed
+
+## Post-conditions
+
+- [ ] User-visible behavior unchanged
+- [ ] Tests passing — all tests compile and pass after annotation removal
+- [ ] Code quality improved — unnecessary @SuppressWarnings("try") annotations removed
+- [ ] E2E verification — full test suite passes (mvn verify) after changes

client/src/main/java/io/github/cowwoc/cat/hooks/skills/GetAddOutput.java

@@ -19,7 +19,7 @@
 import java.io.IOException;
 import java.io.PrintStream;
 
-import static io.github.cowwoc.cat.hooks.Strings.block;
+import java.nio.file.DirectoryStream;
 import java.nio.file.Files;
 import java.nio.file.Path;
 import java.util.ArrayList;
@@ -28,6 +28,7 @@
 import java.util.Objects;
 import java.util.stream.Stream;
 
+import static io.github.cowwoc.cat.hooks.Strings.block;
 import static io.github.cowwoc.requirements13.java.DefaultJavaValidators.requireThat;
 
 /**
@@ -215,15 +216,42 @@ private VersionData readVersionData(Path versionDir) throws IOException
       summary = parseGoalSummary(planContent);
     }
 
-    try (Stream<Path> entries = Files.list(versionDir))
+    List<String> existingIssues = new ArrayList<>();
+    List<Path> issueDirs = new ArrayList<>();
+    try (DirectoryStream<Path> entries = Files.newDirectoryStream(versionDir))
     {
-      List<String> existingIssues = entries.
-        filter(Files::isDirectory).
-        map(p -> p.getFileName().toString()).
-        sorted().
-        toList();
-      return new VersionData(version, status, summary, existingIssues);
+      for (Path entry : entries)
+      {
+        if (Files.isDirectory(entry))
+          issueDirs.add(entry);
+      }
+    }
+    for (Path issueDir : issueDirs)
+    {
+      if (isOpenIssue(issueDir))
+        existingIssues.add(issueDir.getFileName().toString());
     }
+    return new VersionData(version, status, summary, existingIssues);
+  }
+
+  /**
+   * Returns true if the issue directory has an {@code index.json} with {@code "status": "open"}.
+   * Directories without an {@code index.json}, or with any other status, are not open issues.
+   *
+   * @param issueDir the candidate issue directory
+   * @return true if the issue is open
+   * @throws IOException if an I/O error occurs reading the index.json
+   */
+  private boolean isOpenIssue(Path issueDir) throws IOException
+  {
+    Path indexJson = issueDir.resolve("index.json");
+    if (Files.notExists(indexJson))
+      return false;
+    JsonNode indexNode = scope.getJsonMapper().readTree(indexJson.toFile());
+    JsonNode statusNode = indexNode.get("status");
+    if (statusNode == null || !statusNode.isString())
+      return false;
+    return statusNode.asString().equals("open");
   }
 
   /**

client/src/test/java/io/github/cowwoc/cat/hooks/test/GetAddOutputPlanningDataTest.java

@@ -14,6 +14,7 @@
 import java.io.IOException;
 import java.nio.file.Files;
 import java.nio.file.Path;
+import java.util.List;
 
 import static io.github.cowwoc.requirements13.java.DefaultJavaValidators.requireThat;
 
@@ -100,7 +101,10 @@ public void inProgressVersionIsIncluded() throws IOException
         {"status":"in-progress"}""");
       Files.writeString(versionDir.resolve("plan.md"),
         "# Plan\n\n## Goal\n\nTest version goal summary.\n");
-      Files.createDirectories(versionDir.resolve("my-issue"));
+      Path myIssueDir = versionDir.resolve("my-issue");
+      Files.createDirectories(myIssueDir);
+      Files.writeString(myIssueDir.resolve("index.json"), """
+        {"status":"open"}""");
 
       GetAddOutput handler = new GetAddOutput(scope);
       String result = handler.getOutput(new String[0]);
@@ -323,7 +327,10 @@ public void regularFilesNotListedAsIssues() throws IOException
       Files.writeString(versionDir.resolve("plan.md"), "# Plan\n\n## Goal\n\nGoal.\n");
       Files.writeString(versionDir.resolve("CHANGELOG.md"), "# Changelog\n");
       Files.writeString(versionDir.resolve("notes.txt"), "some notes");
-      Files.createDirectories(versionDir.resolve("real-issue"));
+      Path realIssueDir = versionDir.resolve("real-issue");
+      Files.createDirectories(realIssueDir);
+      Files.writeString(realIssueDir.resolve("index.json"), """
+        {"status":"open"}""");
 
       GetAddOutput handler = new GetAddOutput(scope);
       String result = handler.getOutput(new String[0]);
@@ -354,8 +361,14 @@ public void issueNamesWithSpecialCharactersListed() throws IOException
       Files.createDirectories(versionDir);
       Files.writeString(versionDir.resolve("index.json"), """
         {"status":"open"}""");
-      Files.createDirectories(versionDir.resolve("fix-bug-123"));
-      Files.createDirectories(versionDir.resolve("add-feature-abc"));
+      Path fixBugDir = versionDir.resolve("fix-bug-123");
+      Files.createDirectories(fixBugDir);
+      Files.writeString(fixBugDir.resolve("index.json"), """
+        {"status":"open"}""");
+      Path addFeatureDir = versionDir.resolve("add-feature-abc");
+      Files.createDirectories(addFeatureDir);
+      Files.writeString(addFeatureDir.resolve("index.json"), """
+        {"status":"open"}""");
 
       GetAddOutput handler = new GetAddOutput(scope);
       String result = handler.getOutput(new String[0]);
@@ -388,9 +401,13 @@ public void issueCountEqualsExistingIssuesSize() throws IOException
       Files.createDirectories(versionDir);
       Files.writeString(versionDir.resolve("index.json"), """
         {"status":"open"}""");
-      Files.createDirectories(versionDir.resolve("issue-a"));
-      Files.createDirectories(versionDir.resolve("issue-b"));
-      Files.createDirectories(versionDir.resolve("issue-c"));
+      for (String issueName : List.of("issue-a", "issue-b", "issue-c"))
+      {
+        Path issueDir = versionDir.resolve(issueName);
+        Files.createDirectories(issueDir);
+        Files.writeString(issueDir.resolve("index.json"), """
+          {"status":"open"}""");
+      }
 
       GetAddOutput handler = new GetAddOutput(scope);
       String result = handler.getOutput(new String[0]);
@@ -886,4 +903,117 @@ public void nullArgsThrowsNullPointerException() throws IOException
       handler.getOutput(null);
     }
   }
+
+  // ==================== open-only issue filtering ====================
+
+  /**
+   * Verifies that closed issues are excluded from the existing_issues list, allowing new issues with the
+   * same name to be created without a false duplicate error.
+   *
+   * @throws IOException if an I/O error occurs
+   */
+  @Test
+  @SuppressWarnings("try")
+  public void closedIssueExcludedFromExistingIssues() throws IOException
+  {
+    try (TestClaudeTool scope = new TestClaudeTool())
+    {
+      Path projectPath = scope.getProjectPath();
+      Path issuesDir = projectPath.resolve(".cat/issues");
+      Path versionDir = issuesDir.resolve("v2/v2.1");
+      Files.createDirectories(versionDir);
+      Files.writeString(versionDir.resolve("index.json"), """
+        {"status":"open"}""");
+
+      Path closedIssueDir = versionDir.resolve("fix-bug");
+      Files.createDirectories(closedIssueDir);
+      Files.writeString(closedIssueDir.resolve("index.json"), """
+        {"status":"closed","resolution":"implemented"}""");
+
+      GetAddOutput handler = new GetAddOutput(scope);
+      String result = handler.getOutput(new String[0]);
+
+      JsonMapper mapper = scope.getJsonMapper();
+      JsonNode version = mapper.readTree(result).get("versions").get(0);
+      JsonNode existingIssues = version.get("existing_issues");
+
+      requireThat(existingIssues.size(), "existing_issues.size").isEqualTo(0);
+      requireThat(version.get("issue_count").asInt(), "issue_count").isEqualTo(0);
+    }
+  }
+
+  /**
+   * Verifies that open issues are included and closed issues are excluded from existing_issues.
+   *
+   * @throws IOException if an I/O error occurs
+   */
+  @Test
+  @SuppressWarnings("try")
+  public void openIssueIncludedClosedIssueExcluded() throws IOException
+  {
+    try (TestClaudeTool scope = new TestClaudeTool())
+    {
+      Path projectPath = scope.getProjectPath();
+      Path issuesDir = projectPath.resolve(".cat/issues");
+      Path versionDir = issuesDir.resolve("v2/v2.1");
+      Files.createDirectories(versionDir);
+      Files.writeString(versionDir.resolve("index.json"), """
+        {"status":"open"}""");
+
+      Path openIssueDir = versionDir.resolve("new-feature");
+      Files.createDirectories(openIssueDir);
+      Files.writeString(openIssueDir.resolve("index.json"), """
+        {"status":"open"}""");
+
+      Path closedIssueDir = versionDir.resolve("fix-bug");
+      Files.createDirectories(closedIssueDir);
+      Files.writeString(closedIssueDir.resolve("index.json"), """
+        {"status":"closed","resolution":"implemented"}""");
+
+      GetAddOutput handler = new GetAddOutput(scope);
+      String result = handler.getOutput(new String[0]);
+
+      JsonMapper mapper = scope.getJsonMapper();
+      JsonNode version = mapper.readTree(result).get("versions").get(0);
+      JsonNode existingIssues = version.get("existing_issues");
+
+      requireThat(existingIssues.size(), "existing_issues.size").isEqualTo(1);
+      requireThat(existingIssues.get(0).asString(), "existing_issues[0]").isEqualTo("new-feature");
+      requireThat(version.get("issue_count").asInt(), "issue_count").isEqualTo(1);
+    }
+  }
+
+  /**
+   * Verifies that an issue directory with no index.json is excluded from existing_issues, since its status
+   * cannot be determined as open.
+   *
+   * @throws IOException if an I/O error occurs
+   */
+  @Test
+  @SuppressWarnings("try")
+  public void issueWithMissingIndexJsonExcluded() throws IOException
+  {
+    try (TestClaudeTool scope = new TestClaudeTool())
+    {
+      Path projectPath = scope.getProjectPath();
+      Path issuesDir = projectPath.resolve(".cat/issues");
+      Path versionDir = issuesDir.resolve("v2/v2.1");
+      Files.createDirectories(versionDir);
+      Files.writeString(versionDir.resolve("index.json"), """
+        {"status":"open"}""");
+
+      Path noIndexIssueDir = versionDir.resolve("mystery-issue");
+      Files.createDirectories(noIndexIssueDir);
+
+      GetAddOutput handler = new GetAddOutput(scope);
+      String result = handler.getOutput(new String[0]);
+
+      JsonMapper mapper = scope.getJsonMapper();
+      JsonNode version = mapper.readTree(result).get("versions").get(0);
+      JsonNode existingIssues = version.get("existing_issues");
+
+      requireThat(existingIssues.size(), "existing_issues.size").isEqualTo(0);
+      requireThat(version.get("issue_count").asInt(), "issue_count").isEqualTo(0);
+    }
+  }
 }