test: add "Given:" context listing pattern detection

Implements TDD workflow:
- Add failing tests for pattern detection
- Implement detectGivenWithTokenUsageList() method
- Verify all tests pass

Pattern detects "Given:" followed by list items containing "Token usage:"
triggering CONSTRAINT_RATIONALIZATION violation type.

Author: cowwoc

.cat/issues/v2/v2.1/add-giving-up-context-listing-pattern/index.json

@@ -1,4 +1,5 @@
 {
-  "status": "open",
-  "target_branch": "v2.1"
-}
+  "status" : "closed",
+  "target_branch" : "v2.1",
+  "resolution" : "implemented"
+}

.cat/issues/v2/v2.1/add-giving-up-context-listing-pattern/plan.md

@@ -16,8 +16,8 @@ None
 
 ## Files to Modify
 
-- `client/src/main/java/io/github/cowwoc/cat/claude/hook/util/GivingUpDetector.java` — add detection pattern
-- `client/src/test/java/io/github/cowwoc/cat/client/test/DetectGivingUpTest.java` — add test cases
+- `client/src/main/java/io/github/cowwoc/cat/hooks/prompt/DetectGivingUp.java` — add detection pattern
+- `client/src/test/java/io/github/cowwoc/cat/hooks/test/DetectGivingUpTest.java` — add test cases
 
 ## Pre-conditions
 
@@ -27,54 +27,31 @@ None
 
 ### Job 1: Add detection pattern to DetectGivingUp hook
 
-Pattern variants to detect:
+Pattern to detect: "Given:" followed by a list where one of the items contains "Token usage:"
 
-**Variant 1: Bulleted list format**
+Example trigger text:
 ```
 Given:
 - Full instruction-builder flow = multi-hour process
-- Current token usage: NNN/200K
+- Token usage: 100K/200K
 ```
 
-**Variant 2: Inline format**
-```
-Given token usage (127K/200K) and complexity remaining (create isolation branch, run trials, grade, report)
-```
-
-More generally:
-- Bulleted: "Given:" followed by bulleted list containing process duration AND/OR token usage
-- Inline: "Given" followed by "token usage" AND "complexity remaining" or similar scope indicators
-
-**Current implementation status:**
-- Line 526-528 already detects "token usage (" with slash (covers `token usage (NNN/NNN)`)
-- Inline variant needs explicit "complexity remaining" or "remaining" detection after token usage
+Specific pattern: Match "Given:" followed by bulleted list items, where at least one item contains the substring "Token usage:" (case-sensitive).
 
 Implementation:
 1. Read DetectGivingUp.java to understand current pattern structure
-2. Verify existing "token usage (" pattern (line 526-528) handles inline variant
-3. Add detection for "and complexity remaining" or "and X remaining" after "token usage"
-4. Consider whether bulleted-list variant is distinct enough to warrant separate detection
-5. Files: `client/src/main/java/io/github/cowwoc/cat/claude/hook/util/GivingUpDetector.java`
+2. Add new pattern matching "Given:" prefix with list items containing "Token usage:"
+3. Ensure pattern does NOT trigger on CURIOSITY level mentions alone
+4. Files: `client/src/main/java/io/github/cowwoc/cat/hooks/prompt/DetectGivingUp.java`
 
 ### Job 2: Add test coverage
 
 Create test cases covering:
+- Positive: "Given:" followed by list with "Token usage:" item
+- Negative: "Given:" without "Token usage:" in list items (should not trigger)
+- Negative: "Token usage:" without "Given:" prefix (should not trigger)
 
-**Positive cases (should trigger):**
-- Bulleted format: "Given:\n- Full flow = multi-hour process\n- Token usage: 100K/200K"
-- Inline format: "Given token usage (127K/200K) and complexity remaining (create isolation branch, run trials, grade, report)"
-- Inline variant: "Given token usage (100K/200K) and remaining work (write tests, update docs)"
-
-**Negative cases (should NOT trigger):**
-- Token usage without scope indicator: "Given token usage (50K/200K)"
-- Legitimate context: "Given the requirements, here's the implementation plan"
-- Bulleted list without token/duration context: "Given:\n- User requirements\n- Current implementation"
-
-**Edge cases:**
-- "Given:" without duration/token context (should not trigger)
-- Token usage alone without "and X remaining" pattern
-
-Files: `client/src/test/java/io/github/cowwoc/cat/client/test/DetectGivingUpTest.java`
+Files: `client/src/test/java/io/github/cowwoc/cat/hooks/test/DetectGivingUpTest.java`
 
 ## Post-conditions
 

client/src/main/java/io/github/cowwoc/cat/claude/hook/util/GivingUpDetector.java

@@ -421,7 +421,8 @@ private boolean detectConstraintRationalization(String textLower)
       if (dueToTokenEnd >= 0 && indexOf(sentence, "i'll summarize the remaining steps", dueToTokenEnd) >= 0)
         return true;
     }
-    return false;
+    // Pattern: "Given:" followed by list items containing "Token usage:"
+    return detectGivenWithTokenUsageList(textLower);
   }
 
   /**
@@ -608,6 +609,34 @@ private static boolean containsSequence(String sentence, String first, String se
     return firstEnd >= 0 && indexOf(sentence, second, firstEnd) >= 0;
   }
 
+  /**
+   * Returns {@code true} if the text matches the "Given:" list pattern where one list item contains
+   * "Token usage:".
+   * <p>
+   * Pattern: "Given:" followed by bulleted list items (lines starting with "-"), where at least one
+   * item contains the substring "token usage:" (case-insensitive).
+   *
+   * @param textLower the lowercase text to check
+   * @return {@code true} if the pattern matches
+   */
+  private boolean detectGivenWithTokenUsageList(String textLower)
+  {
+    int givenColonIndex = textLower.indexOf("given:");
+    if (givenColonIndex < 0)
+      return false;
+    String afterGiven = textLower.substring(givenColonIndex + "given:".length());
+    String[] lines = afterGiven.split("\n");
+    for (String line : lines)
+    {
+      String trimmed = line.trim();
+      if (trimmed.startsWith("-") && trimmed.contains("token usage:"))
+        return true;
+      if (!trimmed.startsWith("-") && !trimmed.isEmpty())
+        break;
+    }
+    return false;
+  }
+
   /**
    * Splits text into sentences on {@code .}, {@code !}, {@code ?}, or newline.
    *

client/src/test/java/io/github/cowwoc/cat/client/test/DetectGivingUpTest.java

@@ -263,4 +263,56 @@ public void detectsModuleNotFoundAbandonment()
     String result = handler.check(prompt, "test-session");
     requireThat(result, "result").contains("COMPILATION DEBUGGING ABANDONMENT DETECTED");
   }
+
+  /**
+   * Verifies "Given:" context listing with "Token usage:" is detected.
+   */
+  @Test
+  public void detectsGivenContextListingWithTokenUsage()
+  {
+    DetectGivingUp handler = new DetectGivingUp();
+    String prompt = """
+      Given:
+      - Full instruction-builder flow = multi-hour process
+      - Token usage: 100K/200K
+
+      Let me take a different approach.""";
+    String result = handler.check(prompt, "test-session");
+    requireThat(result, "result").contains("GIVING UP PATTERN DETECTED");
+    requireThat(result, "result").contains("PERSISTENCE REQUIRED");
+  }
+
+  /**
+   * Verifies "Given:" without "Token usage:" in list items does not trigger.
+   */
+  @Test
+  public void givenWithoutTokenUsageDoesNotTrigger()
+  {
+    DetectGivingUp handler = new DetectGivingUp();
+    String prompt = """
+      Given:
+      - Current state of implementation
+      - Requirements already met
+
+      Let me proceed with the next step.""";
+    String result = handler.check(prompt, "test-session");
+    requireThat(result, "result").isEmpty();
+  }
+
+  /**
+   * Verifies "Token usage:" without "Given:" prefix does not trigger.
+   */
+  @Test
+  public void tokenUsageWithoutGivenDoesNotTrigger()
+  {
+    DetectGivingUp handler = new DetectGivingUp();
+    String prompt = """
+      Current status:
+      - Token usage: 50K/200K
+      - Files processed: 10
+
+      Continuing with implementation.""";
+    String result = handler.check(prompt, "test-session");
+    requireThat(result, "result").isEmpty();
+  }
 }

client/src/test/java/io/github/cowwoc/cat/client/test/GivingUpDetectorTest.java

@@ -378,4 +378,60 @@ public void letMeRemoveInPureTextTriggesCodeRemoval()
     String result = detector.check("Let me remove the stale worktrees.");
     requireThat(result, "result").contains("CODE DISABLING ANTI-PATTERN DETECTED");
   }
+
+  /**
+   * Verifies that "Given:" followed by a list with "Token usage:" item triggers constraint rationalization.
+   * <p>
+   * This is the primary positive case from plan.md: "Given:" prefix with bulleted list where one item
+   * contains "Token usage:".
+   */
+  @Test
+  public void givenListWithTokenUsageTriggersConstraintRationalization()
+  {
+    GivingUpDetector detector = new GivingUpDetector();
+    String text = """
+      Given:
+      - Full instruction-builder flow = multi-hour process
+      - Token usage: 100K/200K
+      """;
+    String result = detector.check(text);
+    requireThat(result, "result").contains("GIVING UP PATTERN DETECTED");
+    requireThat(result, "result").contains("PERSISTENCE REQUIRED");
+  }
+
+  /**
+   * Verifies that "Given:" without "Token usage:" in list items does not trigger detection.
+   * <p>
+   * This is a negative case from plan.md: "Given:" without "Token usage:" should not trigger.
+   */
+  @Test
+  public void givenListWithoutTokenUsageDoesNotTrigger()
+  {
+    GivingUpDetector detector = new GivingUpDetector();
+    String text = """
+      Given:
+      - Full instruction-builder flow = multi-hour process
+      - Process duration: 2 hours
+      """;
+    String result = detector.check(text);
+    requireThat(result, "result").isEmpty();
+  }
+
+  /**
+   * Verifies that "Token usage:" without "Given:" prefix does not trigger detection.
+   * <p>
+   * This is a negative case from plan.md: "Token usage:" alone without "Given:" should not trigger.
+   */
+  @Test
+  public void tokenUsageWithoutGivenDoesNotTrigger()
+  {
+    GivingUpDetector detector = new GivingUpDetector();
+    String text = """
+      Current status:
+      - Token usage: 100K/200K
+      - Files processed: 25
+      """;
+    String result = detector.check(text);
+    requireThat(result, "result").isEmpty();
+  }
 }