upstream this repo to RustCrypto

[Dustin-Ray]

The RustCrypto project is collecting many popular and widely-used elliptic curves into a central repository for ease of use and high maintainability. This issue is tracking the curves added so far. Is there any interest from this project in upstreaming the work done so far into RustCrypto?

[kevaundray]

Hey,

I am interested in upstreaming the work here into RustCrypto. What would the steps be to upstream it?

[tarcieri]

@kevaundray hey, on behalf of @RustCrypto that's great news!

We have algorithm-family based monorepos. Here is the one for elliptic curves: https://github.com/rustcrypto/elliptic-curves

I would suggest opening a PR which adds an ed448/ed448-goldilocks subdirectory containing the most recent commit of the code.

When it's merged we can get you access to the repo and work out ownership for the associated crates.

Hopefully we can also contribute trait implementations which would allow Ed448-Goldilocks to be used with algorithm implementations which are generic over elliptic curves.

[dkg]

It would be great to bring this under the @RustCrypto umbrella. Thanks for working on this.

[dignifiedquire]

@mikelodder7 I saw that you started a new fork (but issues aren't enabled, so pinging you here) would you be interested in moving that version into rustcrypto? I could help with setup, if you want

[mikelodder7]

I'd be happy to do that. where do we go from here?

[mikelodder7]

@tarcieri This is the rep. https://github.com/mikelodder7/Ed448-Goldilocks

[mikelodder7]

Do I do the same thing as I did for frodoKem

[dignifiedquire]

Generally, adding the impl as a new folder in https://github.com/RustCrypto/elliptic-curves in a PR would be the first step.
The big question to me is can we import the git history, which it seems according to https://www.simplicidade.org/notes/2009/04/21/merging-two-unrelated-repositories/ should be posssible

[mikelodder7]

I don't really care about the git history TBH. I'll PR with the latest commit from my fork.

[mikelodder7]

However, there is the issue of license. The current license is BSD-3 Clause I can change my commits to match RustCrypto, but we might have to get approval from the original owners to do the rest

[dignifiedquire]

We should probably keep the license as BSD-3, and change it once we get sign off from the original author(s).

[mikelodder7]

Hopefully we can also contribute trait implementations which would allow Ed448-Goldilocks to be used with algorithm implementations which are generic over elliptic curves.

My fork has already done this so it shouldn't be an issue.

[mikelodder7]

We should probably keep the license as BSD-3, and change it once we get sign off from the original author(s).

Consider this my sign off to change the license to APL 2.0/MIT