refactor: remove non-null assertion

crimx · crimx · commit 4d6e4fc39376 · 2026-07-26T19:29:45.000+08:00
diff --git a/src/selection/message.ts b/src/selection/message.ts
@@ -44,9 +44,9 @@ function findFrameBySource(source: MessageEventSource | null) {
   }
 
   const roots: Array<Document | ShadowRoot> = [document]
+  let root: Document | ShadowRoot | undefined
 
-  while (roots.length) {
-    const root = roots.pop()!
+  while ((root = roots.pop())) {
     const walker = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT)
     let element = walker.nextNode() as Element | null
 

Original file line number	Diff line number	Diff line change
`@@ -44,9 +44,9 @@ function findFrameBySource(source: MessageEventSource \| null) {`
`44`	`44`	`}`
`45`	`45`
`46`	`46`	`const roots: Array<Document \| ShadowRoot> = [document]`
	`47`	`+ let root: Document \| ShadowRoot \| undefined`
`47`	`48`
`48`		`- while (roots.length) {`
`49`		`- const root = roots.pop()!`
	`49`	`+ while ((root = roots.pop())) {`
`50`	`50`	`const walker = document.createTreeWalker(root, NodeFilter.SHOW_ELEMENT)`
`51`	`51`	`let element = walker.nextNode() as Element \| null`
`52`	`52`