Refresh the CI

- Use github actions instead of travis (with checkout@v6)
- Use Policyfile instead of Berkshelf
- Bump gems dependencies
- Use kitchen dokken
- Target CentOS / Rockylinux 8 in tests
- Remove rspec coverage (slowing down the CI)

Author: Annih

.github/workflows/criteo-cookbooks-ci.yml

@@ -0,0 +1,49 @@
+# This is a basic workflow to help you get started with Actions
+name: Criteo Cookbooks CI
+on:
+  # Triggers the workflow on push or pull request events but only for the master branch
+  push:
+    branches: [ "main" ]
+    tags: [ 'v*' ]
+  pull_request:
+    branches: [ "main" ]
+  workflow_dispatch:
+jobs:
+  rspec:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v6
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+      - run: bundle exec rubocop --version
+      - run: bundle exec rubocop
+      - run: bundle exec rspec
+  kitchen:
+    needs: [rspec]
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        instance: ['scponly-rockylinux-8']
+    steps:
+      - uses: actions/checkout@v6
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 3.2
+          bundler-cache: true
+      - run: CHEF_LICENSE='accept-no-persist' bundle exec kitchen verify ${{ matrix.instance }}
+  supermarket:
+    runs-on: ubuntu-latest
+    if: startsWith(github.ref, 'refs/tags/')
+    needs: [kitchen]
+    steps:
+    - uses: actions/checkout@v6
+    - name: Publish to supermarket
+      uses: afaundez/chef-supermarket-action@8cdbe1cccbe1ecd8685b2ea8f48780135bae7cee
+      with:
+        user: criteo
+        cookbook: scponly
+        category: Utilities
+      env:
+        SUPERMARKET_API_KEY: ${{ secrets.SUPERMARKET_API_KEY }}

.gitignore

@@ -1,5 +1,4 @@
 .vagrant
-Berksfile.lock
 *~
 *#
 .#*
@@ -13,6 +12,4 @@ bin/*
 .bundle/*
 
 .kitchen/
-.kitchen.local.yml
-
-.cookbook_version
+Policyfile.lock.json

.kitchen.ec2.yml

@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 # Rules defined there are of course debatable.
 # If you want to modify them:
 # - discuss this with sre-core members
@@ -6,24 +8,22 @@
 AllCops:
   TargetRubyVersion: 2.3
 
-
-# This requires to alphabetically sort Gem's requirements
-Bundler/OrderedGems:
-  Enabled: false
-
 # This requires to add a comment inside nearly all file which could be
 # considered as toil without value
 Style/FrozenStringLiteralComment:
   Enabled: false
 
 ### Disable line length constraint
-Metrics/LineLength:
+Layout/LineLength:
   Max: 180
 # Because we're not in the 80s anymore.
 # Based on data from http://sideeffect.kr/popularconvention#ruby
 #
 ### Comma after each line in a list
-Style/TrailingCommaInLiteral:
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
   EnforcedStyleForMultiline: comma
 # It is very common to add key/value pairs to hashes in Chef attributes. Making
 # sure each line has a comma diminishes the chance of someone making an error
@@ -43,7 +43,7 @@ Style/TrailingCommaInLiteral:
 #   }
 #
 ### Align hashes as a table
-Layout/AlignHash:
+Layout/HashAlignment:
   EnforcedColonStyle: table
   EnforcedHashRocketStyle: key
 # When dealing with long key names, it is easier to read hashes in colon
@@ -73,7 +73,7 @@ Metrics/MethodLength:
   Max: 40
 
 # This rule generates many false positive
-Style/VariableNumber:
+Naming/VariableNumber:
   Enabled: false
 
 # This metric is hard to grasp but let's avoid delirious code
@@ -92,21 +92,12 @@ Style/StringLiterals:
 Style/FormatString:
   EnforcedStyle: percent
 
-# Really practical. Use with moderation though for readability
-Style/MultilineBlockChain:
-  Enabled: false
-
-# We ain't serving subseconds requests. Forcing to use tr instead of gsub will
-# be annoying without much value
-Performance/StringReplacement:
-  Enabled: false
-
 # We don't write documentation there at the moment
 Style/Documentation:
   Enabled: false
 
 # Filename forces snake case for file names, we just want consistency for now
-Style/FileName:
+Naming/FileName:
   Enabled: false
 
 # We don't want CRLF for ruby files, even on windows!

.kitchen.yml

@@ -0,0 +1,55 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2026-05-18 11:38:31 UTC using RuboCop version 1.81.7.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 3
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowBorderComment, AllowMarginComment.
+Layout/EmptyComment:
+  Exclude:
+    - 'spec/spec_helper.rb'
+    - 'spec/unit/recipes/default_spec.rb'
+
+# Offense count: 1
+# This cop supports safe autocorrection (--autocorrect).
+Layout/EmptyLines:
+  Exclude:
+    - 'spec/spec_helper.rb'
+
+# Offense count: 9
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
+# SupportedHashRocketStyles: key, separator, table
+# SupportedColonStyles: key, separator, table
+# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
+Layout/HashAlignment:
+  Exclude:
+    - 'spec/providers/add_spec.rb'
+
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Layout/LeadingEmptyLines:
+  Exclude:
+    - 'spec/providers/add_spec.rb'
+    - 'spec/providers/del_spec.rb'
+
+# Offense count: 6
+# This cop supports safe autocorrection (--autocorrect).
+# Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, IgnoreCopDirectives, AllowedPatterns, SplitStrings.
+# URISchemes: http, https
+Layout/LineLength:
+  Exclude:
+    - 'spec/providers/add_spec.rb'
+    - 'test/cookbooks/scponly_test/recipes/add_user.rb'
+    - 'test/integration/default/serverspec/check_user_spec.rb'
+
+# Offense count: 1
+# This cop supports unsafe autocorrection (--autocorrect-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'providers/user.rb'