feat: Implement readiness signal for NodeManagementBridgeSession before attaching manager

Author: Marko Petzold

crossbar/edge/node/management.py

@@ -187,9 +187,14 @@ def __init__(self, config):
         self._heartbeat_time_ns = None
         self._heartbeat = 0
         self._heartbeat_call = None
+        from twisted.internet.defer import Deferred
+        self._on_ready = Deferred()
 
     def onJoin(self, details):
         self.log.debug('{klass}.onJoin(details={details})', klass=self.__class__.__name__, details=details)
+        # Signal that bridge session is ready for attach_manager
+        if not self._on_ready.called:
+            self._on_ready.callback(None)
 
     @inlineCallbacks
     def attach_manager(self, manager, management_realm, node_id):

crossbar/edge/node/node.py

@@ -727,6 +727,8 @@ def on_ready_success(res):
                         self._manager, self._management_realm, self._management_session_id, self._node_id, self._node_extra = res
                         if self._bridge_session:
                             try:
+                                # Wait for bridge session to complete onJoin before attaching manager
+                                yield self._bridge_session._on_ready
                                 yield self._bridge_session.attach_manager(
                                     self._manager, self._management_realm, self._node_id)
                             except: