Commit fc619cd
authored
Fix 2256 (#2257)
* start new dev branch; add audit file
* Sync the ty ignore allowlist with Autobahn|Python (#2256)
`just check` (Code Quality Checks) was red on master, independently of any PR:
`ty` reported "Found 35 diagnostics", all in files unrelated to whatever was
being changed. The 35 were exactly two rules:
19 x warning[unused-type-ignore-comment]
16 x warning[possibly-missing-submodule]
Both are warnings, but ty still exits non-zero, so the gate failed.
The ratcheted --ignore allowlist pattern was not missing here - crossbar already
uses it - it had simply drifted behind autobahn-python, where BOTH of these
rules are already ignored. Add the two missing flags so crossbar tracks the
group's reference recipe.
Ignoring rather than fixing is the deliberate ratchet choice these allowlists
exist for: the gaps stay explicit and removable module-by-module (see
autobahn#1840). Note the 19 unused-type-ignore-comment hits mark `# type: ignore`
comments that are no longer needed and could simply be deleted - strictly better
than ignoring the rule - which is worth doing as a follow-up rather than in the
change that unblocks the gate.
Verified locally: `just check-typing cpy311` -> "All checks passed!", and the
full `just check cpy311` (format + typing + bandit) exits 0.
Note: This work was completed with AI assistance (Claude Code).1 parent 8f8f2ce commit fc619cd
2 files changed
Lines changed: 10 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
599 | 599 | | |
600 | 600 | | |
601 | 601 | | |
| 602 | + | |
| 603 | + | |
602 | 604 | | |
603 | 605 | | |
604 | 606 | | |
| |||
0 commit comments