Skip to content

Commit fc619cd

Browse files
authored
Fix 2256 (#2257)
* start new dev branch; add audit file * Sync the ty ignore allowlist with Autobahn|Python (#2256) `just check` (Code Quality Checks) was red on master, independently of any PR: `ty` reported "Found 35 diagnostics", all in files unrelated to whatever was being changed. The 35 were exactly two rules: 19 x warning[unused-type-ignore-comment] 16 x warning[possibly-missing-submodule] Both are warnings, but ty still exits non-zero, so the gate failed. The ratcheted --ignore allowlist pattern was not missing here - crossbar already uses it - it had simply drifted behind autobahn-python, where BOTH of these rules are already ignored. Add the two missing flags so crossbar tracks the group's reference recipe. Ignoring rather than fixing is the deliberate ratchet choice these allowlists exist for: the gaps stay explicit and removable module-by-module (see autobahn#1840). Note the 19 unused-type-ignore-comment hits mark `# type: ignore` comments that are no longer needed and could simply be deleted - strictly better than ignoring the rule - which is worth doing as a follow-up rather than in the change that unblocks the gate. Verified locally: `just check-typing cpy311` -> "All checks passed!", and the full `just check cpy311` (format + typing + bandit) exits 0. Note: This work was completed with AI assistance (Claude Code).
1 parent 8f8f2ce commit fc619cd

2 files changed

Lines changed: 10 additions & 0 deletions

File tree

.audit/oberstet_fix_2256.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
- [ ] I did **not** use any AI-assistance tools to help create this pull request.
2+
- [x] I **did** use AI-assistance tools to *help* create this pull request.
3+
- [x] I have read, understood and followed the projects' [AI Policy](https://github.com/crossbario/autobahn-python/blob/main/AI_POLICY.md) when creating code, documentation etc. for this pull request.
4+
5+
Submitted by: @oberstet
6+
Date: 2026-07-15
7+
Related issue(s): #2256
8+
Branch: oberstet:fix_2256

justfile

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -599,6 +599,8 @@ check-typing venv="":
599599
--ignore invalid-await \
600600
--ignore invalid-super-argument \
601601
--ignore invalid-exception-caught \
602+
--ignore possibly-missing-submodule \
603+
--ignore unused-type-ignore-comment \
602604
--exclude 'src/crossbar/worker/test/examples/syntaxerror.py' \
603605
src/crossbar/
604606

0 commit comments

Comments
 (0)