Skip to content

Commit 496430d

Browse files
authored
Fix type annotation of download_kwargs (#146)
Closes #145 This PR extends the `RequestKwargs` type dictionary with the other parts that are needed to call the `pystow.utils.download()` function
1 parent fe6d8ba commit 496430d

4 files changed

Lines changed: 91 additions & 74 deletions

File tree

src/pystow/api.py

Lines changed: 37 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
from .constants import JSON, Provider
1818
from .impl import Module, VersionHint
19-
from .utils.download import RequestKwargs
19+
from .utils.download import DownloadKwargs
2020

2121
if TYPE_CHECKING:
2222
import bs4
@@ -258,7 +258,7 @@ def ensure(
258258
name: str | None = None,
259259
version: VersionHint = None,
260260
force: bool = False,
261-
download_kwargs: RequestKwargs | None = None,
261+
download_kwargs: DownloadKwargs | None = None,
262262
) -> Path:
263263
"""Ensure a file is downloaded.
264264
@@ -311,7 +311,7 @@ def ensure_soup(
311311
name: str | None = None,
312312
version: VersionHint = None,
313313
force: bool = False,
314-
download_kwargs: RequestKwargs | None = None,
314+
download_kwargs: DownloadKwargs | None = None,
315315
beautiful_soup_kwargs: Mapping[str, Any] | None = None,
316316
) -> bs4.BeautifulSoup:
317317
"""Ensure a webpage is downloaded and parsed with :mod:`BeautifulSoup`.
@@ -384,7 +384,7 @@ def ensure_untar(
384384
name: str | None = None,
385385
directory: str | None = None,
386386
force: bool = False,
387-
download_kwargs: RequestKwargs | None = None,
387+
download_kwargs: DownloadKwargs | None = None,
388388
extract_kwargs: Mapping[str, Any] | None = None,
389389
) -> Path:
390390
"""Ensure a file is downloaded and untarred.
@@ -428,7 +428,7 @@ def ensure_gunzip(
428428
name: str | None = None,
429429
force: bool = False,
430430
autoclean: bool = True,
431-
download_kwargs: RequestKwargs | None = None,
431+
download_kwargs: DownloadKwargs | None = None,
432432
) -> Path:
433433
"""Ensure a file is downloaded and gunzipped.
434434
@@ -468,7 +468,7 @@ def ensure_open(
468468
url: str,
469469
name: str | None,
470470
force: bool,
471-
download_kwargs: RequestKwargs | None,
471+
download_kwargs: DownloadKwargs | None,
472472
mode: Literal["r", "rt", "w", "wt"] = ...,
473473
open_kwargs: Mapping[str, Any] | None,
474474
) -> Generator[StringIO, None, None]: ...
@@ -483,7 +483,7 @@ def ensure_open(
483483
url: str,
484484
name: str | None,
485485
force: bool,
486-
download_kwargs: RequestKwargs | None,
486+
download_kwargs: DownloadKwargs | None,
487487
mode: Literal["rb", "wb"] = ...,
488488
open_kwargs: Mapping[str, Any] | None,
489489
) -> Generator[BytesIO, None, None]: ...
@@ -496,7 +496,7 @@ def ensure_open(
496496
url: str,
497497
name: str | None = None,
498498
force: bool = False,
499-
download_kwargs: RequestKwargs | None = None,
499+
download_kwargs: DownloadKwargs | None = None,
500500
mode: Literal["r", "rt", "w", "wt"] | Literal["rb", "wb"] = "r",
501501
open_kwargs: Mapping[str, Any] | None = None,
502502
) -> Generator[StringIO | BytesIO, None, None]:
@@ -542,7 +542,7 @@ def ensure_open_zip(
542542
inner_path: str,
543543
name: str | None = ...,
544544
force: bool = ...,
545-
download_kwargs: RequestKwargs | None = ...,
545+
download_kwargs: DownloadKwargs | None = ...,
546546
mode: Literal["r", "w", "rb", "wb"] = ...,
547547
zipfile_kwargs: Mapping[str, Any] | None = ...,
548548
open_kwargs: Mapping[str, Any] | None = ...,
@@ -559,7 +559,7 @@ def ensure_open_zip(
559559
inner_path: str,
560560
name: str | None = ...,
561561
force: bool = ...,
562-
download_kwargs: RequestKwargs | None = ...,
562+
download_kwargs: DownloadKwargs | None = ...,
563563
mode: Literal["rt", "wt"] = ...,
564564
zipfile_kwargs: Mapping[str, Any] | None = ...,
565565
open_kwargs: Mapping[str, Any] | None = ...,
@@ -574,7 +574,7 @@ def ensure_open_zip(
574574
inner_path: str,
575575
name: str | None = None,
576576
force: bool = False,
577-
download_kwargs: RequestKwargs | None = None,
577+
download_kwargs: DownloadKwargs | None = None,
578578
mode: Literal["r", "w", "rb", "wb"] | Literal["rt", "wt"] = "r",
579579
zipfile_kwargs: Mapping[str, Any] | None = None,
580580
open_kwargs: Mapping[str, Any] | None = None,
@@ -629,7 +629,7 @@ def ensure_open_lzma(
629629
url: str,
630630
name: str | None,
631631
force: bool,
632-
download_kwargs: RequestKwargs | None,
632+
download_kwargs: DownloadKwargs | None,
633633
mode: Literal["r", "w", "rt", "wt"] = "rt",
634634
open_kwargs: Mapping[str, Any] | None,
635635
) -> Generator[io.TextIOWrapper[lzma.LZMAFile], None, None]: ...
@@ -644,7 +644,7 @@ def ensure_open_lzma(
644644
url: str,
645645
name: str | None,
646646
force: bool,
647-
download_kwargs: RequestKwargs | None,
647+
download_kwargs: DownloadKwargs | None,
648648
mode: Literal["rb", "wb"] = ...,
649649
open_kwargs: Mapping[str, Any] | None,
650650
) -> Generator[lzma.LZMAFile, None, None]: ...
@@ -657,7 +657,7 @@ def ensure_open_lzma(
657657
url: str,
658658
name: str | None = None,
659659
force: bool = False,
660-
download_kwargs: RequestKwargs | None = None,
660+
download_kwargs: DownloadKwargs | None = None,
661661
mode: Literal["r", "rb", "w", "wb", "rt", "wt"] = "rt",
662662
open_kwargs: Mapping[str, Any] | None = None,
663663
) -> Generator[lzma.LZMAFile | io.TextIOWrapper[lzma.LZMAFile], None, None]:
@@ -703,7 +703,7 @@ def ensure_open_tarfile(
703703
inner_path: str,
704704
name: str | None = ...,
705705
force: bool = False,
706-
download_kwargs: RequestKwargs | None = ...,
706+
download_kwargs: DownloadKwargs | None = ...,
707707
mode: Literal["rt"] = ...,
708708
open_kwargs: Mapping[str, Any] | None = ...,
709709
) -> Generator[typing.TextIO, None, None]: ...
@@ -719,7 +719,7 @@ def ensure_open_tarfile(
719719
inner_path: str,
720720
name: str | None = ...,
721721
force: bool = False,
722-
download_kwargs: RequestKwargs | None = ...,
722+
download_kwargs: DownloadKwargs | None = ...,
723723
mode: Literal["r", "rb"] = ...,
724724
open_kwargs: Mapping[str, Any] | None = ...,
725725
) -> Generator[typing.IO[bytes], None, None]: ...
@@ -733,7 +733,7 @@ def ensure_open_tarfile(
733733
inner_path: str,
734734
name: str | None = None,
735735
force: bool = False,
736-
download_kwargs: RequestKwargs | None = None,
736+
download_kwargs: DownloadKwargs | None = None,
737737
mode: Literal["r", "rb", "rt"] = "r",
738738
open_kwargs: Mapping[str, Any] | None = None,
739739
) -> Generator[typing.TextIO, None, None] | Generator[typing.IO[bytes], None, None]:
@@ -780,7 +780,7 @@ def ensure_open_gz(
780780
url: str,
781781
name: str | None,
782782
force: bool = False,
783-
download_kwargs: RequestKwargs | None,
783+
download_kwargs: DownloadKwargs | None,
784784
mode: Literal["r", "w", "rt", "wt"] = ...,
785785
open_kwargs: Mapping[str, Any] | None,
786786
) -> Generator[StringIO, None, None]: ...
@@ -795,7 +795,7 @@ def ensure_open_gz(
795795
url: str,
796796
name: str | None = None,
797797
force: bool = False,
798-
download_kwargs: RequestKwargs | None = None,
798+
download_kwargs: DownloadKwargs | None = None,
799799
mode: Literal["rb", "wb"] = ...,
800800
open_kwargs: Mapping[str, Any] | None = None,
801801
) -> Generator[BytesIO, None, None]: ...
@@ -808,7 +808,7 @@ def ensure_open_gz(
808808
url: str,
809809
name: str | None = None,
810810
force: bool = False,
811-
download_kwargs: RequestKwargs | None = None,
811+
download_kwargs: DownloadKwargs | None = None,
812812
mode: Literal["r", "rb", "w", "wb", "rt", "wt"] = "rb",
813813
open_kwargs: Mapping[str, Any] | None = None,
814814
) -> Generator[StringIO | BytesIO, None, None]:
@@ -851,7 +851,7 @@ def ensure_open_bz2(
851851
url: str,
852852
name: str | None = None,
853853
force: bool = False,
854-
download_kwargs: RequestKwargs | None = None,
854+
download_kwargs: DownloadKwargs | None = None,
855855
mode: Literal["rb"] = "rb",
856856
open_kwargs: Mapping[str, Any] | None = None,
857857
) -> Generator[bz2.BZ2File, None, None]:
@@ -893,7 +893,7 @@ def ensure_csv(
893893
url: str,
894894
name: str | None = None,
895895
force: bool = False,
896-
download_kwargs: RequestKwargs | None = None,
896+
download_kwargs: DownloadKwargs | None = None,
897897
read_csv_kwargs: Mapping[str, Any] | None = None,
898898
) -> pd.DataFrame:
899899
"""Download a CSV and open as a dataframe with :mod:`pandas`.
@@ -985,7 +985,7 @@ def ensure_yaml(
985985
url: str,
986986
name: str | None = None,
987987
force: bool = False,
988-
download_kwargs: RequestKwargs | None = None,
988+
download_kwargs: DownloadKwargs | None = None,
989989
open_kwargs: Mapping[str, Any] | None = None,
990990
yaml_load_kwargs: Mapping[str, Any] | None = None,
991991
) -> JSON:
@@ -1058,7 +1058,7 @@ def ensure_json(
10581058
url: str,
10591059
name: str | None = None,
10601060
force: bool = False,
1061-
download_kwargs: RequestKwargs | None = None,
1061+
download_kwargs: DownloadKwargs | None = None,
10621062
open_kwargs: Mapping[str, Any] | None = None,
10631063
json_load_kwargs: Mapping[str, Any] | None = None,
10641064
) -> JSON:
@@ -1105,7 +1105,7 @@ def ensure_json_bz2(
11051105
url: str,
11061106
name: str | None = None,
11071107
force: bool = False,
1108-
download_kwargs: RequestKwargs | None = None,
1108+
download_kwargs: DownloadKwargs | None = None,
11091109
open_kwargs: Mapping[str, Any] | None = None,
11101110
json_load_kwargs: Mapping[str, Any] | None = None,
11111111
) -> JSON:
@@ -1217,7 +1217,7 @@ def ensure_pickle(
12171217
url: str,
12181218
name: str | None = None,
12191219
force: bool = False,
1220-
download_kwargs: RequestKwargs | None = None,
1220+
download_kwargs: DownloadKwargs | None = None,
12211221
mode: Literal["rb"] = "rb",
12221222
open_kwargs: Mapping[str, Any] | None = None,
12231223
pickle_load_kwargs: Mapping[str, Any] | None = None,
@@ -1320,7 +1320,7 @@ def ensure_pickle_gz(
13201320
url: str,
13211321
name: str | None = None,
13221322
force: bool = False,
1323-
download_kwargs: RequestKwargs | None = None,
1323+
download_kwargs: DownloadKwargs | None = None,
13241324
mode: Literal["rb"] = "rb",
13251325
open_kwargs: Mapping[str, Any] | None = None,
13261326
pickle_load_kwargs: Mapping[str, Any] | None = None,
@@ -1392,7 +1392,7 @@ def ensure_xml(
13921392
url: str,
13931393
name: str | None = None,
13941394
force: bool = False,
1395-
download_kwargs: RequestKwargs | None = None,
1395+
download_kwargs: DownloadKwargs | None = None,
13961396
parse_kwargs: Mapping[str, Any] | None = None,
13971397
) -> lxml.etree.ElementTree:
13981398
"""Download an XML file and open it with :mod:`lxml`.
@@ -1491,10 +1491,10 @@ def ensure_excel(
14911491
url: str,
14921492
name: str | None = None,
14931493
force: bool = False,
1494-
download_kwargs: RequestKwargs | None = None,
1494+
download_kwargs: DownloadKwargs | None = None,
14951495
read_excel_kwargs: Mapping[str, Any] | None = None,
14961496
) -> pd.DataFrame:
1497-
"""Download an excel file and open as a dataframe with :mod:`pandas`.
1497+
"""Download an Excel file and open as a dataframe with :mod:`pandas`.
14981498
14991499
:param key: The module name
15001500
:param subkeys: A sequence of additional strings to join. If none are given, returns
@@ -1529,7 +1529,7 @@ def ensure_tar_df(
15291529
inner_path: str,
15301530
name: str | None = None,
15311531
force: bool = False,
1532-
download_kwargs: RequestKwargs | None = None,
1532+
download_kwargs: DownloadKwargs | None = None,
15331533
read_csv_kwargs: Mapping[str, Any] | None = None,
15341534
) -> pd.DataFrame:
15351535
"""Download a tar file and open an inner file as a dataframe with :mod:`pandas`.
@@ -1574,7 +1574,7 @@ def ensure_tar_xml(
15741574
inner_path: str,
15751575
name: str | None = None,
15761576
force: bool = False,
1577-
download_kwargs: RequestKwargs | None = None,
1577+
download_kwargs: DownloadKwargs | None = None,
15781578
parse_kwargs: Mapping[str, Any] | None = None,
15791579
) -> lxml.etree.ElementTree:
15801580
"""Download a tar file and open an inner file as an XML with :mod:`lxml`.
@@ -1618,7 +1618,7 @@ def ensure_zip_df(
16181618
inner_path: str,
16191619
name: str | None = None,
16201620
force: bool = False,
1621-
download_kwargs: RequestKwargs | None = None,
1621+
download_kwargs: DownloadKwargs | None = None,
16221622
read_csv_kwargs: Mapping[str, Any] | None = None,
16231623
) -> pd.DataFrame:
16241624
"""Download a zip file and open an inner file as a dataframe with :mod:`pandas`.
@@ -1658,7 +1658,7 @@ def ensure_zip_np(
16581658
inner_path: str,
16591659
name: str | None = None,
16601660
force: bool = False,
1661-
download_kwargs: RequestKwargs | None = None,
1661+
download_kwargs: DownloadKwargs | None = None,
16621662
load_kwargs: Mapping[str, Any] | None = None,
16631663
) -> numpy.typing.ArrayLike:
16641664
"""Download a zip file and open an inner file as an array-like with :mod:`numpy`.
@@ -1697,7 +1697,7 @@ def ensure_rdf(
16971697
url: str,
16981698
name: str | None = None,
16991699
force: bool = False,
1700-
download_kwargs: RequestKwargs | None = None,
1700+
download_kwargs: DownloadKwargs | None = None,
17011701
precache: bool = True,
17021702
parse_kwargs: Mapping[str, Any] | None = None,
17031703
) -> rdflib.Graph:
@@ -1909,7 +1909,7 @@ def ensure_open_sqlite(
19091909
url: str,
19101910
name: str | None = None,
19111911
force: bool = False,
1912-
download_kwargs: RequestKwargs | None = None,
1912+
download_kwargs: DownloadKwargs | None = None,
19131913
) -> Generator[sqlite3.Connection, None, None]:
19141914
"""Ensure and connect to a SQLite database.
19151915
@@ -1954,7 +1954,7 @@ def ensure_open_sqlite_gz(
19541954
url: str,
19551955
name: str | None = None,
19561956
force: bool = False,
1957-
download_kwargs: RequestKwargs | None = None,
1957+
download_kwargs: DownloadKwargs | None = None,
19581958
) -> Generator[sqlite3.Connection, None, None]:
19591959
"""Ensure and connect to a gzipped SQLite database.
19601960

0 commit comments

Comments
 (0)