Heroic Strike Queueing

[Zebouski]

I play on a server which is a fork of vmangos, and it has HS queuing implemented. To be specific:

https://us.forums.blizzard.com/en/wow/t/wow-classic-era-%E2%80%9Cnot-a-bug%E2%80%9D-list-updated-april-22-2021/175887

Offhand attacks that occur while on-next-hit abilities such as Heroic Strike are queued do not suffer the dual wield to-hit penalty.

Based off this, there's a tech you can do as a player, where you queue HS until right before your main hand swing goes out, then unqueue HS. The main hand swing lands, and you re-queue HS. This means you get the offhand hit benefits, without losing rage to an HS that you might want to spend on a bloodthirst first.

This is very difficult to do manually, but it seems this could be added as a feature in the addon, maybe requiring the user to spam the macro button very fast. Perhaps always queue, unless the macro is hit 0.5 seconds away from a HS land, then unqueue HS, unless above 50 rage.

[Zebouski]

From my research, the only way to tell if you are close to a hit, is to save a timestamp upon CHAT_MSG_COMBAT_SELF_MISSES and CHAT_MSG_COMBAT_SELF_HITS events and save UnitAttackSpeed("player") from that moment. Then do

if current timestamp - combat event timestamp > attackspeed - 0.5
  and UnitMana("player") < 50 then
    SpellStopCasting()

With the event watching... I'm worried this might be too much bloat to add to this addon

We'd also need to adjust the code block that casts HS so it uses it more aggresively: NextAttackRage would need to be set from 30 to down to 12 or whatever FuryHeroicStrikeCost is for the player, as HS queueing is beneficial the moment you can cast HS at all

[Bduncanson17]

@Zebouski I've created a function that does just this but it's a tad more complicated then you think. For these reasons:
1.) Main and and offhand strikes have the same event - solution parse the logs and calculate which event is for which hand using maths that includes the variables; armor reduction, off hand penalty, glancing reduction.
2.) Your going to need a function to determine if Hs/cleave is active.
3.)attack speed is ever changing so you need to register unit auras and update your attack speed almost constantly.

You have a better option if you are playing on night haven(vmangos) and that is to get your tanks to do threat right and push the ceiling out of reach while using all 4 armor debuffs to get the average bosses from 4691 to 0 armor. Do that and you’ll be able to just drop the heroic strikes because you won't be threat capped and you'll have unlimited rage(provided from the low armor and it's effects on white damage). Dropping HS prevents mh glancing and is a better option. Your also going to want to move away from one button automation and go for like a 4 button approach with each one a spam heroic strike if not qued and main functions are down. I put up 1.5k on Patch missing world buffs with this approach.
Best of luck with that it's nearly impossible to get others there for the social interactions to play ball, well using my approach.